From: Peter Rosin <peda@axentia.se>
To: Naresh Solanki <naresh.solanki@9elements.com>
Cc: Patrick Rudolph <patrick.rudolph@9elements.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/2] i2c: muxes: pca954x: Enable features on MAX7357
Date: Fri, 6 Oct 2023 12:32:26 +0200 [thread overview]
Message-ID: <79fd231f-c43a-bcbb-9660-c58e5bfbd953@axentia.se> (raw)
In-Reply-To: <29485a37-1f45-9f7f-9cc5-5d6a9fcc5e08@axentia.se>
Hi again!
[sorry for replying to self]
2023-10-06 at 09:46, Peter Rosin wrote:
> 2023-10-05 at 15:45, Naresh Solanki wrote:
>> From: Patrick Rudolph <patrick.rudolph@9elements.com>
>>
...
>> + dev_warn(&client->dev,
>> + "Write byte not supported. Cannot enable enhanced mode features");
>
> Missing \n at the end of the string.
>
Also, I2C_FUNC_SMBUS_WRITE_BYTE is separate from
I2C_FUNC_SMBUS_WRITE_BYTE_DATA, which makes that "Write byte"
misleading.
Cheers,
Peter
next prev parent reply other threads:[~2023-10-06 10:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-05 13:45 [PATCH v4 1/2] dt-bindings: i2c: pca954x: Add custom properties for MAX7357 Naresh Solanki
2023-10-05 13:45 ` [PATCH v4 2/2] i2c: muxes: pca954x: Enable features on MAX7357 Naresh Solanki
2023-10-05 23:00 ` Andi Shyti
2023-10-17 14:56 ` Naresh Solanki
2023-10-06 7:46 ` Peter Rosin
2023-10-06 10:32 ` Peter Rosin [this message]
2023-10-17 14:58 ` Naresh Solanki
2023-10-06 15:33 ` [PATCH v4 1/2] dt-bindings: i2c: pca954x: Add custom properties for MAX7357 Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79fd231f-c43a-bcbb-9660-c58e5bfbd953@axentia.se \
--to=peda@axentia.se \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=naresh.solanki@9elements.com \
--cc=patrick.rudolph@9elements.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®