From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752146AbdASKsT (ORCPT ); Thu, 19 Jan 2017 05:48:19 -0500 Received: from mga03.intel.com ([134.134.136.65]:12199 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751909AbdASKsS (ORCPT ); Thu, 19 Jan 2017 05:48:18 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,253,1477983600"; d="scan'208";a="810767207" Subject: Re: [RESEND RFC 1/3] mmc: sdhci: Add platform_dumpregs callback support to sdhci_ops. To: Ritesh Harjani , Shawn Lin , ulf.hansson@linaro.org References: <1484030515-16722-1-git-send-email-riteshh@codeaurora.org> <1484030515-16722-2-git-send-email-riteshh@codeaurora.org> <7cfc2b6c-fa3f-a8cb-d684-472c3dbacf2f@rock-chips.com> Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, georgi.djakov@linaro.org, asutoshd@codeaurora.org, stummala@codeaurora.org, venkatg@codeaurora.org, pramod.gurav@linaro.org, jeremymc@redhat.com From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: <79ff44d2-c20d-2dc7-9a0a-d77fb00df46d@intel.com> Date: Thu, 19 Jan 2017 12:43:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/01/17 09:57, Ritesh Harjani wrote: > Hi Shawn, > > On 1/10/2017 2:45 PM, Shawn Lin wrote: >> On 2017/1/10 14:41, Ritesh Harjani wrote: >>> From: Sahitya Tummala >>> >>> Add new host operation ->platform_dumpregs to provide a >>> mechanism through which host drivers can dump platform >>> specific registers in addition to SDHC registers >>> during error conditions. >>> >> >> Although we have been preventing from adding new callback >> for sdhci core, this one makes sense as there are more and more >> vendor registers outside the scope of SDHCI spec. We are not prevented from adding new callbacks, but they have to represent logical functions not quirks. This patch seems fine to me except the name "platform_dumpregs" because "platform" doesn't mean "platform" here. Just plain "dumpregs" is better.