From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D0FC385D9D for ; Mon, 25 May 2026 14:01:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779717690; cv=none; b=U0Oa5Np9WGjwGJi196S3lB+YMQ99dOO4VSd8u7wuTuhLE66YzQVlx+3h4F56gCt3ruQWLiehKv3od9tYyWfg8nsqye8ybtPel4lpSbg5FdensIy1PG6hLrWcKB0IOKK+y4BDn1YxSy3Yls+2RK2176cp5kwzCVQFj75PZt20mKg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779717690; c=relaxed/simple; bh=CZ9ggal6AI7begzqTI1xpoxUIDI833iw6KAnlGJ6Jrw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=aRfG//RNX0W34UnSa3HKwvCdWdhxFgw2Dt1mGp2penXSxBc0E5LVIezeyvZKSU1EEcHWvYYzP1nRyqyikMlNVeYK8mkroh7e0IFwfS+1I+Jim67PVN24dFePvc4M3HJ+Pfd9svpka83t49okOe6jtNggmLX9knCL0Eg0UnB9vo0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=BzIF6j+f; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dcls81yL; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="BzIF6j+f"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dcls81yL" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64P7Nqoh2211897 for ; Mon, 25 May 2026 14:01:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= I2xKLuvKpwz4CkrOfZZNnqoT3wHdH6+BVmL+VYCKYHE=; b=BzIF6j+f4mTI1yWw yusZQozgl4tSzZCkEjyjDMa8p+mUl//MLb7Y7C+w6/pUqLQ5j3tQIpenqyexm6FJ 7vTbLxhZXfB/2mm47a26Fb3dB51OmqTdxjdyvMBuEdP7MFTBTy6vGqsqnEdoBxN+ pGDvQWHgCG68ZOJ5s09SRc1gbNlyeeUViUdp+0VLV2KlccGVVTjU4W5Q2zbrXhPp ID59Ln87lnmMXddSrx8Pi+uztgaMObS7STymzLSDBSfhJ7Fz+tZOz4PvA+0Gu3GS wcuvuHc28WuaOSndLp7AaKMCzgO3PXDFfbfcfz9tzsU+/PvlqozTHCy8cIePdQUD RegVzg== Received: from mail-ot1-f70.google.com (mail-ot1-f70.google.com [209.85.210.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eb4m7pwqh-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 25 May 2026 14:01:28 +0000 (GMT) Received: by mail-ot1-f70.google.com with SMTP id 46e09a7af769-7e60476151cso947997a34.1 for ; Mon, 25 May 2026 07:01:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779717688; x=1780322488; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=I2xKLuvKpwz4CkrOfZZNnqoT3wHdH6+BVmL+VYCKYHE=; b=dcls81yL+BfcqtysRQUNnrAIMjekUj87EBb1t9lB5iV2f9RaEmH0SkW53qcTVgz46g 1G/38tmcCEsiwMU2KvtLbYgDAlmSLimV/p+Z11wVoJmdd+i06+buTaxHlbRgwlgXT5jq Ds0U86A1X3qc1GelHGkPsVSVppMcCB/fayx4B8kf1ANvlWvh+vGh7gJXxgyiMi92lifO N1sNTj5Oio9UH0U2BefaG4hom2vVguZJs/QBU/ejVj1CMoXk2Vh52IVl3q9IOyG0HQ// IAtNJei0rB+2RWvobP9hdCrRVgSGlgAbTuRkEMV6vMb5z9aqyUUaTOimzRRpd1VqGSUN Cqmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779717688; x=1780322488; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=I2xKLuvKpwz4CkrOfZZNnqoT3wHdH6+BVmL+VYCKYHE=; b=Ziw/Bsk+vvXJRkkcZfLUVOSfuxtA+sYqtzQ/DjE6bON9virnVgrmh3BDsQUEaJokpC bs8wI4rQKzcPuxGYrwcooILhepbdcyeV9uKdAYCzbbuYbXbTwO6KqinHuckt3IwgQ1YE PUlH7DOPxy157mbdvkFU7NCfrNta4WNuGX3Ug0G8/TkUP3mv+C00UAiml+vI+QmDEtaP ToBPTuF2FYawntd0Y3y4GJigQ/JGOgB4jnuOWWXHn3y+BWpfV3LaM23uCVayMF6z+4N8 ACZuE7UJ3qoayNq1w3Y0+aB50DrqeCNzKHOY4LKTnUnfaZOwBJATAKzXqkSnC5KvSoV4 K2PA== X-Forwarded-Encrypted: i=1; AFNElJ+NIXmVp43sgNRU6GCoM5rW+ghUedQ/pIeObV5qyg2zYw2gGfEjytnqzbbLTDHZHEHhp57GoDszYjmNDkk=@vger.kernel.org X-Gm-Message-State: AOJu0YwRJSElCR2FEB2V716CuCHJbXbNNdxr7jjDY/LA42Sz14LZfAuL angmpP53UFlF5LB/XNEHCZ59BOEcXQZjkFTYjcP/XJ45BtCKfMqa0of2eE8wlKwyUpwPFHoakuq YQbzpBII3nAujQnCM4hzF4d2JJwa6ac0vZUchLl1zQiU54iohW76ju2IvOlaqMDK6RUA= X-Gm-Gg: Acq92OFZCPgY15hLw+ly0JR+Cb/+jD2sqm2zDsVU60QyKCJo1+/DyULrd06cY87/Z/1 NEI29f/jcpdTQfakiadCI8uL3FAK79oyGQpTS9cpf1IsFt/LarGSg5z0Hcs5822xLGA08uyiEJW t523M/kHz/o0dqWlcpff3L6kWBCFF6hxft2xZd4PY6OKIPeaYpRpVXta8Dpgv0BqSajeqneec2w wpwCSy/sOo+hB1/6Hz020J9U6DSfeLT5R77KeMdVK/BXNEE6XwDD+iIy32vBcq/ALNQwp6tKmsc BRVaCI1aioL53RViflbVhjzn4PN2d268n/cCwaGhGYxxSThtNtl8OKrCRGCRiCKGYS/tDCnSO27 Hpd3dtHC9S34HrZtsjm442wG7FzfTwDAnO00oNBHmouwKKg== X-Received: by 2002:a05:6830:6f90:b0:7dc:d66f:9ac7 with SMTP id 46e09a7af769-7e5feeed784mr5562907a34.6.1779717687553; Mon, 25 May 2026 07:01:27 -0700 (PDT) X-Received: by 2002:a05:6830:6f90:b0:7dc:d66f:9ac7 with SMTP id 46e09a7af769-7e5feeed784mr5562883a34.6.1779717687150; Mon, 25 May 2026 07:01:27 -0700 (PDT) Received: from [192.168.119.254] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-688baf1e1fdsm4069015a12.19.2026.05.25.07.01.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 May 2026 07:01:26 -0700 (PDT) Message-ID: <79fff2b4-d8c1-4225-a75a-f9c2dc6a85e4@oss.qualcomm.com> Date: Mon, 25 May 2026 16:01:23 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 09/10] drm/msm/dp: turn link_ready into plugged To: Dmitry Baryshkov , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Kuogee Hsieh , Yongxing Mou Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Val Packett References: <20260524-hpd-refactor-v6-0-cf3ab488dd7b@oss.qualcomm.com> <20260524-hpd-refactor-v6-9-cf3ab488dd7b@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260524-hpd-refactor-v6-9-cf3ab488dd7b@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: SWPVpomqSiLaliU065ti8Bib3jV3hRad X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTI1MDE0MyBTYWx0ZWRfX5a2sN4AekcqA 1ZBAHaDy1xkYUkbsp4EgVmJbQY0jlpQX9KsIXWxP/MVx5QLzDatEnT0W5CAUP+UR/Gp+vymEM+R WGMp4gabBhL4EHsEp2DY3LzaHC9oBQqDzeYHcBJd+hVKQD11pQFmFETk4Y6Pt4GCmOyjNiBXljh 4x1Bq9Qida0TcaPqG42VnG5uBpNKjyngww6fzUhXva1axAUVRP3U0j1JmtcIqHG7+JcRqZoIk+6 zu2jQECLaUk/Qjf7WnowAXGTOAeJEQSPgu9cNXlVKmnn9J3SXAFdkczUo5jDaehd/6D4LPDOVby 8nHr6Sms0fXpCZ6tfVlBqFRxp4rE4zN2Hi1y10U/760L+mCz8ywTXNO329lLhlFbci3uev4Ulf2 CnGUc2RoiD6IRR6O8iDKLjhHavjPIIBciTw1PXlTvZgMS8qAZWF3KLEfBqP1FbYyMuk9KkrWqGi 6tu2QWBLphT+Kqom+RQ== X-Authority-Analysis: v=2.4 cv=MrJiLWae c=1 sm=1 tr=0 ts=6a145638 cx=c_pps a=7uPEO8VhqeOX8vTJ3z8K6Q==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=j2DAZ_cRoNPVBr-R0xcA:9 a=QEXdDO2ut3YA:10 a=EXS-LbY8YePsIyqnH6vw:22 X-Proofpoint-ORIG-GUID: SWPVpomqSiLaliU065ti8Bib3jV3hRad X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-25_04,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 priorityscore=1501 phishscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 bulkscore=0 malwarescore=0 spamscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605250143 On 5/24/26 12:33 PM, Dmitry Baryshkov wrote: > Tracking when the DP link is ready isn't that useful from the driver > point of view. It doesn't provide a direct information if the device > should be suspended, etc. Replace it with the 'plugged' boolean, which > is set when the driver knows that there is DPRX plugged. > > Tested-by: Val Packett # x1e80100-dell-latitude-7455 > Tested-by: Yongxing Mou # Hamoa IOT EVK, QCS8300 Ride > Signed-off-by: Dmitry Baryshkov > --- [...] > -static void msm_dp_display_host_phy_init(struct msm_dp_display_private *dp) > +/** > + * msm_dp_display_host_phy_init() - start up DP PHY > + * @dp: main display data structure > + * > + * Prepare DP PHY for the AUX transactions to succeed. > + * > + * Returns: true if this call has initliazed the PHY and false if the PHY has > + * already been setup beforehand. This assumes no failure. I hope adding various return-value checks across this driver is somewhere on the todolist.. [...] > end: > - pm_runtime_put_sync(&dp->pdev->dev); > + /* > + * If we detected the DPRX, leave the controller on so that it doesn't > + * loose the state. "lose" That is done.. presumably so that one could correct a coredump or similar? Konrad