From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from BN1PR04CU002.outbound.protection.outlook.com (mail-eastus2azon11010044.outbound.protection.outlook.com [52.101.56.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 618EB24DFF9 for ; Mon, 29 Dec 2025 16:41:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.56.44 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767026463; cv=fail; b=IymTfMUiklntVpO9Bz4Vb0PP77iaIsA07TKY3y+wav8UFWYUOf9L2o6GZZNQO3LjzOtJqOUn9o3ICvHOLTlP0Ibny8VTAz55rT+PRxu966eRv0Okrr9hbPTP8mMZjaPcSjtfiwb7/wcLeWjDrukJOQjwjVR18+++CE/CwNni0j8= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767026463; c=relaxed/simple; bh=ys27Oj65wXeqW4xlC6tvngGodQvSEPx4moFwzNO+/Dk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=MbEBdFjH3tFYfeqvvEE0Q87FX2cd+TkONxQxMHnI4XsmfdqaqfBbJpM3FUS4KKEFFTc+VSADnYFUQny4iml6QVIqXFIiPVJBQiCTKVjsZBcR3/iOFUHyJ9cJe5Fe1hIdcdxfkNg/5tdV58SViD4zrQnT2faQ8mYEizY2reiKiX0= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=s0PblPa6; arc=fail smtp.client-ip=52.101.56.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="s0PblPa6" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Hg69ZfdTtLEVZ5//Nz8Y8Gga9CYZuljGv2QKo3kiO1Q6h6uUnAfZbR3bx4qgD+hy2lkdhDV3KsnQNaAuwXVwHAtsukbeL8gq7QcKMKb+NtlxEpD4KvS/HMEIK908D4BZh4A/6hnQ2/vtbSBNA40wOSvRukT9eP7ZLNHUdvQiK598SsLo2vtsAKv9gBaKRwY58cj/DWXVkLOcVUE0RyPGWlaXIxTZOeywhAjivTquD08BnTHMdaXk9rN2f2vKMX4VBd1JM6Tc82iBO7YEUkxfT0G/S/jNfXM288NxwbL4su5O9n0gP9II25li5DOXhlXOFZVkiFLZr6EKLcj7aGZmbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0MDIoh+mPugToF2eI+YxN1F2kSdmJlrxfMYRuwZYE+M=; b=NFLUbbmXpFU4+9m5rzuoSy2+XdhC8/DmodYyFWKqWtjfHqfv3JGmyFDKTqRg8RWW8d6/aBJ7laIXu5nMwOV7+84tplXLG3PvKw5N0D3zj7dtjuD3wSt95XuVoQctS8HgQbGc8EnRekhpqnmvkwMga1dqitQPhftMhtpw5B1jQoN8jCCWHIcYvcKVspvGZhrLModnAOYW0gPtmZpoY+340H3bRzt641qGD7ZIozD6Q5bgOjUg8aLx841++gDjwYerh5K/VjY/VZgIRX8l+yjLyBj3txLQ7u6GlN5sdSTWQfNdCxVo5GwVkPlWNXl0nh93AohKNFJ77zhcqhpFoIoz9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0MDIoh+mPugToF2eI+YxN1F2kSdmJlrxfMYRuwZYE+M=; b=s0PblPa6ImbF0XrTwQsxBlGqvo9oafF/AbehloOL+k3j4S/MDHj9FqwYu35bTbKYB2GW3n9HApHrzRjHTJo4k4NAYdV309OmnRj/t+Ekj4bnNwPtN58xV70r2hpKN376ga2Qhr+iwwPYVzaclU5dl1w+jzhD4zcPYcnAEr4madUPg9b+HBI5Nu6eqdhK1rptEJh10I8FD1BB0OEWLhHRi1N4T+dKKbL4sfyFIaubPbfr/iMGmX5f4UbC5Gofc5smhktXqVFE2D2P4BKKTkkLFdxmMrqwAxsklSLzid+fRE13InPBxEjx3pE6j5bgB7skfr2HVWai9Oy5319NbFLsQA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) by MW4PR12MB7288.namprd12.prod.outlook.com (2603:10b6:303:223::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9456.14; Mon, 29 Dec 2025 16:40:59 +0000 Received: from DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a]) by DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a%5]) with mapi id 15.20.9456.013; Mon, 29 Dec 2025 16:40:58 +0000 From: Zi Yan To: Shivank Garg Cc: Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Baolin Wang , "Liam R . Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2 3/5] mm/khugepaged: change collapse_pte_mapped_thp() to return void Date: Mon, 29 Dec 2025 11:40:56 -0500 X-Mailer: MailMate (2.0r6290) Message-ID: <7A313858-704B-4E3F-8133-020213D108AB@nvidia.com> In-Reply-To: <20251224111351.41042-10-shivankg@amd.com> References: <20251224111351.41042-4-shivankg@amd.com> <20251224111351.41042-10-shivankg@amd.com> Content-Type: text/plain X-ClientProxiedBy: BL1PR13CA0327.namprd13.prod.outlook.com (2603:10b6:208:2c1::32) To DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9473:EE_|MW4PR12MB7288:EE_ X-MS-Office365-Filtering-Correlation-Id: 3e411dbc-2d37-44af-7b56-08de46f90b77 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|366016|1800799024|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?FRIKDmaeQTfi46CApEpT3nUs9Pl+bYo1gs2TGPOwNh4I6DcvUvTnTQYAWBf8?= =?us-ascii?Q?eAD/C9xBtT8RRlIHKmfEMN/j7UQ8c/I1FAQgoFVeBfafihslnIqAYOgLAkXC?= =?us-ascii?Q?zVker+WCl7EEUJD2B2+eX3SJYHYlC6AzPrnwf0JoU2gYPcfU5FI5chPsBMqg?= =?us-ascii?Q?9kWoDxsRhZDPzwbgtXtWF4Q2q2+HepmEVEa1/NAv8DMDX+SpKrD5Mxsacvh9?= =?us-ascii?Q?r30WsDLwq4OiV7/z9oahWOB7ARplbcQAi+5tkLv5EmEgp+bMjYG0zjCly37V?= =?us-ascii?Q?pjQC3O5tng/70RvcNf9OpFk+ospgBZ3K6Y1rnm+024GcU1QhRhNPL3xjXudq?= =?us-ascii?Q?hCnpDUjeZdhkq7SzJrEiLoqAlF88gM0pl6aI31jiv/APbsG7sbsp/I1XkjQA?= =?us-ascii?Q?qhrq6fNwdE0nu+SpuiJ5ojo0WKCOO0uoMz+mUH0hCl4Ro2I1zKDPhTvPf9uo?= =?us-ascii?Q?iYKLSmxZWs731ounmlunBbR/Z+WshzxBUT3YtMbbM2iZOTY2daHJPw9+vxJb?= =?us-ascii?Q?RmqqbU0sS47XyheNSO5uRnCYkm9qPQGhzSeRFb6QBfJ7IKIqLsVzcTr28TEP?= =?us-ascii?Q?HzrfGIIVNSQrL0dFbGx2vRSjGM6kmZFs2mY2qQEOUwXnm0nKS7dSbq/Di+3I?= =?us-ascii?Q?62yuR8dtNRprIdOI2T/frVAnlaZ9QHXP0x9dIgVTkNVsw3y0OzZwvBomQQd0?= =?us-ascii?Q?6nertKz/lfCqJbMcMMLuM32LrfgNKLtr2Cr/j5S6O/CTYoZenv64w6oQCFvB?= =?us-ascii?Q?4fE9NqnS2pTssKMbWUSWZdYCP0/vEEwroXUqhz97SWPImDJ+b0qISbEG+8Z0?= =?us-ascii?Q?tgDncZEZqtyKJhzC+IXG2pFhY2u9s6g/dx59so8ZTR6bkLZBGXWI6dv+3IdB?= =?us-ascii?Q?fiTPY3N9DJXpMhd/4JioSkeL6bGKxwckcSBFMFmIuuXmBStebqv2z54DpAQM?= =?us-ascii?Q?4OEl159vf+VOcn1kb06Xwjo9w+S4TRQPhH3kAItUAk1sPYV2IA8N5a8cTJ/B?= =?us-ascii?Q?OCZzoIVuDtRjWfM320yCTq9XYyn5w9sIMg25XZ3oS7MeIjrvVfJKLXpLFXcw?= =?us-ascii?Q?WWXkp0IznQVyHoLswIgh7RS7w2Hh9bWHcKYH2Bgq50y8n8UnvP8wJYdYmfYe?= =?us-ascii?Q?DtOpglXwLKqpCRKS0RBzVc8gcA6xxHxyKrVAHD+mKiLe3OG+XEu3K6d5ACxi?= =?us-ascii?Q?NehEkd9LtZ0aXjQdNvdPBGKspOI7SdXJfRbdSsRfsZ+HZ3bZj4WYuHLzO3HT?= =?us-ascii?Q?YpKGAQm+bPPUiz1KNfZCKKUDvhIBcb7sTj7endaN3FUbrKQVXLlTyftunDTk?= =?us-ascii?Q?ytoEODjhsKpeHr2Zj35O4sbsdX9TCkLcizWM71dWkmpF/Ljd/k4RICtDVOZq?= =?us-ascii?Q?rBRc0RL4PO0Mt4/vEDRQXZW1uoqfrMpWlNVKCQA6GeJma6SjpmoH/MqP8voS?= =?us-ascii?Q?K7TE8Ne9acq52j+E+ZQG9FsRdovYDgIa?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9473.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(366016)(1800799024)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?CToIZhrVuUwEOV5HdoU5GNq2Vb4EvmpR6E5tgQy4qQCmDarybNofEjVM/e2T?= =?us-ascii?Q?dO5BjrL86eck1aIJSeDYt0hEW/diFrfBlAm45cvRxqNg+IYM4/PRCw7Kt3CT?= =?us-ascii?Q?bFBAFqzgY3ldfxPmoX1rNeuE8bP80sD8aqRr7aLu/aVHVSRSpR2zCxj4Epk6?= =?us-ascii?Q?3HaVvFo94LgEOQvg46zFnURS4RQ2zOLgYJDT71rA9sByGgpaFlvsDp7Fb8xb?= =?us-ascii?Q?0uplpgxYeESUEIXyzgUwzJNn0tk7EoVQwti8pC5XqffNOtdiFvM7mmqdNpTu?= =?us-ascii?Q?ND0jSyLJh1+ZTkmPvj1Ne6GaMBb9YP1NC1F9ya904//kf9rOYYJ31IXod2tO?= =?us-ascii?Q?SPdOF/f2F8/ddgZkQDMKwoBw1GMolalrgGyvQ7k1h5a0tOZJQSadEHCHnfxq?= =?us-ascii?Q?XthU9cGd0hp0kR7gbhkFRqA5E9/PuI1lYmxEKofwcxGsbQuFBTQZohVW0m/k?= =?us-ascii?Q?0iNmYchnXXu07yv9DFh1HI3R/Rc+Vi81tOIRAYBLXh/AqSgbdq4Bny1em3Oq?= =?us-ascii?Q?zlNbHarG/wqDZdMuPPCxba5dtfHsRCOKqe80KWyigZKOV7yW5n5T4XVxQ8sJ?= =?us-ascii?Q?cnRVkDgUZHd1rhxVGfl7hCosqOnK9icMDv1z/i68oDwEIYlxAZcKR278/J3w?= =?us-ascii?Q?IiHqkAPiQJLyz9xXOyjrh66j3kL/V8vHH0ZGrug/c7etwVV3Bn8VOxyhZLGL?= =?us-ascii?Q?XaF7x4BIRgDncj1Eq01ryGtV+iY6DmRdleSX8kdaxOapLaIdcIGrXsEMmEN6?= =?us-ascii?Q?7rVcjzh68M8tAJoRb8Dv8ehUwYkdJuWhn+r8gbP4XtZ47WlWOqSausY6BmrA?= =?us-ascii?Q?21UGeViZxreBTUTt0auk7OnMYUmowRGUwk24yG2QYqi/Z+rCu9Q4qlgV8GkN?= =?us-ascii?Q?ORFYcK/Eq4Xsh6UJHqW7sAhhZKzrElxo9KYEcxY+2wA5eVKgQ6RcT4t8sZue?= =?us-ascii?Q?IwhWMjBNg+8xAMpC66vegcCY1lSuGJ2M04acltgcHIjlZeUoOxEUTjfGKrOr?= =?us-ascii?Q?+HRO9IqlISwayqEJOk9xtADFfR1VVysmJoOhb777lNpJpUgRjIrVk1cnDADV?= =?us-ascii?Q?LnRjox07Itn61pMpueIO3lXwxfzZIXOheagUFLeNrPgwLImOdRzefGGMGxIi?= =?us-ascii?Q?uRMmv+6IPMiwDLmmgFWEmKE3mCaywWjbCrcdCehZBbCkTWNOPzVn04Iisf+0?= =?us-ascii?Q?p6MMFX8EMAiq9nWPZguQOOOe6Hcrdc1Z8H3eAeir/9tRatbmjGcjq/NwljD1?= =?us-ascii?Q?sxkqE2uI9NpEuFUYqxc1Jf4yETAfA0Da6bnmA1WnrrhCkpE2HUCXYKrefNKu?= =?us-ascii?Q?yUe/WjunzYyse7gSbbGXJsZp+D+UsqqsOkCMa0ptMW078pQSuczSSsrIjoCy?= =?us-ascii?Q?f8NAKRL8uGiRi6De9FpxsFpM5yoXZ0eaGw4v5Zk05FpywT0EkrFdrGFtLUNJ?= =?us-ascii?Q?Q98Eujwq6uRVWooWc9HW82TNF4W8kVPMKSo3fufyjuc5+xmAoVddx6Qr1H+j?= =?us-ascii?Q?mJ7drTiY1M+ha2GnF8JlzyCpUTOtSDfhzjjFlv/zZ2jly5WsBwlpmBjeyJpD?= =?us-ascii?Q?Tt1EtNx7pJis6gIPtQAQxAOiM2oldLowZosGJlHBCFYClcSUCkSpDl7Dos7f?= =?us-ascii?Q?htglHYUPhG4SE+JBOcaBxY6UVBkb3Dl0WgVQXBByvKOtkjLJ4ojENhkY9lOP?= =?us-ascii?Q?W9x4AyW1NoETLjfPmNgtU786FrEtDrapJYjujYzKIbD+EVwj?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3e411dbc-2d37-44af-7b56-08de46f90b77 X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9473.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Dec 2025 16:40:58.7595 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5Bt+CNbGfhqkAXuh98qqPPdUF/isFo31VkrMpXthYJ6L06Qc894A8uF3hsoyQyCK X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7288 On 24 Dec 2025, at 6:13, Shivank Garg wrote: > The only external caller of collapse_pte_mapped_thp() is uprobe, which > ignores the return value. Change the external API to return void to > simplify the interface. > > Introduce try_collapse_pte_mapped_thp() for internal use that preserves > the return value. This prepares for future patch that will convert > the return type to use enum scan_result. > > Suggested-by: David Hildenbrand (Red Hat) > Signed-off-by: Shivank Garg > --- > include/linux/khugepaged.h | 9 ++++----- > mm/khugepaged.c | 40 ++++++++++++++++++++++---------------- > 2 files changed, 27 insertions(+), 22 deletions(-) > LGTM. Reviewed-by: Zi Yan -- Best Regards, Yan, Zi