From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC49054652 for ; Sun, 19 Apr 2026 12:33:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776602026; cv=none; b=UWYHZgUqtiCy76ImYkr7R2jjAZAJCz6HI2EjwnW/vU9Hn4KQpbcdaTHFAxIg5L3mHpDnXgY1KB+zdy9Xmi03QSxukyTuAhHbZ+/Nw3h61/CEp6pV9Oq/mhS3s0TBeatCz5Vu/cjaMX1ECy/Xk4XVAz3IoL+Dg8h35FFua1ARQZw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776602026; c=relaxed/simple; bh=X/es29bQSN1AfbXkH6z+8r6iwDxPNWDNhuOY3z7r8pE=; h=Date:From:To:CC:Subject:In-Reply-To:References:Message-ID: MIME-Version:Content-Type; b=dY3kh8kiCLhf6Ak/sI0ctcZfceSVr5a4YAaxElq9BJMR9m07R2Zjw2U+J2bqTrgCwc2FH03mirwLTLPJw9y4iwtD9o2caVx5fIwhC38QozDbl9MCPEnFi6OrlTArMLqHibyb1pdZ2pJeMZrkk7qmvnxqPIZACY/uC2/bY06ybkM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CbNrWtZg; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CbNrWtZg" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-82cebbdbdccso1252162b3a.1 for ; Sun, 19 Apr 2026 05:33:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776602024; x=1777206824; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=uMoAnB62rBPrxwRnaXdMyvz8FV00xhob3aGKaVN6sMc=; b=CbNrWtZgjD1vUvHVSqwOBrLgk3GNo5yuyT+x/98tKrLVKdFZam7zWoQ3lQFb9pMtEn NiDQNWhOHmKJmn55R03kn7YzgXc+Pasjxvu1PFuMCoBeevwaOy+h6/CyZtq1c5U21QbJ fge4H82oCHPnqdRDQBUKtnSR2FiH/qkpMiLknXIHcrLbLVJKcLoLBq8XYdln9uv1TFQm 5XNcKvFyeJxFU5SUfaVMFAadizMRiXaH1CaPELpWcOOoYOogSsaqRILER0VuI3SbSWi+ vYwE7U0i0Rct1qHqXpQpb+chjd5kFxyV/b1URTIQtDkKm+tT2eCrRkj36b/9szpw/Rrw FyYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776602024; x=1777206824; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uMoAnB62rBPrxwRnaXdMyvz8FV00xhob3aGKaVN6sMc=; b=o0elumlZIT24KcvZ5oRUO5/bIfyB+9HY+wGRsRHc3wfq8RHJ+jyjoyU3qGrVnMZRBP NyrQBuwfjnYR27acGhovKvwtJmZ1UGFjD84ItRwqv88WM2iWVHaIKBEyePJ2MO1M9n32 +WC52fJnfF0hY5vQDy5zbbjs2zqi7r4Vb0Rrqnwz4fQ+Q9jz7CCvEReGGBMWlIF1mPx4 0VeDmsp5eMvmPZ7n/ZUJD2WNX1zKRxVMb4dcxYWMxh0L1a2E4+ksRxFsP3EKe7cJqjZ7 s1tpZFL7a0dDuS2hlhtygyfqzl2YlaILJXcyKOGrIO/Njhy03F5FEYEKrwOX3QUHznAK Fipw== X-Forwarded-Encrypted: i=1; AFNElJ9gyQeyZuP/Ga7dzZjGZka692OYF0YH9BIN08nkB2x3swen+b26qnMhScgss8ehrSwi5UB3QcZuz6QNxpE=@vger.kernel.org X-Gm-Message-State: AOJu0YwZnVstTXCSkxd+8JmVZOwqJC9jZnWnME27+UlBVsxgc80HZCVs v+fqFai7+6jVVIQUA/nKep/Z61q5qEszUcvRsAyCjyh5arO2f9/8IFyB X-Gm-Gg: AeBDieuWb6aMxC6rjoxveA4P5mwLem1vYIFWvWLN5wyGBONzn2VGa8c64tpkP0l4u1C MRztkPcnNO7U0YNGWjlXJP1LzshmCaQgybE1EG/+CmpIPbWx8RFRGNnW5egn8vTULAgxgWm15JQ NStnC356sHGqM2BrvZnmCI0f8SEGAsY5bGic0C52PSw3VzeHooScqT18QzQT14UHwaypCaYnxbz TSExBzGctnh4FpOoDl8itvmdrGAcBj9wpJ1kSlVWfS1MjbJr2GPwo3xWHodWZbXJiwB5eu1oOmg WjXCAs3gybGi6W9qaEqZI2hFN2A4upmtLqmEAiuWblwEx+luWvWD7oj616wAgeHcYL7xTD2OEiC xlihdko0e3gxcHuVT/CYv/j1i7eyxOaESAn9O9iJCUGCBPZB7hfRKbbHdttxgZOS2+kxktxl77j HGdhUS+a5I5XGUUqrbdI1cSZB+erm4nnP7fG+tTBT5/YhVEEWfLgik0g== X-Received: by 2002:aa7:8892:0:b0:82f:1f43:7190 with SMTP id d2e1a72fcca58-82f8b32160dmr8536470b3a.3.1776602024166; Sun, 19 Apr 2026 05:33:44 -0700 (PDT) Received: from ehlo.thunderbird.net ([2401:4900:ac16:b3b:3927:d65:a5c:bf50]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8ebb38ddsm7161793b3a.34.2026.04.19.05.33.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 19 Apr 2026 05:33:43 -0700 (PDT) Date: Sun, 19 Apr 2026 18:03:39 +0530 From: Sanjay Chitroda To: Andy Shevchenko CC: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, tglx@kernel.org, christophe.jaillet@wanadoo.fr, mingo@kernel.org, nabijaczleweli@nabijaczleweli.xyz, kees@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_v6_5/7=5D_iio=3A_ssp=5Fsensors=3A_convert?= =?US-ASCII?Q?_probe_and_teardown_to_devm-managed_resources?= User-Agent: Thunderbird for Android In-Reply-To: References: <20260415050749.3858046-1-sanjayembedded@gmail.com> <20260415050749.3858046-6-sanjayembedded@gmail.com> Message-ID: <7A3BFA1E-3B6C-403C-9CB8-DFCD30B03DBF@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 15 April 2026 3:03:17=E2=80=AFpm IST, Andy Shevchenko wrote: >On Wed, Apr 15, 2026 at 10:37:47AM +0530, Sanjay Chitroda wrote: > >> Convert SSP driver resource management to use devm-managed helpers >> and devm actions, tying the lifetime of all resources to the device=2E >>=20 >> Mutex initialization, IRQ registration, work items, timers, and MFD >> resource are now managed using devm APIs=2E Cleanup logic previously >> handled explicitly in probe error paths and the remove callback is >> replaced with devm_add_action_or_reset(), ensuring correct teardown >> ordering and consistent behaviour on probe failure and device unbind=2E >>=20 >> This simplifies the probe path by removing goto-based error handling, >> eliminates the remove callback entirely=2E >>=20 >> No functional change intended=2E > >=2E=2E=2E > >> + ret =3D devm_add_action_or_reset(&spi->dev, >> + ssp_disable_wdt_timer, data); > >It's perfectly a single line of 79 characters (we allow 80 in strict mode= and >100 in relaxed and you seems stick with the former, which is fine)=2E > Agree, will cross confirm and rectify in next series=2E > ret =3D devm_add_action_or_reset(&spi->dev, ssp_disable_wdt_timer, data)= ; > >=2E=2E=2E > >> + ret =3D devm_add_action_or_reset(&spi->dev, >> + ssp_shutdown_action, data); > >Ditto=2E >