From: Nadav Amit <nadav.amit@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Nadav Amit <namit@cs.technion.ac.il>,
gleb@kernel.org, tglx@linutronix.de, mingo@redhat.com,
x86@kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: x86: Fix page-tables reserved bits
Date: Mon, 28 Apr 2014 15:20:33 +0300 [thread overview]
Message-ID: <7B24A2A6-1C06-4BC7-8C11-9D013E7F338A@gmail.com> (raw)
In-Reply-To: <535E3061.2030402@redhat.com>
On Apr 28, 2014, at 1:41 PM, Paolo Bonzini <pbonzini@redhat.com> wrote:
> Il 17/04/2014 00:04, Marcelo Tosatti ha scritto:
>>>>> > >> @@ -3550,9 +3550,9 @@ static void reset_rsvds_bits_mask(struct kvm_vcpu *vcpu,
>>>>> > >> break;
>>>>> > >> case PT64_ROOT_LEVEL:
>>>>> > >> context->rsvd_bits_mask[0][3] = exb_bit_rsvd |
>>>>> > >> - rsvd_bits(maxphyaddr, 51) | rsvd_bits(7, 8);
>>>>> > >> + rsvd_bits(maxphyaddr, 51) | rsvd_bits(7, 7);
>>>>> > >> context->rsvd_bits_mask[0][2] = exb_bit_rsvd |
>>>>> > >> - rsvd_bits(maxphyaddr, 51) | rsvd_bits(7, 8);
>>>>> > >> + rsvd_bits(maxphyaddr, 51) | rsvd_bits(7, 7);
>>>> > >
>>>> > > Bit 7 is not reserved either, for the PDPTE (its PageSize bit).
>>>> > >
>>> >
>>> > In long mode (IA-32e), bit 7 is definitely reserved.
>
> It's always reserved for PML4E (rsvd_bits_mask[x][3]), while for PDPTEs it is not reserved if you have 1GB pages.
>
>> There is a separate reserved mask for PS=1, nevermind.
>>
>
> Yeah, but the situation for IA32e rsvd_bits_mask[0][2] is exactly the same as for PAE rsvd_bits_mask[0][1], and we're not marking the bit as reserved there.
>
> The right thing to do is to add rsvd_bits(7, 7) to both rsvd_bits_mask[0][2] and rsvd_bits_mask[1][2], if 1GB pages are not supported.
>
> As written, the patch has no effect on PDPTEs because rsvd_bits_mask[0][2] is only accessed if bit 7 is zero.
>
> Nadav, would you mind preparing a follow-up? Also, how did you find these issues and test the fixes?
I will create a follow-up as soon as possible. We encountered the issues in a custom testing environment.
The fixes were validated using the failing tests, but they cover additional cases which might not have been tested.
Regards,
Nadav
prev parent reply other threads:[~2014-04-28 12:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 3:31 Nadav Amit
2014-04-16 19:03 ` Marcelo Tosatti
2014-04-16 21:17 ` H. Peter Anvin
2014-04-16 22:04 ` Marcelo Tosatti
2014-04-28 10:41 ` Paolo Bonzini
2014-04-28 12:20 ` Nadav Amit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7B24A2A6-1C06-4BC7-8C11-9D013E7F338A@gmail.com \
--to=nadav.amit@gmail.com \
--cc=gleb@kernel.org \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mtosatti@redhat.com \
--cc=namit@cs.technion.ac.il \
--cc=pbonzini@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®