From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933750AbdA0R3s (ORCPT ); Fri, 27 Jan 2017 12:29:48 -0500 Received: from mail-pg0-f66.google.com ([74.125.83.66]:35232 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934041AbdA0R3Q (ORCPT ); Fri, 27 Jan 2017 12:29:16 -0500 Date: Fri, 27 Jan 2017 09:29:00 -0800 User-Agent: K-9 Mail for Android In-Reply-To: <20170127172514.GX9511@var.bordeaux.inria.fr> References: <20170127171318.2596-1-benjamin.tissoires@redhat.com> <20170127171318.2596-3-benjamin.tissoires@redhat.com> <20170127172514.GX9511@var.bordeaux.inria.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Subject: Re: [PATCH 2/4] tty/vt/keyboard: Fix Caps Lock LED on major distributions To: Samuel Thibault , Benjamin Tissoires CC: Greg Kroah-Hartman , Jiri Slaby , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org From: Dmitry Torokhov Message-ID: <7BA8EE40-6F85-450A-AAAA-F39485D2F30E@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v0RHUoCC023229 On January 27, 2017 9:25:14 AM PST, Samuel Thibault wrote: >Benjamin Tissoires, on Fri 27 Jan 2017 18:13:16 +0100, wrote: >> +static bool caps_as_controlllock; > >Really, we don't want these. Userspace could invent using another >modifier, so it's really not the way forward. Please have a look at >what I suggested. Completely agree. Thanks. -- Dmitry