From: "Zhaolei" <zhaolei@cn.fujitsu.com>
To: "Ingo Molnar" <mingo@elte.hu>
Cc: "Frederic Weisbecker" <fweisbec@gmail.com>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Tom Zanussi" <tzanussi@gmail.com>,
"LKML" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 0/2] ftrace: Add task_comm support for trace_event
Date: Mon, 25 May 2009 16:59:26 +0800 [thread overview]
Message-ID: <7BEB795002534E81BFA42E0464AEFD72@zhaoleiwin> (raw)
In-Reply-To: <20090522115108.GA10992@elte.hu>
* From: "Ingo Molnar" <mingo@elte.hu>
>
> it still fails to build:
>
> kernel/built-in.o: In function `ftrace_event_enable_disable':
> trace_events.c:(.text+0x4df08): undefined reference to `tracing_stop_cmdline_record'
> trace_events.c:(.text+0x4df1f): undefined reference to `tracing_start_cmdline_record'
>
> config attached.
Hello, Ingo
Thanks for your report.
I found reason.
It is because CONFIG_TRACING is on(But CONFIG_FTRACE is off),
which compiles trace_events but leaves trace_sched_switch.
(It is different with problem that I fixed in v1->v2, but... sorry......)
I have fixed it, I'll send v3 after following test:
1: CONFIG_TRACING on, CONFIG_FTRACE off
2: CONFIG_ENABLE_EVENT_TRACING on, CONFIG_ENABLE_CONTEXT_SWITCH_TRACER off
2: CONFIG_ENABLE_EVENT_TRACING on, CONFIG_ENABLE_CONTEXT_SWITCH_TRACER on
And RFC:
IMHO, trace_sched_switch should not have relationship with trace_events,
in other words, trace_events should run without trace_sched_switch linked.
Can we move codes for record cmdline out of trace_sched_switch.c and put them
into new cmdline_record.c?
Then, trace_functions.c and trace_events.c will only need cmdline_record.c.
Thanks
Zhaolei
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
next prev parent reply other threads:[~2009-05-25 9:00 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-21 7:08 [PATCH 1/2] " Zhaolei
2009-05-21 7:09 ` [PATCH 2/2] ftrace: clean up of using ftrace_event_enable_disable() Zhaolei
2009-05-21 13:16 ` Steven Rostedt
2009-05-21 13:15 ` [PATCH 1/2] ftrace: Add task_comm support for trace_event Steven Rostedt
2009-05-22 8:01 ` Ingo Molnar
2009-05-22 8:25 ` Ingo Molnar
2009-05-22 8:49 ` Zhaolei
2009-05-22 10:03 ` [PATCH v2 0/2] " Zhaolei
2009-05-22 10:05 ` [PATCH v2 1/2] " Zhaolei
2009-05-24 20:42 ` Frederic Weisbecker
2009-05-25 3:54 ` Zhaolei
2009-05-25 8:27 ` Frederic Weisbecker
2009-05-22 10:06 ` [PATCH v2 2/2] ftrace: clean up of using ftrace_event_enable_disable() Zhaolei
2009-05-24 20:46 ` Frederic Weisbecker
2009-05-25 5:34 ` Zhaolei
2009-05-25 8:32 ` Frederic Weisbecker
2009-05-22 11:51 ` [PATCH v2 0/2] ftrace: Add task_comm support for trace_event Ingo Molnar
2009-05-25 8:59 ` Zhaolei [this message]
2009-05-25 16:45 ` Frederic Weisbecker
2009-05-25 17:01 ` Frederic Weisbecker
2009-05-25 10:03 ` [PATCH v3 " Zhaolei
2009-05-25 10:11 ` [PATCH v3 1/2] " Zhaolei
2009-05-26 0:44 ` Frederic Weisbecker
2009-05-25 10:13 ` [PATCH v3 2/2] ftrace: clean up of using ftrace_event_enable_disable() Zhaolei
2009-05-23 15:16 ` [PATCH 1/2] ftrace: Add task_comm support for trace_event Christoph Hellwig
2009-05-23 15:18 ` Christoph Hellwig
2009-05-27 22:34 ` [tip:tracing/core] " tip-bot for Zhaolei
2009-05-27 22:35 ` [tip:tracing/core] ftrace: clean up of using ftrace_event_enable_disable() tip-bot for Zhaolei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7BEB795002534E81BFA42E0464AEFD72@zhaoleiwin \
--to=zhaolei@cn.fujitsu.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=tzanussi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®