From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B10CDC433E0 for ; Mon, 29 Mar 2021 15:22:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8518E61982 for ; Mon, 29 Mar 2021 15:22:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230448AbhC2PVx convert rfc822-to-8bit (ORCPT ); Mon, 29 Mar 2021 11:21:53 -0400 Received: from aposti.net ([89.234.176.197]:55270 "EHLO aposti.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229655AbhC2PVZ (ORCPT ); Mon, 29 Mar 2021 11:21:25 -0400 Date: Mon, 29 Mar 2021 16:21:07 +0100 From: Paul Cercueil Subject: Re: [PATCH] drm: DON'T require each CRTC to have a unique primary plane To: Pekka Paalanen Cc: Simon Ser , Thomas Zimmermann , David Airlie , linux-kernel@vger.kernel.org, od@zcrc.me, dri-devel@lists.freedesktop.org, stable@vger.kernel.org Message-Id: <7BLQQQ.ZY1PEPCLZS2L2@crapouillou.net> In-Reply-To: <20210329173541.00b301ea@eldfell> References: <20210327112214.10252-1-paul@crapouillou.net> <1J_tcDPSAZW23jPO8ApyzgINcVRRWcNyFP0LvrSFVIMbZB9lH6lCWvh2ByU9rNt6bj6xpgRgv8n0hBKhXAvXNfLBGfTIsvbhYuHW3IIDd7Y=@emersion.fr> <24LMQQ.CRNKYEI6GB2T1@crapouillou.net> <20210329111533.47e44f72@eldfell> <20210329173541.00b301ea@eldfell> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le lun. 29 mars 2021 à 17:35, Pekka Paalanen a écrit : > On Mon, 29 Mar 2021 12:41:00 +0100 > Paul Cercueil wrote: > >> Hi, >> >> Le lun. 29 mars 2021 à 11:15, Pekka Paalanen >> a >> écrit : >> > On Sat, 27 Mar 2021 11:26:26 +0000 >> > Paul Cercueil wrote: >> > >> >> It has two mutually exclusive background planes (same Z level) >> + one >> >> overlay plane. >> > >> > What's the difference between the two background planes? >> > >> > How will generic userspace know to pick the "right" one? >> >> First primary plane cannot scale, supports RGB and C8. Second >> primary >> plane goes through the IPU, and as such can scale and convert pixel >> formats; it supports RGB, non-planar YUV, and multi-planar YUV. >> >> Right now the userspace apps we have will simply pick the first one >> that fits the bill. > > What would be the downside of exposing just one "virtual" primary > plane, and then have the driver pick one of the two hardware planes as > appropriate per modeset? The IPU plane is in a different driver, so all the callbacks are different. That sounds like it would be a mess. -Paul > Thanks, > pq > >> >> Le sam. 27 mars 2021 à 11:24, Simon Ser a >> >> écrit >> >> : >> >> > On Saturday, March 27th, 2021 at 12:22 PM, Paul Cercueil >> >> > wrote: >> >> > >> >> >> The ingenic-drm driver has two mutually exclusive primary >> planes >> >> >> already; so the fact that a CRTC must have one and only one >> >> primary >> >> >> plane is an invalid assumption. >> >> > >> >> > Why does this driver expose two primary planes, if it only >> has a >> >> > single >> >> > CRTC? >> >> >> >> >> >> _______________________________________________ >> >> dri-devel mailing list >> >> dri-devel@lists.freedesktop.org >> >> https://lists.freedesktop.org/mailman/listinfo/dri-devel >> > >> >> >