From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F881C47247 for ; Thu, 7 May 2020 07:59:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DF0A020753 for ; Thu, 7 May 2020 07:59:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=zytor.com header.i=@zytor.com header.b="edDncOw6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726743AbgEGH7m (ORCPT ); Thu, 7 May 2020 03:59:42 -0400 Received: from terminus.zytor.com ([198.137.202.136]:41511 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725969AbgEGH7l (ORCPT ); Thu, 7 May 2020 03:59:41 -0400 Received: from [IPv6:2601:646:8600:3281:d918:a6fd:d52c:4754] ([IPv6:2601:646:8600:3281:d918:a6fd:d52c:4754]) (authenticated bits=0) by mail.zytor.com (8.15.2/8.15.2) with ESMTPSA id 0477xAJT3336894 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NO); Thu, 7 May 2020 00:59:10 -0700 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.zytor.com 0477xAJT3336894 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zytor.com; s=2020042201; t=1588838351; bh=QcutLOCTnJxVMrJr2hvrS8R5JE5w+xhrOu5seWrSXig=; h=Date:In-Reply-To:References:Subject:To:CC:From:From; b=edDncOw6ExGuJsk6POL7egz6dy6fPWjFEWh3td3E9oMv5SXP0TJbKzQatvtT4mA/j FIW8/LpQww4n+9WGTUWqSD2T0iWg4UjNAE4DsNqkc/mf0UV8BDhUqPBwsKqMo8R2AM /PTK+lZWRYBujbzoOQIPodZXEvkh9sty32cJT/KBGuBA8xPCyX2CdzirMHzK0f+rfy 0hwDI7S6Mq6sAVqr6gwuogD8Y6ZN4V2SvhbMUtya6HiJ06MbItx1CqUemLfdJvNpYB urzr+rNBVisCE/9E879nByfmNSPBNjvZX7mduX3QwON++dhPNTNACREVYz/i1RqVqa 8pnWGB4jymFKw== Date: Thu, 07 May 2020 00:59:03 -0700 User-Agent: K-9 Mail for Android In-Reply-To: <60b16c05ca9e4954a7e4fcdd3075e23d@AcuMS.aculab.com> References: <20200505174423.199985-1-ndesaulniers@google.com> <60b16c05ca9e4954a7e4fcdd3075e23d@AcuMS.aculab.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: RE: [PATCH] x86: bitops: fix build regression To: David Laight , "'Brian Gerst'" , Nick Desaulniers CC: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Sedat Dilek , stable , Jesse Brandeburg , "kernelci . org bot" , Andy Shevchenko , Ilie Halip , the arch/x86 maintainers , Marco Elver , "Paul E. McKenney" , "Peter Zijlstra (Intel)" , Daniel Axtens , Masahiro Yamada , Luc Van Oostenryck , Linux Kernel Mailing List , "clang-built-linux@googlegroups.com" From: hpa@zytor.com Message-ID: <7C32CF96-0519-4C32-B66B-23AD9C1F1F52@zytor.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On May 7, 2020 12:44:44 AM PDT, David Laight = wrote: >From: Brian Gerst >> Sent: 07 May 2020 07:18 >=2E=2E=2E >> > --- a/arch/x86/include/asm/bitops=2Eh >> > +++ b/arch/x86/include/asm/bitops=2Eh >> > @@ -54,7 +54,7 @@ arch_set_bit(long nr, volatile unsigned long >*addr) >> > if (__builtin_constant_p(nr)) { >> > asm volatile(LOCK_PREFIX "orb %1,%0" >> > : CONST_MASK_ADDR(nr, addr) >> > - : "iq" (CONST_MASK(nr) & 0xff) >> > + : "iq" ((u8)(CONST_MASK(nr) & 0xff)) >>=20 >> I think a better fix would be to make CONST_MASK() return a u8 value >> rather than have to cast on every use=2E > >Or assign to a local variable - then it doesn't matter how >the value is actually calculated=2E So: > u8 mask =3D CONST_MASK(nr); > asm volatile(LOCK_PREFIX "orb %1,%0" > : CONST_MASK_ADDR(nr, addr) > : "iq" mask > > David > >- >Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, >MK1 1PT, UK >Registration No: 1397386 (Wales) "const u8" please=2E=2E=2E --=20 Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E