From: Kumar Gala <galak@kernel.crashing.org>
To: Roel Kluin <12o3l@tiscali.nl>
Cc: "linuxppc-dev@ozlabs.org list" <linuxppc-dev@ozlabs.org>,
lkml <linux-kernel@vger.kernel.org>,
spi-devel-general@lists.sourceforge.net
Subject: Re: [PATCH] spi_mpc83xx: test below 0 on unsigned irq in mpc83xx_spi_probe()
Date: Wed, 23 Apr 2008 15:39:32 -0500 [thread overview]
Message-ID: <7C711FFF-E1C5-4286-93A8-382055C6760C@kernel.crashing.org> (raw)
In-Reply-To: <480F99D5.7070300@tiscali.nl>
On Apr 23, 2008, at 3:19 PM, Roel Kluin wrote:
> mpc83xx_spi->irq is unsigned, so the test fails
>
> Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
you should copy the linux-spi list on such patches.
- k
>
> ---
> diff --git a/drivers/spi/spi_mpc83xx.c b/drivers/spi/spi_mpc83xx.c
> index be15a62..033fd51 100644
> --- a/drivers/spi/spi_mpc83xx.c
> +++ b/drivers/spi/spi_mpc83xx.c
> @@ -454,12 +454,12 @@ static int __init mpc83xx_spi_probe(struct
> platform_device *dev)
> goto put_master;
> }
>
> - mpc83xx_spi->irq = platform_get_irq(dev, 0);
> -
> - if (mpc83xx_spi->irq < 0) {
> - ret = -ENXIO;
> + ret = platform_get_irq(dev, 0);
> + if (ret < 0)
> goto unmap_io;
> - }
> +
> + mpc83xx_spi->irq = ret;
> + ret = 0;
>
> /* Register for SPI Interrupt */
> ret = request_irq(mpc83xx_spi->irq, mpc83xx_spi_irq,
next prev parent reply other threads:[~2008-04-23 20:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-23 20:19 Roel Kluin
2008-04-23 20:39 ` Kumar Gala [this message]
2008-04-30 22:12 ` [spi-devel-general] " David Brownell
2008-04-23 20:55 ` [PATCH 2/2] xilinx_spi: test below 0 on unsigned irq in xilinx_spi_probe() Roel Kluin
2008-04-24 7:35 ` [PATCH 2/2 v2] " Roel Kluin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7C711FFF-E1C5-4286-93A8-382055C6760C@kernel.crashing.org \
--to=galak@kernel.crashing.org \
--cc=12o3l@tiscali.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®