From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f173.google.com (mail-qt1-f173.google.com [209.85.160.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 986D925B312 for ; Fri, 22 Aug 2025 16:07:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755878826; cv=none; b=NSZXUMZsaV/ptR0NtTOkQF2rgkuuFp6jQbkAM9jVPey1gXcnjXDal2M8JHQwtLPtrjotTwyAbdu0flRISEy6LUG5jm+/HPW2CQDv8tiZS63HK59Ncrrun1IfcggRjZyOSWM9Kc8XV6KqYK2WerG0OSiCZrIC/YdODGnYrXzwxN0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755878826; c=relaxed/simple; bh=PeFWqmKvO1chHjKzpamnENPM1xecjmZuSEwZ1WqrNeU=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=oTZkD0YhXxGfFaVIoN6WzhmUBEVu59N/Vdk1yYYMgmm7d85BgeJmLEegEoHVn4X/bAuQZN7GgLWzVRlhZ0P233N9VEUNmyMrkIs5cEmq9+L9+WyBicMf6UbAy0gfSDswBVkxQyxrYMl//HPcu0SX5Uiqye1CNY5nEukfdOG2z7M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=watter.com; spf=pass smtp.mailfrom=watter.com; dkim=pass (2048-bit key) header.d=watter.com header.i=@watter.com header.b=ZnNCh69a; arc=none smtp.client-ip=209.85.160.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=watter.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=watter.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=watter.com header.i=@watter.com header.b="ZnNCh69a" Received: by mail-qt1-f173.google.com with SMTP id d75a77b69052e-4b1099192b0so37504471cf.0 for ; Fri, 22 Aug 2025 09:07:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=watter.com; s=google; t=1755878823; x=1756483623; darn=vger.kernel.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=v3a0v0yEWcj3RiPcDwFFeqOwhcQzYtQNA5v8wZVyGNw=; b=ZnNCh69aYatPDomewHW3izDxvTaBbOmll+HCCioEBkaP+q8OoqigkBu19KJDsO8pa9 D4DmSAlBX5a06MTjjFc3iWNcwg2louEdBB9YwV/gxXN1IfOLyZhHqrEnamHwHOdOU/Hl zaXim4jO71kDYLCI/4gMc/F4jmEB0D5KNSM6YOJ0t+R5vtrAPLN9/xVJzgNUZXFugMCY /+j5qR6x2OCUGpTWs3Qf+Fw+cACwMTomXD1KjEP0S3fxJ3l9K5tCpNPDZolaDpTSxulv zXuK9RCIItVPnjyoGv6L3PG3O79kghlBAqQdrVpaokCMl/eHiMqN1aGd71uOOnHvENd2 Qbkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755878823; x=1756483623; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=v3a0v0yEWcj3RiPcDwFFeqOwhcQzYtQNA5v8wZVyGNw=; b=sPCUe7BtxdI7thEYj3AIt4arKKEwiVy90Dx7/mD9bj932LnMaKF0cu9B+Ff1wRgamv 7YnlKtSjxPRb+IIrvbSw5KB76aB9GP3Dpp1lA3aoaP12p96hbysSDzuEhk5wbTGrjBrL uKfPtf75JIXsgKLPYFWjE+PWtwoDoNBgWulvdQFZiwYx0W8J+jAYw5T+HFTlz0BlefM+ EPZIBnVhape/TW/iYTQHeRRZrlHHpBatu2LgGJOUY+CgMhzqpQHJWv5csxbnKbagUFor O1Fi9FOhLt6xDwq9YSpBwOfQ+q7YeqhAWQBkPxipBzBuZhHu4VD49T8NI1AtArghcx48 6sKQ== X-Forwarded-Encrypted: i=1; AJvYcCXu/E16/I2b+X4W3W06Y8Go5ErC4+YvvVhCcHMK+KLKmIPQVIF/ZmMpeFQXrUOluRDWGzftIOwYunInbd0=@vger.kernel.org X-Gm-Message-State: AOJu0YxK1vz6aGkVPb7cNkFG/rIzjb777ezObRLfJqc5KJUoBBY3+zkH 95Lup/5hqbVV3EwhyV0SANtqcaZzOf6WgdLpZYRCEe9ZUnC+hPYRRmDRxvpnLHe7Mg== X-Gm-Gg: ASbGncsYZ5y+sloFSK38HWjyPAOglcEWJ5huFodqMZkzu6zUBDIRgmgoiujzwT7zjoP 03AuF3ZDBcEdGQeBYPTwgVM/P4fmlWqnnhdPTO7phLcJ5GIj0g3iIuas8hk40AgFSM6h7Gle/8u ahCpv1iSt3MdKv+VbWn8Q17ft/VY3rJQAbmmGUu/TyZDpfmJOWMr57Snx67fsz+v3BYsap7qua+ nQDpdy7uvzlSaISy64C9p0riOZ5HocpGulgO+kqJs7u282S6zciFp5+UUzKC2hTvkvXnBy/K5J7 EbyEDy0VdTXUuuIIMzuoc0pr8TYmqM/p5BeKdtsqAKrgCdHcoX/1dnz6U8ChyCOH+J2ZX8fnBEW 5MNUycqpB/+9ygxKn6buxazrz9Lh++G3/Ou5YlVMOIQ== X-Google-Smtp-Source: AGHT+IHAD7H5L6yCdeTC6tSubZLEJn8ENm+E+LtaoKzBuMfi/WRcDB8L8WglMrH9i33FpqnhIRJ71A== X-Received: by 2002:a05:622a:4e06:b0:4b2:8ac4:f07c with SMTP id d75a77b69052e-4b2aab8ac98mr53224851cf.78.1755878823153; Fri, 22 Aug 2025 09:07:03 -0700 (PDT) Received: from smtpclient.apple ([70.32.192.89]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4b2b8e514fesm1661981cf.50.2025.08.22.09.07.02 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Aug 2025 09:07:02 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.100.1.1.5\)) Subject: Re: [PATCH v8 4/5] iio: mcp9600: Recognize chip id for mcp9601 From: Ben Collins In-Reply-To: Date: Fri, 22 Aug 2025 12:06:51 -0400 Cc: Jonathan Cameron , David Lechner , =?utf-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Hepp , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: <7C976B5E-781D-472B-B2C8-3AD22550E036@watter.com> References: <20250822-upstream-changes-v8-0-40bb1739e3e2@watter.com> <20250822-upstream-changes-v8-4-40bb1739e3e2@watter.com> To: Andy Shevchenko X-Mailer: Apple Mail (2.3864.100.1.1.5) > On Aug 22, 2025, at 11:57=E2=80=AFAM, Andy Shevchenko = wrote: >=20 > On Fri, Aug 22, 2025 at 4:24=E2=80=AFPM Ben Collins = wrote: >>=20 >> The current driver works with mcp9601, but emits a warning because it >> does not recognize the chip id. >>=20 >> MCP9601 is a superset of MCP9600. The drivers works without changes >> on this chipset. >>=20 >> However, the 9601 chip supports open/closed-circuit detection if = wired >> properly, so we'll need to be able to differentiate between them. >>=20 >> Moved "struct mcp9600_data" up in the file since a later patch will >> need it and chip_info before the declarations. >=20 > ... >=20 >> +struct mcp9600_data { >> + struct i2c_client *client; >> +}; >> + >=20 >> -struct mcp9600_data { >> - struct i2c_client *client; >> -}; >> - >=20 > Seems we discussed this. And my suggestion was to defer the change to > when it will be needed. And my response was that it=E2=80=99s needed in 5/5 where I add the = mcp9600_config() function. That function will need to be before mcp9600_channels[] in the IIR patch series. So either I move mcp9600_data now, or I leave it and put = mcp9600_config() below it, and then in the IIR series I=E2=80=99ll have to move both up. Didn=E2=80=99t seem to make sense to move 30 lines of code later when I = can move 3 lines now. Regards, Ben=