From: Kumar Gala <galak@codeaurora.org>
To: Yaniv Gardi <ygardi@codeaurora.org>
Cc: James.Bottomley@HansenPartnership.com, hch@infradead.org,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-arm-msm@vger.kernel.org, santoshsy@gmail.com,
linux-scsi-owner@vger.kernel.org, subhashj@codeaurora.org,
noag@codeaurora.org, draviv@codeaurora.org,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kishon Vijay Abraham I <kishon@ti.com>,
Vinayak Holikatti <vinholikatti@gmail.com>,
"James E.J. Bottomley" <JBottomley@parallels.com>,
Grant Likely <grant.likely@linaro.org>,
Raviv Shvili <rshvili@codeaurora.org>,
Sujit Reddy Thumma <sthumma@codeaurora.org>,
Christoph Hellwig <hch@lst.de>,
Sahitya Tummala <stummala@codeaurora.org>,
"open list:OPEN FIRMWARE AND..." <devicetree@vger.kernel.org>
Subject: Re: [PATCH v4] scsi: ufs: add support of generic PHY framework in Qualcomm MSM chips
Date: Wed, 17 Sep 2014 15:27:43 -0700 [thread overview]
Message-ID: <7CC13860-9AEB-4A97-9D12-DC0A8E8F27C0@codeaurora.org> (raw)
In-Reply-To: <000001cfd294$18e4e300$4aaea900$@codeaurora.org>
On Sep 17, 2014, at 9:26 AM, Yaniv Gardi <ygardi@codeaurora.org> wrote:
> This change depends on draviv [PATCH v3] series of 16 changes that was
> already uploaded.
> Soon draviv will uploaded again as [PATCH v4] that contain 17 patches, and
> this change will be dependent on this serie,
>
> Thanks,
> Yaniv
>
> -----Original Message-----
> From: Yaniv Gardi [mailto:ygardi@codeaurora.org]
> Sent: Wednesday, September 17, 2014 7:22 PM
> To: James.Bottomley@HansenPartnership.com; hch@infradead.org
> Cc: linux-kernel@vger.kernel.org; linux-scsi@vger.kernel.org;
> linux-arm-msm@vger.kernel.org; santoshsy@gmail.com;
> linux-scsi-owner@vger.kernel.org; subhashj@codeaurora.org;
> ygardi@codeaurora.org; noag@codeaurora.org; draviv@codeaurora.org; Rob
> Herring; Pawel Moll; Mark Rutland; Ian Campbell; Kumar Gala; Kishon Vijay
> Abraham I; Vinayak Holikatti; James E.J. Bottomley; Grant Likely; Raviv
> Shvili; Sujit Reddy Thumma; Christoph Hellwig; Sahitya Tummala; open
> list:OPEN FIRMWARE AND...
> Subject: [PATCH v4] scsi: ufs: add support of generic PHY framework in
> Qualcomm MSM chips
>
> In this change we add support to the generic PHY framework.
> Two UFS phys are implemented:
> qmp-20nm and qmp-28nm.
>
> Also, the files in this change implement the UFS HW (controller & PHY)
> specific behavior in Qualcomm chips.
> Relocation of a few header files is needed in order to expose routines
> and data structures between PHY driver and UFS driver
>
> Signed-off-by: Yaniv Gardi <ygardi@codeaurora.org>
> ---
> .../devicetree/bindings/phy/qcom-ufs-phy.txt | 37 +
> drivers/phy/Makefile | 3 +
> drivers/phy/phy-qcom-ufs-qmp-20nm.c | 259 ++++++
> drivers/phy/phy-qcom-ufs-qmp-20nm.h | 216 +++++
> drivers/phy/phy-qcom-ufs-qmp-28nm.c | 342 ++++++++
> drivers/phy/phy-qcom-ufs-qmp-28nm.h | 738 ++++++++++++++++++
> drivers/phy/phy-qcom-ufs.c | 661 ++++++++++++++++
> drivers/scsi/ufs/Kconfig | 12 +
> drivers/scsi/ufs/Makefile | 1 +
> drivers/scsi/ufs/ufs-qcom.c | 866
> +++++++++++++++++++++
> drivers/scsi/ufs/ufs.h | 491 ------------
> drivers/scsi/ufs/ufshcd-pci.c | 2 +-
> drivers/scsi/ufs/ufshcd-pltfrm.c | 2 +-
> drivers/scsi/ufs/ufshcd.c | 14 +-
> drivers/scsi/ufs/ufshcd.h | 595 --------------
> drivers/scsi/ufs/unipro.h | 207 -----
> include/linux/phy/phy-qcom-ufs.h | 202 +++++
> include/linux/scsi/ufs/ufs-qcom.h | 156 ++++
> include/linux/scsi/ufs/ufs.h | 491 ++++++++++++
> include/linux/scsi/ufs/ufshcd.h | 635 +++++++++++++++
> include/linux/scsi/ufs/unipro.h | 207 +++++
> 21 files changed, 4840 insertions(+), 1297 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/phy/qcom-ufs-phy.txt
> create mode 100644 drivers/phy/phy-qcom-ufs-qmp-20nm.c
> create mode 100644 drivers/phy/phy-qcom-ufs-qmp-20nm.h
> create mode 100644 drivers/phy/phy-qcom-ufs-qmp-28nm.c
> create mode 100644 drivers/phy/phy-qcom-ufs-qmp-28nm.h
> create mode 100644 drivers/phy/phy-qcom-ufs.c
> create mode 100644 drivers/scsi/ufs/ufs-qcom.c
> delete mode 100644 drivers/scsi/ufs/ufs.h
> delete mode 100644 drivers/scsi/ufs/ufshcd.h
> delete mode 100644 drivers/scsi/ufs/unipro.h
> create mode 100644 include/linux/phy/phy-qcom-ufs.h
> create mode 100644 include/linux/scsi/ufs/ufs-qcom.h
> create mode 100644 include/linux/scsi/ufs/ufs.h
> create mode 100644 include/linux/scsi/ufs/ufshcd.h
> create mode 100644 include/linux/scsi/ufs/unipro.h
Can you split this into multiple patches. At least one that just moves the headers around without any other changes. Than another that introduces the PHY code. Will make it far easier to review.
- k
--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
prev parent reply other threads:[~2014-09-17 22:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-17 16:21 Yaniv Gardi
2014-09-17 16:26 ` Yaniv Gardi
2014-09-17 22:27 ` Kumar Gala [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7CC13860-9AEB-4A97-9D12-DC0A8E8F27C0@codeaurora.org \
--to=galak@codeaurora.org \
--cc=JBottomley@parallels.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=devicetree@vger.kernel.org \
--cc=draviv@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kishon@ti.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi-owner@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=noag@codeaurora.org \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=rshvili@codeaurora.org \
--cc=santoshsy@gmail.com \
--cc=sthumma@codeaurora.org \
--cc=stummala@codeaurora.org \
--cc=subhashj@codeaurora.org \
--cc=vinholikatti@gmail.com \
--cc=ygardi@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®