From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753465AbbCJT55 (ORCPT ); Tue, 10 Mar 2015 15:57:57 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:32835 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753402AbbCJT5x convert rfc822-to-8bit (ORCPT ); Tue, 10 Mar 2015 15:57:53 -0400 Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: [PATCH v2 1/3] devicetree: bindings: Document qcom,msm-id and qcom,board-id From: Kumar Gala In-Reply-To: <10886228.vUHyKm1ubP@wuerfel> Date: Tue, 10 Mar 2015 14:57:47 -0500 Cc: Olof Johansson , Kevin Hilman , linux-arm-msm , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "arm@kernel.org" , "devicetree@vger.kernel.org" , =?windows-1252?Q?Heiko_St=FCbner?= Content-Transfer-Encoding: 8BIT Message-Id: <7DA73171-01A5-4158-9A69-015B62D2D7E8@codeaurora.org> References: <1425503602-24916-1-git-send-email-galak@codeaurora.org> <3A588B25-66ED-4BB5-8C8F-D050D8A2F9F3@codeaurora.org> <10886228.vUHyKm1ubP@wuerfel> To: Arnd Bergmann X-Mailer: Apple Mail (2.1878.6) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mar 10, 2015, at 2:52 PM, Arnd Bergmann wrote: > On Tuesday 10 March 2015 13:10:08 Kumar Gala wrote: >>>>>>>>>>> The top level qcom,msm-id and qcom,board-id are utilized by bootloaders >>>>>>>>>>>> on Qualcomm MSM platforms to determine which device tree should be >>>>>>>>>>>> utilized and passed to the kernel. >>>>>>>>>>>> >>>>>>>>>>>> Cc: >>>>>>>>>>>> Signed-off-by: Kumar Gala >>>>>>>>>>> >>>>>>>>>>> Is this the special magic that allows qcom bootloaders to take a kernel >>>>>>>>>>> plus multiple DTBs and figure out which DTB to pass? >>>>>>>>>>> >>>>>>>>>>> Kevin >>>>>>>>>> >>>>>>>>>> yes >>>>>>>>> >>>>>>>>> That's a bummer. >>>>>>>>> >>>>>>>>> Luckily, the solution for upstream is still quite simple: Provide only >>>>>>>>> one devicetree, and it'll be used, right? >>>>>>>> >>>>>>>> We can provide only one, we still need the IDs in the DT. >>>>>>> >>>>>>> How are the DTS provided? Concatenated with the kernel, or in a >>>>>>> wrapped data format? Or in a separate partition from the kernel? >>>>>> >>>>>> Its a wrapped data format that is than concatenated with the kernel if I remember correctly. >>>>> >>>>> Then you should be able to create a tool that can write this concatenated >>>>> format and insert these properties from a table that matches the boot >>>>> loader, right? >>>>> >>>>> Arnd >>>> >>>> Are you suggesting the tool insert the properties in the DT? I’m not sure I understand what the point of doing that would be. >>> >>> To insert platform-local properties that mean nothing outside of the >>> firmware packaging of the device trees, which is the case here? >>> >>> I think the idea of having the installer script inserting them is >>> quite reasonable in this case. >>> >>> >>> -Olof >> >> These values are static, so not sure what the point of having the installer script do that? >> > > It combines two hacks to work around a nonstandard boot loader. > Once the bootloader is fixed, you can stop using that script. > > Arnd I feel as if I’m missing something here. If we just have the properties in the .dts files I don’t need to change anything ever, no script, no worries about working with old or new boot loaders, etc. - k -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project