From: Daniel Almeida <daniel.almeida@collabora.com>
To: "Onur Özkan" <work@onurozkan.dev>
Cc: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
daniel@sedlak.dev, dirk.behme@de.bosch.com, felipe_life@live.com,
tamird@gmail.com, dakr@kernel.org, tmgross@umich.edu,
aliceryhl@google.com, a.hindborg@kernel.org, lossin@kernel.org,
bjorn3_gh@protonmail.com, gary@garyguo.net, boqun.feng@gmail.com,
alex.gaynor@gmail.com, ojeda@kernel.org
Subject: Re: [PATCH v2 1/1] rust: refactor to_result to return the original value
Date: Tue, 9 Sep 2025 17:13:49 -0300 [thread overview]
Message-ID: <7E1CF096-2886-483A-929F-1EEF5E94AD47@collabora.com> (raw)
In-Reply-To: <20250909215330.4a2f050f@nimda.home>
[…]
> If you look at the changes in rust/kernel/error.rs, you will see that
> the `to_result` function has been modified and some of its callers were
> updated because the function signature changed.
>
> The regulator patch I sent earlier is unrelated to this one. They are
> not doing the same thing. That patch aimed to make use of `to_result`
This is the piece of information I was missing, thanks.
> instead of handling errors manually. This patch on the other hand,
> changes how `to_result` itself works and some of its callers need to be
> updated accordingly just like in the other modules included here. The
> reason for changing the `to_result` function is explained in the commit
> description.
>
> -Onur
— Daniel
next prev parent reply other threads:[~2025-09-09 20:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-09 17:00 [PATCH v2 0/1] " Onur Özkan
2025-09-09 17:00 ` [PATCH v2 1/1] " Onur Özkan
2025-09-09 17:17 ` Miguel Ojeda
2025-09-09 17:43 ` Onur Özkan
2025-09-09 18:25 ` Onur
2025-09-09 18:25 ` Daniel Almeida
2025-09-09 18:53 ` Onur Özkan
2025-09-09 20:13 ` Daniel Almeida [this message]
2025-09-09 20:05 ` Miguel Ojeda
2025-09-09 20:12 ` Daniel Almeida
2025-09-09 20:25 ` Miguel Ojeda
2025-09-10 4:50 ` Onur Özkan
2025-09-10 6:26 ` Alice Ryhl
2025-09-10 10:58 ` Onur Özkan
2025-09-10 11:05 ` Alice Ryhl
2025-09-10 12:47 ` Onur Özkan
2025-09-10 12:50 ` Alice Ryhl
2025-09-10 12:55 ` Onur Özkan
2025-09-12 8:41 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7E1CF096-2886-483A-929F-1EEF5E94AD47@collabora.com \
--to=daniel.almeida@collabora.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=daniel@sedlak.dev \
--cc=dirk.behme@de.bosch.com \
--cc=felipe_life@live.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tamird@gmail.com \
--cc=tmgross@umich.edu \
--cc=work@onurozkan.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®