From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFB86C433F5 for ; Wed, 16 Mar 2022 23:47:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350970AbiCPXsZ (ORCPT ); Wed, 16 Mar 2022 19:48:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237308AbiCPXsW (ORCPT ); Wed, 16 Mar 2022 19:48:22 -0400 Received: from aposti.net (aposti.net [89.234.176.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5961060CC; Wed, 16 Mar 2022 16:47:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1647474424; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=j8Ooh+LCxFFoGKBoaKiMAx0jGXjqFdxKO7NQQBvBgWI=; b=ySeFFnByqVzcPFdMJTkKf8CMbUFhsu6DtcQL+g38yEIxB6TLHM719Bpgr5qLXUvqZvSu8n hCb71dWGYeSq2SCcLrkjywWDMvVcggEgysEZKxhz5FAQBwxWAscDKm7xzi9vmIzieiag+w 1fQsCYvwHY9cSdTLW9o84tZTdFRgseQ= Date: Wed, 16 Mar 2022 23:46:55 +0000 From: Paul Cercueil Subject: Re: [PATCH v3] pinctrl: ingenic: Fix regmap on X series SoCs To: Aidan MacDonald Cc: linus.walleij@linaro.org, linux-mips@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Message-Id: <7E3V8R.2BAIBRJ6ON0W1@crapouillou.net> In-Reply-To: <20220316232029.965361-1-aidanmacdonald.0x0@gmail.com> References: <20220316232029.965361-1-aidanmacdonald.0x0@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Aidan, Le mer., mars 16 2022 at 23:20:30 +0000, Aidan MacDonald=20 a =E9crit : > The X series Ingenic SoCs have a shadow GPIO group which is at a=20 > higher > offset than the other groups, and is used for all GPIO configuration. > The regmap did not take this offset into account and set max_register > too low, so the regmap API blocked writes to the shadow group, which > made the pinctrl driver unable to configure any pins. >=20 > Fix this by adding regmap access tables to the chip info. >=20 > Signed-off-by: Aidan MacDonald Since this is a fix, you need to add a Fixes: tag that points to the=20 commit that introduced the bug, and add a Cc: =20 line as well. > --- > v1 -> v2: use regmap_access_table > v2 -> v3: compute max_register instead of putting it in chip_info >=20 > drivers/pinctrl/pinctrl-ingenic.c | 46=20 > ++++++++++++++++++++++++++++++- > 1 file changed, 45 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/pinctrl/pinctrl-ingenic.c=20 > b/drivers/pinctrl/pinctrl-ingenic.c > index 2712f51eb238..fa6becca1788 100644 > --- a/drivers/pinctrl/pinctrl-ingenic.c > +++ b/drivers/pinctrl/pinctrl-ingenic.c > @@ -119,6 +119,8 @@ struct ingenic_chip_info { > unsigned int num_functions; >=20 > const u32 *pull_ups, *pull_downs; > + > + const struct regmap_access_table *access_table; > }; >=20 > struct ingenic_pinctrl { > @@ -2179,6 +2181,17 @@ static const struct function_desc=20 > x1000_functions[] =3D { > { "mac", x1000_mac_groups, ARRAY_SIZE(x1000_mac_groups), }, > }; >=20 > +static const struct regmap_range x1000_access_ranges[] =3D { > + regmap_reg_range(0x000, 0x400 - 4), > + regmap_reg_range(0x700, 0x800 - 4), > +}; > + > +/* shared with X1500 */ > +static const struct regmap_access_table x1000_access_table =3D { > + .yes_ranges =3D x1000_access_ranges, > + .n_yes_ranges =3D ARRAY_SIZE(x1000_access_ranges), > +}; > + > static const struct ingenic_chip_info x1000_chip_info =3D { > .num_chips =3D 4, > .reg_offset =3D 0x100, > @@ -2189,6 +2202,7 @@ static const struct ingenic_chip_info=20 > x1000_chip_info =3D { > .num_functions =3D ARRAY_SIZE(x1000_functions), > .pull_ups =3D x1000_pull_ups, > .pull_downs =3D x1000_pull_downs, > + .access_table =3D &x1000_access_table, > }; >=20 > static int x1500_uart0_data_pins[] =3D { 0x4a, 0x4b, }; > @@ -2300,6 +2314,7 @@ static const struct ingenic_chip_info=20 > x1500_chip_info =3D { > .num_functions =3D ARRAY_SIZE(x1500_functions), > .pull_ups =3D x1000_pull_ups, > .pull_downs =3D x1000_pull_downs, > + .access_table =3D &x1000_access_table, > }; >=20 > static const u32 x1830_pull_ups[4] =3D { > @@ -2506,6 +2521,16 @@ static const struct function_desc=20 > x1830_functions[] =3D { > { "mac", x1830_mac_groups, ARRAY_SIZE(x1830_mac_groups), }, > }; >=20 > +static const struct regmap_range x1830_access_ranges[] =3D { > + regmap_reg_range(0x0000, 0x4000 - 4), > + regmap_reg_range(0x7000, 0x8000 - 4), > +}; > + > +static const struct regmap_access_table x1830_access_table =3D { > + .yes_ranges =3D x1830_access_ranges, > + .n_yes_ranges =3D ARRAY_SIZE(x1830_access_ranges), > +}; > + > static const struct ingenic_chip_info x1830_chip_info =3D { > .num_chips =3D 4, > .reg_offset =3D 0x1000, > @@ -2516,6 +2541,7 @@ static const struct ingenic_chip_info=20 > x1830_chip_info =3D { > .num_functions =3D ARRAY_SIZE(x1830_functions), > .pull_ups =3D x1830_pull_ups, > .pull_downs =3D x1830_pull_downs, > + .access_table =3D &x1830_access_table, > }; >=20 > static const u32 x2000_pull_ups[5] =3D { > @@ -2969,6 +2995,17 @@ static const struct function_desc=20 > x2000_functions[] =3D { > { "otg", x2000_otg_groups, ARRAY_SIZE(x2000_otg_groups), }, > }; >=20 > +static const struct regmap_range x2000_access_ranges[] =3D { > + regmap_reg_range(0x000, 0x500 - 4), > + regmap_reg_range(0x700, 0x800 - 4), > +}; > + > +/* shared with X2100 */ > +static const struct regmap_access_table x2000_access_table =3D { > + .yes_ranges =3D x2000_access_ranges, > + .n_yes_ranges =3D ARRAY_SIZE(x2000_access_ranges), > +}; > + > static const struct ingenic_chip_info x2000_chip_info =3D { > .num_chips =3D 5, > .reg_offset =3D 0x100, > @@ -2979,6 +3016,7 @@ static const struct ingenic_chip_info=20 > x2000_chip_info =3D { > .num_functions =3D ARRAY_SIZE(x2000_functions), > .pull_ups =3D x2000_pull_ups, > .pull_downs =3D x2000_pull_downs, > + .access_table =3D &x2000_access_table, > }; >=20 > static const u32 x2100_pull_ups[5] =3D { > @@ -3189,6 +3227,7 @@ static const struct ingenic_chip_info=20 > x2100_chip_info =3D { > .num_functions =3D ARRAY_SIZE(x2100_functions), > .pull_ups =3D x2100_pull_ups, > .pull_downs =3D x2100_pull_downs, > + .access_table =3D &x2000_access_table, > }; >=20 > static u32 ingenic_gpio_read_reg(struct ingenic_gpio_chip *jzgc, u8=20 > reg) > @@ -4168,7 +4207,12 @@ static int __init ingenic_pinctrl_probe(struct=20 > platform_device *pdev) > return PTR_ERR(base); >=20 > regmap_config =3D ingenic_pinctrl_regmap_config; > - regmap_config.max_register =3D chip_info->num_chips *=20 > chip_info->reg_offset; > + if (chip_info->access_table) { > + regmap_config.rd_table =3D chip_info->access_table; > + regmap_config.wr_table =3D chip_info->access_table; > + } else { > + regmap_config.max_register =3D chip_info->num_chips *=20 > chip_info->reg_offset - 4; You do actually change how regmap_config.max_register is computed here,=20 without explaining anywhere why it is changed. I'm not saying that it's=20 wrong, but you should explain in the commit message why this is changed. Cheers, -Paul > + } >=20 > jzpc->map =3D devm_regmap_init_mmio(dev, base, ®map_config); > if (IS_ERR(jzpc->map)) { > -- > 2.34.1 >=20