From: Julien Chauveau <chauveau.julien@gmail.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: "Geert Uytterhoeven" <geert@linux-m68k.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
linux-rockchip <linux-rockchip@lists.infradead.org>,
LAKML <linux-arm-kernel@lists.infradead.org>,
"Heiko Stübner" <heiko@sntech.de>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Pawel Moll" <pawel.moll@arm.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"Kumar Gala" <galak@codeaurora.org>,
devicetree <devicetree@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RESEND] Documentation: devicetree: Clean up gpio-keys example
Date: Fri, 11 Mar 2016 00:08:49 +0100 [thread overview]
Message-ID: <7E647096-6B3B-4015-BB0F-7B4087206180@gmail.com> (raw)
In-Reply-To: <56DEA67E.8090704@suse.de>
> Le 8 mars 2016 à 11:16, Andreas Färber <afaerber@suse.de> a écrit :
>
> Am 08.03.2016 um 10:41 schrieb Julien Chauveau:
>> Le 8 mars 2016 à 09:54, Geert Uytterhoeven <geert@linux-m68k.org> a écrit :
>>> On Mon, Mar 7, 2016 at 7:24 PM, Andreas Färber <afaerber@suse.de> wrote:
>>>> Drop #address-cells and #size-cells, which are not required by the
>>>> gpio-keys binding documentation, as button sub-nodes are not devices.
>>>>
>>>> Reported-by: Julien Chauveau <chauveau.julien@gmail.com>
>>>> Signed-off-by: Andreas Färber <afaerber@suse.de>
>>>> ---
>>>> Documentation/devicetree/bindings/input/gpio-keys.txt | 2 --
>>>> 1 file changed, 2 deletions(-)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/input/gpio-keys.txt b/Documentation/devicetree/bindings/input/gpio-keys.txt
>>>> index 21641236c095..1552a11f6786 100644
>>>> --- a/Documentation/devicetree/bindings/input/gpio-keys.txt
>>>> +++ b/Documentation/devicetree/bindings/input/gpio-keys.txt
>>>> @@ -34,8 +34,6 @@ Example nodes:
>>>>
>>>> gpio_keys {
>>>> compatible = "gpio-keys";
>>>> - #address-cells = <1>;
>>>> - #size-cells = <0>;
>>>> autorepeat;
>>>> button@21 {
>>>
>>> FYI, with "[PATCH] scripts/dtc: Update to upstream version 53bf130b1cdd":
>>> (http://www.spinics.net/lists/devicetree/msg117206.html) applied:
>>>
>>> Warning (unit_address_vs_reg): Node /keyboard/button@21 has a unit
>>> name, but no reg property
>>>
>>
>> Hi Andreas,
>> This means you can also drop the unit-address (the @21 part) for the button.
>> What about using a more relevant name like "key_up" instead of "button"?
>
> Or in my case power-key or power-button. Or would just power suffice?
For the example nodes of the documentation, according to the labels you’ll probably want to use "up" and "down" (or "key-up" and "key-down", or "up-key" and "down-key").
For the Geekbox, I think "power" is meaningful enough.
>
> The Landingship baseboard does have four more buttons not yet enabled,
> so I do need some way to distinguish nodes.
The labels on the board are key1, key2, key3 and key4. Maybe you can use that?
next prev parent reply other threads:[~2016-03-10 23:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-07 18:24 Andreas Färber
2016-03-07 18:34 ` Javier Martinez Canillas
2016-03-07 19:25 ` Andreas Färber
2016-03-08 8:54 ` Geert Uytterhoeven
2016-03-08 9:41 ` Julien Chauveau
2016-03-08 10:16 ` Andreas Färber
2016-03-10 23:08 ` Julien Chauveau [this message]
2016-03-08 10:09 ` Andreas Färber
2016-03-10 23:08 ` Julien Chauveau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7E647096-6B3B-4015-BB0F-7B4087206180@gmail.com \
--to=chauveau.julien@gmail.com \
--cc=afaerber@suse.de \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=galak@codeaurora.org \
--cc=geert@linux-m68k.org \
--cc=heiko@sntech.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®