From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A879027735; Tue, 4 Jun 2024 05:43:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717479811; cv=none; b=Nuy2MTWurQt3ELtJs0Lg8uwdBQOG7INQ6VdOoezoPzGm4xGLu3lBDMmT7E+A76OXvktx14sXNysbGYD/7OR4ctup9hsV2j94Lu2aaWbJsazfiryGsgkYuKQa+3Y77F8uWidmy3VNwQW+VM11w298igh7pOecY1/rk1RCcllWavc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717479811; c=relaxed/simple; bh=K4RIn52C4629tpAJrB1DNztACdKMcNhUOgQZtSagcuc=; h=Date:From:To:CC:Subject:In-Reply-To:References:Message-ID: MIME-Version:Content-Type; b=ELftq1/jIB5exWgAUPyJqTZk/SY0ITjIagTcQzpY4KSqXuhK0iyKC745vV9HP/O7VsD5u0bXvYr0uZbCjhgsH1kUynkVZ4O61A188AblHjXuuf+w375yxFDGeQAOE/WjprPaL88uM5LfTaj/PHIa0nU5TZulttTyGmNW6SNoppQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XCrPu5sT; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XCrPu5sT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 82BB1C2BBFC; Tue, 4 Jun 2024 05:43:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717479810; bh=K4RIn52C4629tpAJrB1DNztACdKMcNhUOgQZtSagcuc=; h=Date:From:To:CC:Subject:In-Reply-To:References:From; b=XCrPu5sTVtMkHlbQlOUn29wOkTwRKGedBoQliD2UelJ/rWRclj1alcNnY0nvvEIxP /fVdH895VpN3FEAunruYC9TkdrkVG6UYGlYSLS/7nI15Kqysm5ZNhv01HnwhOpqcv4 Xzx5QGQn87oRpbMmfCR08dHrVErqE4R0EYbe1LiU7i4fTL0O1HnnwTid+ZtR6p6LYc beRAQZbIvT1nw+ko56xJquvpDzww9otbMoHsq0pVnYrK/ICUDPuc5KsrOUsrmoijFK M+ah0IlnrUlAWML4S7GPADlCoH3B8OxK1o2QTHTmlJhKnyaopG1Ve0grsYhqYIpj6N TJoS89qMZ5S6A== Date: Mon, 03 Jun 2024 22:43:31 -0700 From: Kees Cook To: Christoph Hellwig , Terry Tritton CC: hch@lst.de, "ttritton@google.com" , edliaw@google.com, keescook@chromium.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Jens Axboe Subject: Re: Change in splice() behaviour after 5.10? User-Agent: K-9 Mail for Android In-Reply-To: <20240604045030.GA29276@lst.de> References: <20240604045030.GA29276@lst.de> Message-ID: <7F3B484F-9555-486A-B19A-5A8EB6442988@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On June 3, 2024 9:50:30 PM PDT, Christoph Hellwig wrote: >On Mon, Jun 03, 2024 at 10:59:15AM +0100, Terry Tritton wrote: >> Hi, >> We've found a change in behaviour while testing the splice07 LTP test= =2E >> In versions before 5=2E10 the test will hang on certain combinations bu= t after >> 5=2E10 the splice call will return=2E >> I bisected the change to the following commit: >> 36e2c7421f02a22f71c9283e55fdb672a9eb58e7 >> fs: don't allow splice read/write without explicit ops >>=20 >> There has been some discussion on the LTP github page already: >> https://github=2Ecom/linux-test-project/ltp/issues/1156 > >In that case the return probably is an error because epoll doesn't >support read_iter/write_iter and thus completely expected=2E > >If the underlying bug hasn't been fix in the mean time that probably >means it will be back if Jens' conversion of all misc file operations >to the iter based ones every gets merged=2E > >If you are interested more in this please discuss it on the relevant >mailing lists instead of in private mail=2E Eh? LKML is in CC=2E=2E=2E I've added fsdevel and Jens now too, though=2E=20 -Kees --=20 Kees Cook