From: Hamza Mahfooz <someguy@effective-light.com>
To: Benjamin LaHaise <bcrl@kvack.org>
Cc: linux-kernel@vger.kernel.org,
kernel test robot <yujie.liu@intel.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-aio@kvack.org
Subject: Re: [PATCH v2] aio: convert active_reqs into a hashtable
Date: Thu, 23 Sep 2021 09:00:43 -0400 [thread overview]
Message-ID: <7H1WZQ.H8D3XK8HUSNQ3@effective-light.com> (raw)
In-Reply-To: <20210919145645.GE16005@kvack.org>
On Sun, Sep 19 2021 at 10:56:45 AM -0400, Benjamin LaHaise
<bcrl@kvack.org> wrote:
> You're doing this wrong. If you want faster cancellations, stash an
> index
> into iocb->aio_key to index into an array with all requests rather
> than
> using a hash table.
Would that not mean that, we would have to keep track of the indices of
the
array that are not being held by an `aio_kiocb`?
next prev parent reply other threads:[~2021-09-23 13:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-19 14:41 Hamza Mahfooz
2021-09-19 14:56 ` Benjamin LaHaise
2021-09-23 13:00 ` Hamza Mahfooz [this message]
2021-09-23 16:37 ` Benjamin LaHaise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7H1WZQ.H8D3XK8HUSNQ3@effective-light.com \
--to=someguy@effective-light.com \
--cc=bcrl@kvack.org \
--cc=linux-aio@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=yujie.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome