From: Paul Cercueil <paul@crapouillou.net>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Randy Dunlap <rdunlap@infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Wei WANG <wei_wang@realsil.com.cn>,
Kai-Heng Feng <kai.heng.feng@canonical.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH -next] misc: rtsx: fix build for CONFIG_PM not set
Date: Sun, 27 Feb 2022 17:56:31 +0000 [thread overview]
Message-ID: <7U5Z7R.RNKITPUWCPX32@crapouillou.net> (raw)
In-Reply-To: <CAK8P3a3=5uud3jd7N3FEAnaLapX-0OYaiscBFNEQm2hzkTmj7g@mail.gmail.com>
Le dim., févr. 27 2022 at 18:51:38 +0100, Arnd Bergmann
<arnd@arndb.de> a écrit :
> On Sun, Feb 27, 2022 at 6:46 PM Paul Cercueil <paul@crapouillou.net>
> wrote:
>> Le dim., févr. 27 2022 at 18:30:16 +0100, Arnd Bergmann
>>
>> There could be a DEFINE_DEV_PM_OPS(), but I don't think that's
>> really
>> needed - you can very well declare your struct dev_pm_ops without
>> using
>> one of these macros. Just make sure to use the SYSTEM_SLEEP_PM_OPS /
>> RUNTIME_PM_OPS macros for the callbacks and pm_ptr() for the
>> device.pm
>> pointer.
>
> Ah, of course, so it comes down to
> s/SET_SYSTEM_SLEEP_PM_OPS/SYSTEM_SLEEP_PM_OPS/ while
> removing all the #ifdef an __maybe_unused annotations. The pm_ptr()
> in driver.pm makes this slightly more optimized AFAICT, but has no
> effect on behavior, right?
The use of SYSTEM_SLEEP_PM_OPS makes sure that the callbacks are
dropped if the dev_pm_ops is dead code, and the pm_ptr() must be used
for the compiler to know that the dev_pm_ops is dead code.
-Paul
next prev parent reply other threads:[~2022-02-27 17:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-26 22:24 Randy Dunlap
2022-02-27 12:04 ` Arnd Bergmann
2022-02-27 16:57 ` Randy Dunlap
2022-02-27 17:30 ` Arnd Bergmann
2022-02-27 17:46 ` Paul Cercueil
2022-02-27 17:51 ` Arnd Bergmann
2022-02-27 17:56 ` Paul Cercueil [this message]
2022-03-06 15:12 ` Jonathan Cameron
2022-03-06 15:29 ` Paul Cercueil
2022-03-06 17:57 ` Jonathan Cameron
2022-03-06 16:24 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7U5Z7R.RNKITPUWCPX32@crapouillou.net \
--to=paul@crapouillou.net \
--cc=Jonathan.Cameron@huawei.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rdunlap@infradead.org \
--cc=wei_wang@realsil.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®