Re: [PATCH 1/2] dt-bindings: mfd: Add binding for synology,microp devices

[Krzysztof Kozlowski <krzk@kernel.org>]

On 07/03/2026 15:43, Markus Probst wrote:
>>> +
>>> +examples:
>>> +  - |
>>> +    #include <dt-bindings/leds/common.h>
>>> +
>>> +    uart {
>>
>> Drop, unuesed
> The device uses the serial device bus. Thus the device node needs to be
> inside a uart device node. The uart node represents a serial device
> port in that example.

Still not used.

> 
> This is also done the same way in
> - Documentation/devicetree/bindings/mfd/qnap,ts433-mcu.yaml
> - Documentation/devicetree/bindings/net/nfc/marvell,nci.yaml
> - Documentation/devicetree/bindings/net/bluetooth/brcm,bluetooth.yaml

Plenty of poor examples...


> 
>>
>>> +      microp {
>>
>> Node names should be generic. See also an explanation and list of
>> examples (not exhaustive) in DT specification:
>> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
>> If you cannot find a name matching your device, please check in kernel
>> sources for similar cases or you can grow the spec (via pull request to
>> DT spec repo).
> "mcu" seems the most fitting, altough it is not part of the list.
> It it used here though:
> - Documentation/devicetree/bindings/mfd/qnap,ts433-mcu.yaml

Depending what this is. MCU is generic purpose unit where you load your
different FW for different purposes and you have here specific - to
handle certain aspects of this entire machine. This looks like EC, so
should be called embedded-controller and placed in that directory.


Best regards,
Krzysztof