From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E5AC3A6B6A for ; Mon, 12 Oct 2026 09:36:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791797787; cv=none; b=Iea0KqMEHRmsPihv3GgHkPRWoR7U9CEJVFeb42YsQq4eE4RO3p2mAHSvyissYb2sCcbGBM9gdYik89Q/UYLV6nR0tTizLdPPbVMt7029ipUkjNTM69tRZDynhKktT9rYKG0oSs3n8BsBEVjXSr5Ij33IJFJuDFl4wDeJ9UikOnA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791797787; c=relaxed/simple; bh=LASZqrLY1ba6bJ9r9c5Rs/iTZdNGREMx91rXLmcgaGU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Mxr3hppvhQvtdg62zLy871MIj72R/C0eAQXUDZeWI9ZBP750GJLGWYb9uvUz//eOqbsHUF1ZCWIBK10L3drR41XaJZwuH6/UL74mK7SXmC0wsWU2eVlbyNvbE3wAfGW3gIKnSRZs66K30bRLutZ1pxqQA2QmPrSKMX5ZLknSOjE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IGPCwvt1; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=aMbSNjBZ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IGPCwvt1"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="aMbSNjBZ" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69C8LJHY1754980 for ; Mon, 12 Oct 2026 09:36:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= aNfbkWr5wnS5VB6dUyT2oeWRhJlFNcm7TZmPyZKuY4Y=; b=IGPCwvt13Lzm4gbx P9aWkNvONHsOjePWpvoUfgoEmW8Cea64bcyFtQImhd+LO0XgzcIrYOuiLwyxgqRR YDsTqNEjmaNo4jqckklWnxyWty1Gl+Ol+oWq/QhM7PwFP9sHLfJVtJf8h+fSS6+V p78yL+Y4OAnDQIjKzIE/CUkf+YJQilziTnQpytlBEKQbpZ9sApkTATS1wDDAWpIo Gevloz8yVOEyD139YrxrwgnBxizta3qz7HOXXRMvhRv+z3q7mR3ugIRAaxsYAYgp LJsemhBYvYVZYHVDqrBzRnU55YxeopSv7Yq02Gmqul1ngXonhzQYTeiL+NuHbL2a LKzDgA== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4h8j71251c-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 12 Oct 2026 09:36:24 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-3a4a0017549so2646749a91.3 for ; Mon, 12 Oct 2026 02:36:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1791797783; x=1792402583; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=aNfbkWr5wnS5VB6dUyT2oeWRhJlFNcm7TZmPyZKuY4Y=; b=aMbSNjBZyK+dWR0h248/zaHUDKlpo24+UIWgaI7J6UgyD4OvAIgQLHt0PF1hI5vAyr M10cb3sSmpGex2c4Nh/SJhAgKY2bok8QL3cWlM/p9VVWOuV+iPQO6VEXu2o5m3vEiphB HY4H0MgqgXy3/nQQq/n++WSM+ArlbesGC7OmJcACm2iPrNx+roIjeyVebuutzDXxRIiE A7J3wOIaaCBj0yjSeJO4QDCoIZL2LugUkhVJlsPrXUKQ8gkcHHutcfKbp9+NmvZ0ACx9 D467/YkVloHm3deME3b9JiGcWH3kTHWZI/nsr7wcArbo7I7bS+e7QFZAnIvrz56rPRMp QtRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791797783; x=1792402583; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=aNfbkWr5wnS5VB6dUyT2oeWRhJlFNcm7TZmPyZKuY4Y=; b=pWlafYOFUaLRA2Stu9MA9kjsSZcX43y6DtoSkqk/Yh5fjjPl9pbgqUuwI0U7QWcM4D ePuqv2cyZcHT7GvYkh0oqamXg0Mpy0kGhR0jDyju/BAqgdodjSpMGakqn8gMenL+73YX R07wyVT9xlSYLTMicziYCaSs5F/FLTZ/yrJb+tIX7NvLBif6OvNcW3ReMKDoJCxHBvTY dGzdeCp7hhnVzOipuYMQjrrEDBil9REqhxYGADjWxvMryebc3HewCGIml0XmuMLLkRjP wKd+3bX1dtphmXpr+PZxqsgQCBC+hkrzOylah6nE8iyfdFILexHRIDbtT1wepwsTcqrI 0EGQ== X-Forwarded-Encrypted: i=1; AKwUvBz8gz34c8yRjXXULn0wkPlPLTRT9ivlEA0JvOOIdXEfbUKoRBr8EeR8eI4sKCjKfal7urd+GjlS7IDmM24=@vger.kernel.org X-Gm-Message-State: AFq9FYKE32sflxhgO3vVrOCwF/wePVeQiAIJoMkq5Tbe9ouGXUmgY3YP tDlnDr2w1+1NEWhy+WqNdwUythIS8n0gKEm56ceCfSRMMIfJ9IOWFm2rmZhQTDWMXe1d5z6qLbM A4HNHuAqOyCciZoe2vVfiUyJ8BFY+2RBgE/JfmQ3VFuEdJRXIENSZIM7ie55Yj+xEi7Q= X-Gm-Gg: AYBFou14JLRUwujUG8WFWqLGOjT5UjHIPlXAA4/z61Ncr8DCa5OOrQLGa3zutA5EKbD E2ogTkmFs2SF0UnRKknQTyJOlVSH0pgiGm+ZtQEtC3wc9wp+C9S8SOea6Dr7TBoalafh4/SPHhS z9Dff72Pke7+XmyazxqkinqavqKh9E4nIbmfVsR1xmFwhG1Q/JjVCSyeRJ03nP2yPjAhjdFIZL4 BBluSROJd51nQrnsH7h15pMoVaXwVmtnnulJQFkYpgcRF5nB7ZQs3GwByvAKLmqaesVq1z38yUe C5VD/ko+trgif+MUqMM2H7OKjtQz7cQOwHPaDkNxTS1xIY1sIbU09G/gOUk14npU/qDnwYRq853 ZClUd+Fc8yNtuid4jhD9j3buNVleIjg9RJJxkRT7QiFp9Lp7/aGb/3/Z8B5p7F6qe9Cr2gWuYSq M4VJFpWEZTGMQ= X-Received: by 2002:a17:90b:4d85:b0:3a4:c946:9f4e with SMTP id 98e67ed59e1d1-3ab3acdc386mr6665537a91.58.1791797783204; Mon, 12 Oct 2026 02:36:23 -0700 (PDT) X-Received: by 2002:a17:90b:4d85:b0:3a4:c946:9f4e with SMTP id 98e67ed59e1d1-3ab3acdc386mr6665518a91.58.1791797782625; Mon, 12 Oct 2026 02:36:22 -0700 (PDT) Received: from [10.79.117.80] (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3ab8a393666sm10999279a91.15.2026.10.12.02.36.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Oct 2026 02:36:21 -0700 (PDT) Message-ID: <7a091ebe-86d7-4edb-9fa3-9026d2c44176@oss.qualcomm.com> Date: Mon, 12 Oct 2026 15:06:16 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] dt-bindings: remoteproc: qcom: Add Glymur OOBMSS PAS binding To: Krzysztof Kozlowski Cc: Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sibi Sankar References: <20261009-oob-support-glymur-v1-0-96cc8ffcced3@oss.qualcomm.com> <20261009-oob-support-glymur-v1-1-96cc8ffcced3@oss.qualcomm.com> <20261012-impossible-illustrious-dog-702afc@quoll> Content-Language: en-US From: Anvesh Jain P In-Reply-To: <20261012-impossible-illustrious-dog-702afc@quoll> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYxMDEyMDAzOCBTYWx0ZWRfXz6qdNAAdHMz/ i4cNzvV/z2yEfjJAofNQjnN0TJtaKK7F4xE2fnTMRjCKgPTRH0ncD94eIpaEzmp3Esdde/DQP3M jr1VBubFpRS1sFDaRtqB4XkQFZ4MgTo= X-Proofpoint-GUID: kHpPrDGBZw6uEmqcysNAOaYVXtcu-prb X-Proofpoint-ORIG-GUID: kHpPrDGBZw6uEmqcysNAOaYVXtcu-prb X-Authority-Analysis: v=2.4 cv=ePGGH3p1 c=1 sm=1 tr=0 ts=6accaa18 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=P-IC7800AAAA:8 a=gEfo2CItAAAA:8 a=EUspDBNiAAAA:8 a=UONzWho2_RmusEta7RoA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 a=d3PnA9EDa4IxuAV0gXij:22 a=sptkURWiP4Gy88Gu7hUp:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDEyMDAzOCBTYWx0ZWRfX4kXnH2qzgttq SqPfR4prI7ovk8d76TCLq0LdtjWvWQa+tjM6as59kze6VFpZ/dDlh/HYzE0GaBxTC/af6V8jIN7 +y/MQSgGKa6WwsSoEtppKnwr1L7aUknhhucGGsoQ/wQL5SU7YqsRcjPOd0x4QY9sqolIMXDCbqh a57Avmgy0bQyO9/7HwhN7iliDQwW1BCfFt1QTi4XvUcIFw0eBwoYZ+uxC2GQf/0HOXhgppHC2ly OOwsYjhG1q/DgbxmYN+qz1DTi1Tx64eGG4EQ1xTaElXIqwgXR20SlEQDhEFX8jvpza0gblY/AhN UCRNmKHoSKo0KRzf37xhGEFHg2sdSSGuwirWUmtrWj68F/OFH5fr/i3Q+bN9TVcJ0C2ZjfUmtSQ o1XyzgxMIUPR0yyWKy+E3wt4hHWbVRd1R+1VK+PL4nTh4IXN0lCoUuu9GzFgQsvmj0Ml7QdlkPg lBwceHFsfk7ghnJfhJg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-12_03,2026-10-09_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 impostorscore=0 malwarescore=0 adultscore=0 bulkscore=0 phishscore=0 priorityscore=1501 suspectscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610080000 definitions=main-2610120038 On 10/12/2026 2:25 PM, Krzysztof Kozlowski wrote: > On Fri, Oct 09, 2026 at 12:47:39PM +0530, Anvesh Jain P wrote: >> Document the Glymur OOBMSS PAS node with its secure GLink edge, >> shared-memory signaling, firmware carveouts, and power resources. >> > > A nit, subject: drop second/last, redundant "binding". The > "dt-bindings" prefix is already stating that these are bindings. > See also: > https://elixir.bootlin.com/linux/v7.1-rc7/source/Documentation/devicetree/bindings/submitting-patches.rst#L23 > Hi Krzysztof, Thanks for reviewing this series. I’ll drop the redundant “binding” from the subject in the next revision. >> Signed-off-by: Anvesh Jain P >> --- >> .../bindings/remoteproc/qcom,glymur-oob-pas.yaml | 156 +++++++++++++++++++++ >> 1 file changed, 156 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,glymur-oob-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,glymur-oob-pas.yaml >> new file mode 100644 >> index 000000000000..bd4f397da40f >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,glymur-oob-pas.yaml >> @@ -0,0 +1,156 @@ >> +# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/remoteproc/qcom,glymur-oob-pas.yaml# > > Filename must match the compatible. > Ack, will rename binding file. >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm Glymur Out-of-Band Management Subsystem (OOBMSS) PAS >> + >> +maintainers: >> + - Anvesh Jain P >> + >> +description: | >> + Qualcomm Glymur Out-of-Band Management Subsystem (OOBMSS) contains two >> + processors running Zephyr, managed together as one remoteproc instance. >> + The Out-of-Band Trusted Execution Environment (OOB-TEE) is the primary >> + processor. The OOB-Non-Secure processor is an auxiliary processor that >> + depends on the primary processor and cannot function independently. >> + >> + The primary processor runs the primary image, while the auxiliary >> + processor runs the secondary image. Each processor has its own DTB. >> + The two images and their DTBs have separate PAS identifiers for >> + authentication and dedicated reserved-memory carveouts. >> + >> + OOBMSS is booted by earlier-stage firmware and uses an XO clock and the >> + CX and MX power domains. Shared Memory Point-to-Point (SMP2P) provides >> + boot, shutdown, handover and ping/pong signaling, as well as fatal error >> + notifications. The subsystem exposes a secure GLink edge to the host, >> + with doorbell interrupts provided by the Inter-Processor Communication >> + Controller (IPCC). >> + >> +properties: >> + compatible: >> + enum: >> + - qcom,glymur-oobmss-pas >> + >> + reg: >> + maxItems: 1 >> + >> + interrupts: >> + items: >> + - description: Watchdog interrupt >> + - description: Fatal interrupt >> + - description: Ready interrupt >> + - description: Handover interrupt >> + - description: Stop acknowledge interrupt >> + - description: Pong interrupt >> + >> + interrupt-names: >> + items: >> + - const: wdog >> + - const: fatal >> + - const: ready >> + - const: handover >> + - const: stop-ack >> + - const: pong >> + >> + clocks: >> + items: >> + - description: XO clock >> + >> + clock-names: >> + items: >> + - const: xo >> + >> + power-domains: >> + items: >> + - description: CX power domain >> + - description: MX power domain >> + >> + power-domain-names: >> + items: >> + - const: cx >> + - const: mx >> + >> + memory-region: >> + items: >> + - description: Secure firmware carveout >> + - description: Secure device tree carveout >> + - description: Non-secure firmware carveout >> + - description: Non-secure device tree carveout >> + >> + firmware-name: >> + items: >> + - description: Secure firmware >> + - description: Secure device tree firmware >> + - description: Non-secure firmware >> + - description: Non-secure device tree firmware >> + >> + qcom,smem-states: >> + minItems: 2 >> + description: States used by the AP to signal OOBMSS >> + >> + qcom,smem-state-names: >> + minItems: 2 >> + description: The names of the state bits used for SMP2P output >> + >> +required: >> + - compatible >> + - reg >> + - power-domains >> + - power-domain-names >> + - memory-region > > firmware-name as well, I guess? > > I think firmware-name should remain optional. The driver provides defaults when loading images, and attach-only operation does not request firmware. >> + >> +allOf: >> + - $ref: /schemas/remoteproc/qcom,pas-common.yaml# >> + >> +unevaluatedProperties: false >> + >> +examples: >> + - | >> + #include >> + #include >> + #include >> + #include >> + #include >> + #define IPCC_MPROC_OOB_S 56 >> + #define IPCC_MPROC_OOB 55 > > Drop these two > noted, will remove these definition. >> + >> + remoteproc@1f000000 { >> + compatible = "qcom,glymur-oobmss-pas"; >> + reg = <0x1f000000 0x30000>; >> + >> + interrupts-extended = <&intc GIC_SPI 86 IRQ_TYPE_EDGE_RISING>, >> + <&smp2p_oobmss_in 0 IRQ_TYPE_EDGE_RISING>, >> + <&smp2p_oobmss_in 1 IRQ_TYPE_EDGE_RISING>, >> + <&smp2p_oobmss_in 2 IRQ_TYPE_EDGE_RISING>, >> + <&smp2p_oobmss_in 3 IRQ_TYPE_EDGE_RISING>, >> + <&smp2p_oobmss_in 9 IRQ_TYPE_EDGE_RISING>; >> + interrupt-names = "wdog", "fatal", "ready", "handover", "stop-ack", "pong"; >> + >> + clocks = <&rpmhcc RPMH_CXO_CLK>; >> + clock-names = "xo"; >> + power-domains = <&rpmhpd RPMHPD_CX>, >> + <&rpmhpd RPMHPD_MX>; >> + power-domain-names = "cx", "mx"; >> + >> + memory-region = <&oob_secure_mem>, <&oobdtbqc_mem>, >> + <&oob_nonsecure_mem>, <&oobdtboem_mem>; >> + firmware-name = "qcom/glymur/oobmss_tee.mbn", >> + "qcom/glymur/oobmss_qc_dtb.mbn", >> + "qcom/glymur/oobmss_ns.mbn", >> + "qcom/glymur/oobmss_oem_dtb.mbn"; >> + qcom,smem-states = <&smp2p_oobmss_out 1>, >> + <&smp2p_oobmss_out 8>; >> + qcom,smem-state-names = "stop", "ping"; >> + >> + glink-edge { >> + interrupts-extended = <&ipcc IPCC_MPROC_OOB_S > > Just use numbers here > Ack. > Best regards, > Krzysztof -- Best Regards, Anvesh