From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11A5B3624D4 for ; Fri, 31 Jul 2026 14:20:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785507657; cv=none; b=RUicAHSbrbZ8IV1doRbGwK1/Y8GFZBNaVWTPCiw4eLirZEr7c+d6pji8P+/2TeGyWW9mCdus0imSQX15EIefyuA2P/hp2MsGBkvm3NgAjwm+SnenZPDZw683AhUoS6SxeVwYlnrnpgdvqvcG3fdmBSMYhZbv+/3+sWYdqQyI5xU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785507657; c=relaxed/simple; bh=QQbrQC64DOKFrs81hP2K6iVbP4JhcL9Ejso6A8dmgtg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=te/wSR4Iwj84G3gNrrnTZ0fjnPnHOpphFiI1O5oUxV0ySfm7+5T0WPKfvxi+pip3ndjZu266Awctx0zFr+CL+OhDd+hNKfcMAUofm7bS9Sz3xtiPBkDY0F/OoV2cuJKCURUNL0tf9uTJxOCEwa629kkzKnmU/FR7EtVuZ7BLu1U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=gRcolZea; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=iaYBA2X7; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="gRcolZea"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="iaYBA2X7" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66VBejKj892136 for ; Fri, 31 Jul 2026 14:20:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= FjpPkOD7u5iityBLQ910RqkrcCltlUnYQsWx6dR7ODA=; b=gRcolZeaIYazIXsq TCw97cGNBVdYWyJbPFliK0KBnPmUt2eILaOnkA1CadKuCGqtMBD+GboVYzm/15ke dTglQeRB88EgdudWx9bwwnXFJg/g6zx/TUcFx9177KhVBd4AtrV+Rj0mBaDQ9piM ugJj2zpzhame7/0u01kT2dw9gkgDt57BhltwUBkHO3qmEQtL5GmQ8SE+ey9KmxyJ kjGBL7PxZVMBoSv9XDtcybLXfj1tT45UiXy/vvWN9AFjGjxXXV/zwlqUB73Eq8fR YV0j5uegJiWLLp8mrLjnkHzBNlp7nKmsk3UKrMIXjp6ggsjYtcmDL2Pkl+i7ZQpI 4+jvkA== Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fru1x8nhr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 31 Jul 2026 14:20:55 +0000 (GMT) Received: by mail-vs1-f71.google.com with SMTP id ada2fe7eead31-73761f92dd1so24474137.1 for ; Fri, 31 Jul 2026 07:20:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785507654; x=1786112454; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=FjpPkOD7u5iityBLQ910RqkrcCltlUnYQsWx6dR7ODA=; b=iaYBA2X7Z9mX2fbIQpBttWq/y/xGUKRJpY2Gr3Imy0oaqTk0ak6VBKd7LwpmLCb2lc Z7y4lqXmb/59CVWyNDv78DZZQAxjzdalGTlxl3XPIzjSa4/Q0nb5Na9SksyRMKsA9h2o FDcTf/JZ42aoDGJkEJLlnWSEatTZ1DlvlDdpJvVNV2mwVKXPPkbl8zK/hGZpUZSyv8Yj bD70SiJbCGegz2HhrYblwuFAKyy0WZxRJE2OBW9uVZZHbCGxJLF2dgEkfFoGlV9E9IbB Bo1FR7ou6vPlwxGtmeR5qTuZI2p6Dt7COUS9OyEtNygzuXiHQ2w70rNAbDwMyfsZBmPm joDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785507654; x=1786112454; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=FjpPkOD7u5iityBLQ910RqkrcCltlUnYQsWx6dR7ODA=; b=doLBYb8Kd+O32qLA99MNVkktS8idc6b7n38Uo3Yh47rTk8Fv34YCIY5T7zdiNQCR+2 0wVL6o7IptPYqI+WmKR74frYRVDlOtZGWTf82s8cnvAu6MkP5fcUm+400KU+fijjRXn3 ln4ssEs7PC3xTbXFqBdALfzKKYEqnhdZfEzJR8KvPvo5quxPCiJ/zDKT/fFuC0czstdI +w6J+emab3ky1Ssswj+ydSTXDm34bD4wyJckMsu3eN0YJk89nW38Ry72ZPrLGtGvpLrV 4sHjDY+Bv4zcrGeA/651evBd+xC6wTmAneUjWYNblSW61xS6L1fdEfi8cRfYB16XN0Bw 2EAw== X-Forwarded-Encrypted: i=1; AHgh+RovYl/VzAOepkuMMBrIwJb4L+BbLQZKG9hRObuW+z8wnrte8XgUOm5V1aYykQAIhJBW8VVp1JQmzTO5vdo=@vger.kernel.org X-Gm-Message-State: AOJu0YwbKIirP3i4uymXv5RdTup3l1QHHt/T0pAGMpnbS9zgzwKlwAD9 oFTn1XqsieQyngiJZvtB4xyg8AxvGb3BeVMlw655P68tAR6pQc8GOjiL8w2ZlkZOskM4xkr5RZC AqD8ZS0SIUUWJCYtL4i5qc+G1Jv3KJY9jh1RZNn7g199Vqh7R+S+cUnwvD/kJQfrW4po= X-Gm-Gg: AR+sD117xaAIB/Qh36Zg+yypSAp8bXFRYm4LgKotnlGO5s/IfT89IHj+lNvn/KlmWxh Rrq/weLFOGMvVmRZdSWJP67aMAChXUWK5JM1Lrd4x+/OKNI+4I7c7YUKlsYuPvFPhBcu06pFuU/ vS+5XD8QFOyYZ/alhWazjcysMsDS1/2yoDAJobPWgE5ajUiflsVm03h1rGFNJs/muAP5OdNaFv8 7/14XE/MnUtpviBrLzsJwp36EBhR2KXq8bOqXufhK0gtUNRSNR75QLYJHTjk204CzSj8RRM+T5+ +c0tAoTIf4doetYLwq1SZ1IuNbqdysuIZmfx3DU1UwLRaSyi7xQjq/quMmcvP2oOsIizWNqh1Xx eAgMRz6SmXpaX3L6Wj55Vf64+ X-Received: by 2002:a05:6102:5249:b0:745:17b0:10cc with SMTP id ada2fe7eead31-75b2498305bmr147237137.4.1785507654224; Fri, 31 Jul 2026 07:20:54 -0700 (PDT) X-Received: by 2002:a05:6102:5249:b0:745:17b0:10cc with SMTP id ada2fe7eead31-75b2498305bmr147200137.4.1785507653674; Fri, 31 Jul 2026 07:20:53 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a09c6615a1sm1609212a12.27.2026.07.31.07.20.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Jul 2026 07:20:52 -0700 (PDT) Message-ID: <7a0c4a70-b838-4c7c-9f16-d394ffef95ba@oss.qualcomm.com> Date: Fri, 31 Jul 2026 16:20:50 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] leds: rgb: leds-qcom-lpg: Add PWM frequency mode support To: Fenglin Wu , linux-arm-msm@vger.kernel.org, Lee Jones , Pavel Machek Cc: David Collins , Subbaraman Narayanamurthy , Kamal Wadhwa , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260729-lpg-pwm-fm-support-v1-1-16d3c72a9921@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260729-lpg-pwm-fm-support-v1-1-16d3c72a9921@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNzMxMDEwOSBTYWx0ZWRfX4rrhZ9XRQAS8 7LSYrtkkQuyJJOm5OEZt0yFKiYb3ecKbAVfDu7EEKiviuiwH9Xa+PPnx8QfmXgLqI41JzLAHQ5k K+EO1aeUUeZlrwGpugkyiw3ORm3m9p4= X-Authority-Analysis: v=2.4 cv=GpByPE1C c=1 sm=1 tr=0 ts=6a6caf47 cx=c_pps a=P2rfLEam3zuxRRdjJWA2cw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=AUv8OMIDIaVCD8xAqLQA:9 a=QEXdDO2ut3YA:10 a=ODZdjJIeia2B_SHc_B0f:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzMxMDEwOSBTYWx0ZWRfX9Ca1WOJR3MwY ut5dlVVaeir86akWcyiT89vNwAN29h9TOjkar5PMkjabIE4U5vye/oD00XGi/i2m4Y5/fSod6Q2 l0kXAP7UKXINv5s+ifCdBnY0SVJzP05+IwjuihgB+GN4bR4OpY5wjnRw+FSgxu1bO0Ax53KnPqk SHCyHnP1fuuFD8YV1LmjDWk3DcF9OxBEHOfxjRHK7DSXiTPDQ+lYsBmrWoK3YXhp4uPtt1As9NE 5hKx/OmbsnoFUO/AkymywwfApM/tm4cfLcaJoOAB1aR13JaOBzzi218LDKmPINlI2hw/IYdm7eh MkupFP9lVUqGow4iuoOA8OU4jhyBF9HWR3ArS7KUX/wEHM4Tn54NJSj+eefCqbFyyERzV819zlx lIJ17kOznRjz0DzQ4G1x+J0Xzi/KkG3p4yWOZwV2GMpRTDpHnEG4uCe8xf/hTqJtgYAAKO2dhBi F4rkOcDQ5NL1hBTun6g== X-Proofpoint-ORIG-GUID: Wq9YG4H49wlC0WpDYFucKySj6Wpw1Fab X-Proofpoint-GUID: Wq9YG4H49wlC0WpDYFucKySj6Wpw1Fab X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-31_04,2026-07-30_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 malwarescore=0 impostorscore=0 suspectscore=0 clxscore=1015 lowpriorityscore=0 priorityscore=1501 adultscore=0 bulkscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607310109 On 7/29/26 11:48 AM, Fenglin Wu wrote: > Certain PWM channels on a PMIC (e.g. PM8350C PWM4) support a Frequency > Mode (FM) that can generate waveforms with more frequency points than > the standard LPG PWM mode. The trade-off is that the duty cycle can > only be fixed at 50%. Add the FM support. When the PWM channel is > requested to set a duty cycle to exactly 50%, use FM mode by default > as it provides a finer-grained frequency resolution in that case. > > Signed-off-by: Fenglin Wu > --- [...] > + for (clk = 1; clk < clk_len; clk++) { > + last_err = U64_MAX; > + > + for (exp = 0; exp <= LPG_MAX_M; exp++) { > + /* Calculate pwm_value_lsb for this (clk, exp) pair */ > + lsb_tmp = period_ns; > + lsb_tmp = div64_u64(lsb_tmp, clk_period_arr[clk]); > + lsb_tmp >>= (exp + 1); > + > + if (lsb_tmp == 0 || lsb_tmp - 1 > U8_MAX) > + continue; > + > + lsb = lsb_tmp - 1; > + > + period_actual = (u64)(lsb + 1); Did you mean `(u64)(lsb) + 1` here? [...] > + /* Calculate actual period for reference */ > + period_actual = (u64)(best_lsb + 1); And here too? In general, I think there's nothing that prevents you from turning all of these variables into u64s [...] > regmap_read(lpg->map, chan->base + LPG_SUBTYPE_REG, &chan->subtype); > + if (data->channels[i].fm_capable) { > + ret = regmap_read(lpg->map, chan->base + PWM_STATUS1_REG, &status); > + if (ret < 0) > + return ret; > + > + chan->fm_capable = !!(status & PWM_FM_PRESENT); Can we read this register blindly by chance and drop the match data? Konrad