From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Doug Anderson <dianders@chromium.org>
Cc: robdclark@gmail.com, quic_abhinavk@quicinc.com,
dmitry.baryshkov@linaro.org, krzysztof.kozlowski+dt@linaro.org,
robh+dt@kernel.org, quic_mkrishn@quicinc.com,
linux-arm-msm@vger.kernel.org, Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Rajendra Nayak <rnayak@codeaurora.org>,
Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
Subject: Re: [PATCH v2 13/18] arm64: dts: qcom: sc7180: Add compat qcom,mdss-dsi-ctrl-sc7180
Date: Tue, 8 Nov 2022 12:16:48 +0000 [thread overview]
Message-ID: <7a0c6afd-e757-46f6-5837-576070e966ec@linaro.org> (raw)
In-Reply-To: <CAD=FV=XZ79JjmCW7wYoc0eEhMsAtqxb+p40x2f4mH+kdb0byow@mail.gmail.com>
On 08/11/2022 00:24, Doug Anderson wrote:
> This seems fine, but I don't think it matches your bindings. Your
> bindings says you can have one compatible string. It could be
> "qcom,mdss-dsi-ctrl-sc7180" or it could be "qcom,mdss-dsi-ctrl".
> ...but your device tree has two compatible strings: the SoC specific
> one and the fallback one. You need to change your bindings to make
> this work.
With the update in this series the binding has a required const.
If you drop back to just "qcom,mdss-dsi-ctrl-sc7180" you get a warning
like this.
arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar-r4.dtb: dsi@ae94000:
compatible: ['qcom,mdss-dsi-ctrl-sc7180'] is too short
If you just have 'qcom,mdss-dsi-ctrl' you get
arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar-r4.dtb: dsi@ae94000:
compatible:0: 'qcom,mdss-dsi-ctrl' is not one of
['qcom,dsi-ctrl-6g-qcm2290', 'qcom,mdss-dsi-ctrl-apq8064',
'qcom,mdss-dsi-ctrl-msm8916', 'qcom,mdss-dsi-ctrl-msm8974',
'qcom,mdss-dsi-ctrl-msm8996', 'qcom,mdss-dsi-ctrl-sc7180',
'qcom,mdss-dsi-ctrl-sc7280', 'qcom,mdss-dsi-ctrl-sdm630',
'qcom,mdss-dsi-ctrl-sdm660', 'qcom,mdss-dsi-ctrl-sdm845',
'qcom,mdss-dsi-ctrl-sm8250']
---
bod
next prev parent reply other threads:[~2022-11-08 12:17 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221107235654.1769462-1-bryan.odonoghue@linaro.org>
2022-11-07 23:56 ` [PATCH v2 01/18] dt-bindings: msm: dsi-controller-main: Fix operating-points-v2 constraint Bryan O'Donoghue
2022-11-07 23:56 ` [PATCH v2 02/18] dt-bindings: msm: dsi-controller-main: Fix power-domain constraint Bryan O'Donoghue
2022-11-08 21:10 ` Krzysztof Kozlowski
2022-11-07 23:56 ` [PATCH v2 03/18] dt-bindings: msm: dsi-controller-main: Add vdd* descriptions back in Bryan O'Donoghue
2022-11-08 12:59 ` Dmitry Baryshkov
2022-11-08 14:42 ` Bryan O'Donoghue
2022-11-08 16:55 ` Dmitry Baryshkov
2022-11-08 21:12 ` Krzysztof Kozlowski
2022-11-07 23:56 ` [PATCH v2 04/18] dt-bindings: msm: dsi-controller-main: Fix clock declarations Bryan O'Donoghue
2022-11-08 13:00 ` Dmitry Baryshkov
2022-11-07 23:56 ` [PATCH v2 05/18] dt-bindings: msm: dsi-controller-main: Fix description of core clock Bryan O'Donoghue
2022-11-08 13:01 ` Dmitry Baryshkov
2022-11-08 21:12 ` Krzysztof Kozlowski
2022-11-07 23:56 ` [PATCH v2 06/18] dt-bindings: msm: dsi-controller-main: Alphanumerically sort compatible enum Bryan O'Donoghue
2022-11-08 21:13 ` Krzysztof Kozlowski
2022-11-07 23:56 ` [PATCH v2 07/18] dt-bindings: msm: dsi-controller-main: Add compatible strings for every current SoC Bryan O'Donoghue
2022-11-08 12:46 ` Dmitry Baryshkov
2022-11-08 21:15 ` Krzysztof Kozlowski
2022-11-18 13:29 ` Bryan O'Donoghue
2022-11-18 13:30 ` Dmitry Baryshkov
2022-11-07 23:56 ` [PATCH v2 08/18] dt-bindings: msm: dsi-controller-main: Document clocks on a per compatible basis Bryan O'Donoghue
2022-11-08 12:43 ` Dmitry Baryshkov
2022-11-08 12:45 ` Bryan O'Donoghue
2022-11-08 21:19 ` Krzysztof Kozlowski
2022-11-07 23:56 ` [PATCH v2 09/18] ARM: dts: qcom: apq8064: add compat qcom,mdss-dsi-ctrl-apq8064 Bryan O'Donoghue
2022-11-08 13:22 ` David Heidelberg
2022-11-07 23:56 ` [PATCH v2 10/18] ARM: dts: qcom: msm8974: Add compat qcom,mdss-dsi-ctrl-msm8974 Bryan O'Donoghue
2022-11-07 23:56 ` [PATCH v2 11/18] arm64: dts: qcom: msm8916: Add compat qcom,mdss-dsi-ctrl-msm8916 Bryan O'Donoghue
2022-11-07 23:56 ` [PATCH v2 12/18] arm64: dts: qcom: msm8996: Add compat qcom,mdss-dsi-ctrl-msm8996 Bryan O'Donoghue
2022-11-07 23:56 ` [PATCH v2 13/18] arm64: dts: qcom: sc7180: Add compat qcom,mdss-dsi-ctrl-sc7180 Bryan O'Donoghue
2022-11-08 0:24 ` Doug Anderson
2022-11-08 12:16 ` Bryan O'Donoghue [this message]
2022-11-08 16:41 ` Doug Anderson
2022-11-07 23:56 ` [PATCH v2 14/18] arm64: dts: qcom: sc7280: Add compat qcom,mdss-dsi-ctrl-sc7280 Bryan O'Donoghue
2022-11-08 16:41 ` Doug Anderson
2022-11-07 23:56 ` [PATCH v2 15/18] arm64: dts: qcom: sdm630: Add compat qcom,mdss-dsi-ctrl-sdm630 Bryan O'Donoghue
2022-11-07 23:56 ` [PATCH v2 16/18] arm64: dts: qcom: sdm660: Add compat qcom,mdss-dsi-ctrl-sdm660 Bryan O'Donoghue
2022-11-07 23:56 ` [PATCH v2 17/18] arm64: dts: qcom: sdm845: Add compat qcom,mdss-dsi-ctrl-sdm845 Bryan O'Donoghue
2022-11-08 16:42 ` Doug Anderson
2022-11-07 23:56 ` [PATCH v2 18/18] arm64: dts: qcom: sm8250: Add compat qcom,mdss-dsi-ctrl-sm8250 Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a0c6afd-e757-46f6-5837-576070e966ec@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_mkrishn@quicinc.com \
--cc=rnayak@codeaurora.org \
--cc=robdclark@gmail.com \
--cc=robh+dt@kernel.org \
--cc=saiprakash.ranjan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®