From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8104864D for ; Tue, 25 Mar 2025 04:41:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742877721; cv=none; b=BOW+Xovcdm8etc9aNMWi0IHqqQMK5p5hRZ1+5lXDl0JMIXbYCS+r11EFlmUs8P5XLWfHx/pbI/NzC4En11S6uNUs5A0FRigoB9VVH6Ba+VeXgSNpBgR2VL3ecVgIojVSWP+pqAm4F5T2BJV/H880iVV1glT630VmE6vqjSHZKFc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742877721; c=relaxed/simple; bh=7xWy80QMrujZ0Ex5DlTo0yWkJidfRM8xZL9THcZoR9Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ChAGweekHkbrfQAsb6tUN12tTQe2NE/ah5Ucpn2s4HIDo6GCfsEUt+X+8xasYmebkS6uaVDh14G+z/shN3s/6DHvDh924ibfhgMSB6bzeGkepRRsYMJuZhQHYTGJCXmoRj7XN69mnYQMjjD2a4EerGaCJVncTmh3Uf2P0WNCVX8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=lP5czc5t; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="lP5czc5t" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 52OJEOic015801 for ; Tue, 25 Mar 2025 04:41:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 1NVjTuv2vpO9LvwcHKST3gkeOTVrunOLOzDwRQAoVj8=; b=lP5czc5tEOR+Sg2U O/y928utt4d9HJeUsFEDvJmT83DMwey+bMiGpgoQcpyfHMPd+Yes5WL571MdsDub 8QvdVh71pZhJBFh4Ay/ZAGV1offA29qadrr7fYTK+ypW2mfbsb2vWUGp+nzMZ5Dg PtQGR0x2xqg7+UHMozKW6tD4AtSmCewwPGqpeaXjlUCD1UyRAxJNvkO9g+Cvw/O+ DlANmTtlAX6sZHAxlqV5PXX/XqbNxkH0tQhYZ7fGZeyUXbuoNBS3gigHlXKmu9BX bfluLFEEvfnpRRNxaoZ+S7xQkiSExe9d9wShZycdI6JIv8+WierliyictdLqOCEC QlbSTw== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45hn9wefgg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 25 Mar 2025 04:41:51 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-30364fc706fso1472207a91.3 for ; Mon, 24 Mar 2025 21:41:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742877710; x=1743482510; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1NVjTuv2vpO9LvwcHKST3gkeOTVrunOLOzDwRQAoVj8=; b=o5gMvvuEQIR/1Pg2XN7YubjTE6qZPE/G8exOHxfIn3ZyFLt2zcCg3Vv+FkNFsS3o1g +MIrPMc7m1K1I6QzyLNNBnnenTHahEZ/Py7qvspCac3hYBjn36G/3z3MAi9yE7gVKxew zT84d2i2qt80kkYnN6F4JD++m4+g+jZanc27rFkxCIozpkBdvIcT93ykkcCg63R2WBdI 5q7CwsRmVgYf5o3+Ixj/2Q/f3DpskBMfP3ZwxjrwLCgVSEW09fYNeKZ3LUSTAJcSSAFf 6Qgi+0T9MeTOVslWpc050ionntRMVr4OuRWeYOqX/MV5Dk0VoGOn+QYiPnclVtFC8xk4 0crA== X-Forwarded-Encrypted: i=1; AJvYcCWEfcUQ1IyPJO2djdWCUMAg5nlGG57SIFOQVXjAsW6wq5ImjF2UyNqhRFRtG2HOeVSO7IJVy9x+2ZP1Zew=@vger.kernel.org X-Gm-Message-State: AOJu0Yzqy0dmB6LOQnxpKyrAi7GQrrPUB158jvNQjQwk0KOQa1l3C6PW T84Yt1psnt89nqiRWAJK6rhu+I+8W+5WrY3cn5xz/s29XkIjvM5+m0N0Tg+u4IhREqGSGjjOu0f eUbZSMpz48GBR9yeQwlZTHLq594n/XdXumZK+ZtHwVrM5XXqVV65sNehUv9thTRRt/VbKftk= X-Gm-Gg: ASbGncuBkMnzQTud0/lkbYe9hXfBERyum3qr/goT/1gPdtP+jEik5M2uQ757lHTS8Pw 8cwYm8XiOiu1Tin6lXZOTeVmD/HBM0ZbVERqVvAT45sVpb/iy6G6j44ZGAD+Ud7eRODYY0l7ipo uYzYQZmpKgf0L+jKs3kRFzzRiAOnTEq0y+RYMf75dkc4KUPtjePYwvz19DbkyXWhwOrPTI89qsW AgbhR4haYz066HaYNe9OKHOelbgnX/CUi2+2BYx9/KS6EdNnmRRyVQ1E3IhPSEUSwbpTdzJoe9v 0N4uT4ULIupz0y6VOPq2BO8RjYvMQbo8GoDdUNHyfe9NIQ== X-Received: by 2002:a05:6a20:2589:b0:1f3:48d5:7303 with SMTP id adf61e73a8af0-1fe4300f771mr33673872637.31.1742877709916; Mon, 24 Mar 2025 21:41:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHx8jVmGZQjbSLUZtNjlclkoC+wjvKr3wBjOfaf15PVujgPxwv0lUOLrrAJyTEPiV5QhOiaDQ== X-Received: by 2002:a05:6a20:2589:b0:1f3:48d5:7303 with SMTP id adf61e73a8af0-1fe4300f771mr33673825637.31.1742877709329; Mon, 24 Mar 2025 21:41:49 -0700 (PDT) Received: from [10.92.192.202] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-af8a2a4c905sm8046504a12.66.2025.03.24.21.41.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Mar 2025 21:41:48 -0700 (PDT) Message-ID: <7a0e7b48-6c08-abbe-7c23-a7e1c746351c@oss.qualcomm.com> Date: Tue, 25 Mar 2025 10:11:42 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 1/3] dt-bindings: PCI: qcom: Move phy, wake & reset gpio's to root port To: Rob Herring Cc: Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= , Manivannan Sadhasivam , Bjorn Helgaas , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, quic_vbadigan@quicinc.com, quic_mrana@quicinc.com References: <20250322-perst-v1-0-e5e4da74a204@oss.qualcomm.com> <20250322-perst-v1-1-e5e4da74a204@oss.qualcomm.com> <20250324163945.GA304502-robh@kernel.org> Content-Language: en-US From: Krishna Chaitanya Chundru In-Reply-To: <20250324163945.GA304502-robh@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: R0XxeeyHRr7Z4b9__LLQc7Gp1v0ivoXz X-Proofpoint-ORIG-GUID: R0XxeeyHRr7Z4b9__LLQc7Gp1v0ivoXz X-Authority-Analysis: v=2.4 cv=CPoqXQrD c=1 sm=1 tr=0 ts=67e2340f cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=Vs1iUdzkB0EA:10 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=Fxgvsqju1LP9AadwZSIA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1093,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-03-25_02,2025-03-21_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 mlxlogscore=999 spamscore=0 priorityscore=1501 suspectscore=0 bulkscore=0 mlxscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 phishscore=0 impostorscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2503250030 On 3/24/2025 10:09 PM, Rob Herring wrote: > On Sat, Mar 22, 2025 at 08:30:43AM +0530, Krishna Chaitanya Chundru wrote: >> Move the phy, phy-names, wake-gpio's to the pcie root port node instead of >> the bridge node, as agreed upon in multiple places one instance is[1]. > > You aren't really moving them except in the example. This is an ABI > break for sc7280. Is anyone going to care? > > You need to deprecate the properties in the old location. > Hi Rob, we are actually moving these properties in the driver also patch 3 https://lore.kernel.org/linux-arm-msm/20250322-perst-v1-3-e5e4da74a204@oss.qualcomm.com/T/#m168bec3f5d218a7f0c18293ff7380cba07a12e0e is the driver change in this series. >> Update the qcom,pcie-common.yaml to include the phy, phy-names, and >> wake-gpios properties in the root port node. There is already reset-gpio >> defined for PERST# in pci-bus-common.yaml, start using that property >> instead of perst-gpio. >> >> For backward compatibility, do not remove any existing properties in the >> bridge node. >> >> [1] https://lore.kernel.org/linux-pci/20241211192014.GA3302752@bhelgaas/ >> >> Signed-off-by: Krishna Chaitanya Chundru >> --- >> .../devicetree/bindings/pci/qcom,pcie-common.yaml | 22 ++++++++++++++++++++++ >> .../devicetree/bindings/pci/qcom,pcie-sc7280.yaml | 18 ++++++++++++++---- >> 2 files changed, 36 insertions(+), 4 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-common.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-common.yaml >> index 0480c58f7d99..258c21c01c72 100644 >> --- a/Documentation/devicetree/bindings/pci/qcom,pcie-common.yaml >> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie-common.yaml >> @@ -85,6 +85,28 @@ properties: >> opp-table: >> type: object >> >> +patternProperties: >> + "^pcie@": >> + type: object >> + $ref: /schemas/pci/pci-pci-bridge.yaml# >> + >> + properties: >> + reg: >> + maxItems: 1 >> + >> + phys: >> + maxItems: 1 >> + >> + phy-names: >> + items: >> + - const: pciephy > > Just drop phy-names in the new location. It's pointless especially when > foo-names is just "${module}foo". ack - Krishna Chaitanya. > >> + >> + wake-gpios: >> + description: GPIO controlled connection to WAKE# signal >> + maxItems: 1 >> + >> + unevaluatedProperties: false >> + >> required: >> - reg >> - reg-names