mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Andy Lutomirski <luto@amacapital.net>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"H. Peter Anvin" <hpa@linux.intel.com>, X86 ML <x86@kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Dave Jones <davej@redhat.com>,
	Martin Runge <Martin.Runge@rohde-schwarz.com>,
	Andi Kleen <andi@firstfloor.org>,
	Stefani Seibold <stefani@seibold.net>,
	Andreas Brief <Andreas.Brief@rohde-schwarz.com>
Subject: Re: [PATCH v2 0/2] x86: Relocate the compat vdso per process
Date: Tue, 11 Mar 2014 23:14:54 -0700	[thread overview]
Message-ID: <7a13aeea-2190-4922-81cf-2072fe6c2fbe@email.android.com> (raw)
In-Reply-To: <CALCETrVyR4GmLZ-yzPCL8xGZOZkRtPkQUcqQ=nzcRqG_Yp60wg@mail.gmail.com>

There is one sensible address: end of address space perhaps minus some small offset.  Unlikely to be used by anything specific.

On March 11, 2014 11:09:11 PM PDT, Andy Lutomirski <luto@amacapital.net> wrote:
>On Mar 11, 2014 10:02 PM, "H. Peter Anvin" <hpa@zytor.com> wrote:
>>
>> On 03/11/2014 03:15 PM, Andy Lutomirski wrote:
>>>
>>> The meat of this patch series is in patch 1.  Patch 2 is split out
>for
>>> improved bisectability.
>>>
>>> Changes from v1: Split into two patches and fixed a comment.
>>>
>>> Andy Lutomirski (2):
>>>    x86: Dynamically relocate the compat vdso
>>>    x86_32: Remove user bit from identity map PDE
>>>
>>>   Documentation/kernel-parameters.txt  |  18 +++-
>>>   arch/x86/Kconfig                     |  24 +++--
>>>   arch/x86/include/asm/elf.h           |   4 -
>>>   arch/x86/include/asm/fixmap.h        |   8 --
>>>   arch/x86/include/asm/pgtable_types.h |   7 +-
>>>   arch/x86/include/asm/vdso.h          |   5 +-
>>>   arch/x86/vdso/vdso-layout.lds.S      |   2 +-
>>>   arch/x86/vdso/vdso32-setup.c         | 173
>++++++++++++++++-------------------
>>>   arch/x86/vdso/vdso32/vdso32.lds.S    |   2 -
>>>   9 files changed, 111 insertions(+), 132 deletions(-)
>>>
>>
>> Why per process?  *If* we have compat vdso turned on, can't we just
>put it in one place system-wide?
>
>My machine has ASLR turned on, and the vma really does end up
>somewhere different each time.  I suspect that most (?) ASLR users
>would happily accept the 4k hit to keep ASLR working fully.
>
>Another downside of trying to have a common address for all processes:
>someone needs to figure out what that address is.  What happens if an
>ELF binary (or interpreter) wants to load something at the chosen
>address?
>
>--Andy

-- 
Sent from my mobile phone.  Please pardon brevity and lack of formatting.

  reply	other threads:[~2014-03-12  6:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-11 22:15 Andy Lutomirski
2014-03-11 22:15 ` [PATCH v2 1/2] x86: Dynamically relocate the compat vdso Andy Lutomirski
2014-03-11 22:15 ` [PATCH v2 2/2] x86_32: Remove user bit from identity map PDE Andy Lutomirski
2014-03-12  5:02 ` [PATCH v2 0/2] x86: Relocate the compat vdso per process H. Peter Anvin
2014-03-12  6:09   ` Andy Lutomirski
2014-03-12  6:14     ` H. Peter Anvin [this message]
2014-03-12 16:20       ` Andy Lutomirski
2014-03-12 17:32         ` H. Peter Anvin
2014-03-12 17:55           ` Andy Lutomirski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7a13aeea-2190-4922-81cf-2072fe6c2fbe@email.android.com \
    --to=hpa@zytor.com \
    --cc=Andreas.Brief@rohde-schwarz.com \
    --cc=Martin.Runge@rohde-schwarz.com \
    --cc=andi@firstfloor.org \
    --cc=davej@redhat.com \
    --cc=hpa@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=stefani@seibold.net \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®