mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "yu kuai" <yukuai@fygo.io>
To: "Nguyen Ngoc Thang" <ngocthang2710.1999@gmail.com>,
	 "Song Liu" <song@kernel.org>, "yu kuai" <yukuai@fygo.io>
Cc: "Li Nan" <magiclinan@didiglobal.com>, "Xiao Ni" <xiao@kernel.org>,
	 "Artur Paszkiewicz" <artur.paszkiewicz@intel.com>,
	 <linux-raid@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	 <syzbot+75d7e96ad03ac2dbbd9f@syzkaller.appspotmail.com>
Subject: Re: [PATCH] md: take reconfig_mutex when enabling PPL on an inactive array
Date: Sun, 4 Oct 2026 11:52:20 +0800	[thread overview]
Message-ID: <7a163544-d165-4d1a-9161-df82bced61b7@fygo.io> (raw)
In-Reply-To: <20260924171345.75894-1-ngocthang2710.1999@gmail.com>

在 2026/9/25 1:13, Nguyen Ngoc Thang 写道:

> consistency_policy_store() sets MD_HAS_PPL for an external-metadata array
> that is not running yet, without holding reconfig_mutex.  But ->pers is
> only assigned after pers->run() returns, so "not running" also covers an
> md_run() that is in progress under the lock.
>
> If the write lands inside raid5_run() after log_init() has decided not to
> set up PPL, or after a failed ppl_init_log() has cleared the flag, the
> flag ends up set with conf->log_private still NULL.  The next idle pass
> of raid5d() then does:
>
>    raid5d() -> handle_active_stripes() -> log_flush_stripe_to_raid()
>      -> ppl_write_stripe_run()
>
> and dereferences the NULL ppl_conf:
>
>    Oops: general protection fault, probably for non-canonical address 0xdffffc0000000002
>    KASAN: null-ptr-deref in range [0x0000000000000010-0x0000000000000017]
>    RIP: 0010:ppl_write_stripe_run+0x60/0x1320 drivers/md/raid5-ppl.c:538
>
> Take reconfig_mutex around the update and refuse it with -EBUSY once the
> array is running, in which case ->change_consistency_policy() is the
> right interface.
>
> Fixes: 664aed04446c ("md: add sysfs entries for PPL")
> Reported-by:syzbot+75d7e96ad03ac2dbbd9f@syzkaller.appspotmail.com
> Closes:https://syzkaller.appspot.com/bug?extid=75d7e96ad03ac2dbbd9f
> Signed-off-by: Nguyen Ngoc Thang<ngocthang2710.1999@gmail.com>
> ---
> Notes:
>
> This differs from the NULL check in ppl_write_stripe_run() that is being
> patch-tested on the syzbot page: that hides the symptom but leaves
> MD_HAS_PPL inconsistent with conf->log_private for the other PPL entry
> points.  md_attr_store() has not taken reconfig_mutex for every store since
> 6791875e2e53, so the store has to take it itself.
>
> Testing (QEMU, KASAN, x86_64): one loop assembles raid5/external/ram0 while
> a second loop keeps writing "ppl" to consistency_policy.  Without a delay the
> window is only a few microseconds, so I used a debug-only patch in
> raid5_run() (clear MD_HAS_PPL and mdelay(50) before log_init()) that is not
> part of this submission.
>    - without the fix: the syzbot oops on the first assembly,
>      ppl_write_stripe_run+0x5d in md0_raid5;
>    - with the fix and the same delay: 100/100 assemblies, no KASAN report.
> The unmodified syz repro only ended with -ENOSPC ("PPL space too small") in
> my setup.
>
>   drivers/md/md.c | 10 +++++++++-
>   1 file changed, 9 insertions(+), 1 deletion(-)
Applied to md-7.4

-- 
Thanks,
Kuai

      reply	other threads:[~2026-10-04  3:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-24 17:13 Nguyen Ngoc Thang
2026-10-04  3:52 ` yu kuai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7a163544-d165-4d1a-9161-df82bced61b7@fygo.io \
    --to=yukuai@fygo.io \
    --cc=artur.paszkiewicz@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=magiclinan@didiglobal.com \
    --cc=ngocthang2710.1999@gmail.com \
    --cc=song@kernel.org \
    --cc=syzbot+75d7e96ad03ac2dbbd9f@syzkaller.appspotmail.com \
    --cc=xiao@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®