Re: [EXTERNAL][PATCH v4 6/6] arm64: dts: amazon: add Amazon's Annapurna Labs Alpine v3 support

["Hawa, Hanna" <hhhawa@amazon.com>]

Hi Antonie,

Thanks for reviewing,

On 3/4/2020 11:27 PM, Antoine Tenart wrote:
> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
> 
> 
> 
> Hello,
> 
> Sorry, I'm a bit late to the party...
> 
> On Tue, Feb 25, 2020 at 01:29:26PM +0200, Hanna Hawa wrote:
>> diff --git a/arch/arm64/boot/dts/amazon/alpine-v3.dtsi b/arch/arm64/boot/dts/amazon/alpine-v3.dtsi
>> +     arch-timer {
> 
> Please use 'timer' instead.

Will be fixed

> 
>> +             compatible = "arm,armv8-timer";
>> +             interrupts = <GIC_PPI 0xd IRQ_TYPE_LEVEL_LOW>,
>> +                          <GIC_PPI 0xe IRQ_TYPE_LEVEL_LOW>,
>> +                          <GIC_PPI 0xb IRQ_TYPE_LEVEL_LOW>,
>> +                          <GIC_PPI 0xa IRQ_TYPE_LEVEL_LOW>;
>> +     };
> 
>> +             gic: interrupt-controller@f0000000 {
>> +                     compatible = "arm,gic-v3";
>> +                     #interrupt-cells = <3>;
>> +                     #address-cells = <0>;
> 
> No need for this.

Will be removed

> 
>> +                     interrupt-controller;
>> +                     reg = <0x0 0xf0800000 0 0x10000>,
>> +                           <0x0 0xf0a00000 0 0x200000>,
>> +                           <0x0 0xf0000000 0 0x2000>,
>> +                           <0x0 0xf0010000 0 0x1000>,
>> +                           <0x0 0xf0020000 0 0x2000>;
> 
> Please add comments here, see alpine-v2.dtsi (or other dtsi in
> arch/arm64).

Will be added.

> 
>> +                     interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
>> +             };
>> +
>> +             msix: msix@fbe00000 {
>> +                     compatible = "al,alpine-msix";
>> +                     reg = <0x0 0xfbe00000 0x0 0x100000>;
>> +                     interrupt-controller;
>> +                     msi-controller;
>> +                     al,msi-base-spi = <160>;
>> +                     al,msi-num-spis = <800>;
>> +                     interrupt-parent = <&gic>;
>> +             };
>> +
>> +             uart0: serial@fd883000 {
> 
> Looking at the Alpine v2 dtsi, this node was put in an io-fabric bus. It
> seems to me the Alpine v3 dtsi is very similar. Would it apply as well?

V3 very similar to V2, will add to io-fabric bus and will add missing 
uart devices.

> 
>> +                     compatible = "ns16550a";
>> +                     reg = <0x0 0xfd883000 0x0 0x1000>;
>> +                     clock-frequency = <0>;
> 
> Is the frequency set to 0 on purpose? Or is it set by a firmware at boot
> time (if so please add a comment)?

It's updated by firmware, will add a comment.

> 
>> +                     interrupts = <GIC_SPI 17 IRQ_TYPE_LEVEL_HIGH>;
>> +                     reg-shift = <2>;
>> +                     reg-io-width = <4>;
> 
> Since you're enabling this node explicitly in the dts, you can set it to
> disabled by default.

Ack

> 
>> +             };
>> +
>> +             pcie@fbd00000 {
> 
> Please order the nodes in increasing order.

Ack

> 
>> +                     compatible = "pci-host-ecam-generic";
>> +                     device_type = "pci";
>> +                     #size-cells = <2>;
>> +                     #address-cells = <3>;
>> +                     #interrupt-cells = <1>;
>> +                     reg = <0x0 0xfbd00000 0x0 0x100000>;
>> +                     interrupt-map-mask = <0xf800 0 0 7>;
>> +                     /* 8 x legacy interrupts for SATA only */
>> +                     interrupt-map = <0x4000 0 0 1 &gic 0 57 IRQ_TYPE_LEVEL_HIGH>,
>> +                                     <0x4800 0 0 1 &gic 0 58 IRQ_TYPE_LEVEL_HIGH>,
>> +                                     <0x5000 0 0 1 &gic 0 59 IRQ_TYPE_LEVEL_HIGH>,
>> +                                     <0x5800 0 0 1 &gic 0 60 IRQ_TYPE_LEVEL_HIGH>,
>> +                                     <0x6000 0 0 1 &gic 0 61 IRQ_TYPE_LEVEL_HIGH>,
>> +                                     <0x6800 0 0 1 &gic 0 62 IRQ_TYPE_LEVEL_HIGH>,
>> +                                     <0x7000 0 0 1 &gic 0 63 IRQ_TYPE_LEVEL_HIGH>,
>> +                                     <0x7800 0 0 1 &gic 0 64 IRQ_TYPE_LEVEL_HIGH>;
>> +                     ranges = <0x02000000 0x0 0xfe000000 0x0 0xfe000000 0x0 0x1000000>;
>> +                     bus-range = <0x00 0x00>;
>> +                     msi-parent = <&msix>;
>> +             };
>> +     };
>> +};
> 
> The rest of the series looks good.
Thanks

Regards,
Hanna

> 
> Thanks!
> Antoine
> 
> --
> Antoine Ténart, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
>