mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
To: Li kunyu <kunyu@nfschina.com>
Cc: <ntfs3@lists.linux.dev>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fs/ntfs3/indx: Remove unnecessary 'NULL' values from Pointer
Date: Wed, 6 Jul 2022 19:10:10 +0300	[thread overview]
Message-ID: <7a1f5139-fe5d-2b9b-7738-d2283599cdfb@paragon-software.com> (raw)
In-Reply-To: <20220704103113.5529-1-kunyu@nfschina.com>

On 7/4/22 13:31, Li kunyu wrote:
> Pointer variables allocate memory first, and then judge. There is no
> need to initialize the assignment.
> 
> Signed-off-by: Li kunyu <kunyu@nfschina.com>
> ---
>   fs/ntfs3/index.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/ntfs3/index.c b/fs/ntfs3/index.c
> index 6f81e3a49abf..b5c92b6ce01c 100644
> --- a/fs/ntfs3/index.c
> +++ b/fs/ntfs3/index.c
> @@ -1685,8 +1685,8 @@ indx_insert_into_buffer(struct ntfs_index *indx, struct ntfs_inode *ni,
>   {
>   	int err;
>   	const struct NTFS_DE *sp;
> -	struct NTFS_DE *e, *de_t, *up_e = NULL;
> -	struct indx_node *n2 = NULL;
> +	struct NTFS_DE *e, *de_t, *up_e;
> +	struct indx_node *n2;
>   	struct indx_node *n1 = fnd->nodes[level];
>   	struct INDEX_HDR *hdr1 = &n1->index->ihdr;
>   	struct INDEX_HDR *hdr2;

Thanks for patch, applied!

      reply	other threads:[~2022-07-06 16:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-04 10:31 Li kunyu
2022-07-06 16:10 ` Konstantin Komarov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7a1f5139-fe5d-2b9b-7738-d2283599cdfb@paragon-software.com \
    --to=almaz.alexandrovich@paragon-software.com \
    --cc=kunyu@nfschina.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ntfs3@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®