From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756855AbdEUUIs (ORCPT ); Sun, 21 May 2017 16:08:48 -0400 Received: from imap0.codethink.co.uk ([185.43.218.159]:57895 "EHLO imap0.codethink.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752959AbdEUUIq (ORCPT ); Sun, 21 May 2017 16:08:46 -0400 Subject: Re: gpio-exar: Why filtering out Commtech devices? To: Jan Kiszka , Matt Schulte References: <18f4b5cb-cba0-aab4-7958-84a5b8d28935@siemens.com> Cc: Linux Kernel Mailing List , linux-serial , linux-gpio From: Sudip Mukherjee Message-ID: <7a25751e-931f-b713-dcdd-7a7483aae115@codethink.co.uk> Date: Sun, 21 May 2017 21:08:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <18f4b5cb-cba0-aab4-7958-84a5b8d28935@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jan, On 21/05/17 12:46, Jan Kiszka wrote: > Hi Sudip, > > why do we carry > > if (pcidev->vendor != PCI_VENDOR_ID_EXAR) > return -ENODEV; > > in gpio_exar_probe? This effectively prevents that > > EXAR_DEVICE(COMMTECH, COMMTECH_4222PCIE, pbn_exar_XR17V35x), > EXAR_DEVICE(COMMTECH, COMMTECH_4224PCIE, pbn_exar_XR17V35x), > EXAR_DEVICE(COMMTECH, COMMTECH_4228PCIE, pbn_exar_XR17V35x), > > gain GPIO support. Do those devices lack access to the pins? Or can we > drop the filter. I don't have access to those devices, just wondering > because the code is not explaining the reason. Same here. I do not have these devices and have no idea if they support the gpio pins or not. Adding Matt Schulte in the Cc list, maybe he can comment. -- Regards Sudip