From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 454FC3246F0 for ; Wed, 17 Dec 2025 17:37:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765993073; cv=none; b=Yw6HyJ/VW1e/yZsNNUS6TPTFqQ6HQbkxT4E4hTVy8rD80cKvN8vwcL0vELZ5XdHuCQf5mavFOOGv+LTUfFrfPonS56qRhVxtPVT9V2MYHMT3WQpyh9yuu7WZr20SRQQ2Kn1O1LQJvHxztH+QOkfRP/AIRYxhC6W0IcSyw7KClX4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765993073; c=relaxed/simple; bh=4DSugWABfpbTNoEoQT85OZKfK7BUjkIcaoL2DQE1beI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gruQW7R4acpTbaFcab0ZM/mqYSWh0wRqk5PgmtGOIXTfRrKvLuO3bZklVUmzhXqVXggx57E7lAtjJ8mpA/x0kj3HQ9GsqFTv3Saw8pyNDErsu9J+/fHPSpQpLwfN6zFYwBPIoqo0HL2NpdWGj7e1d1ZpBHUUWH5AlZAQAMXygFI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3639FFEC; Wed, 17 Dec 2025 09:37:43 -0800 (PST) Received: from [10.57.47.3] (unknown [10.57.47.3]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 17F9B3F73F; Wed, 17 Dec 2025 09:37:48 -0800 (PST) Message-ID: <7a26c273-ebe1-4b5a-8d6d-1b81cfa80656@arm.com> Date: Wed, 17 Dec 2025 18:37:46 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] powerpc/mm: export symbols for lazy_mmu_mode KUnit tests To: Andrew Morton , "Ritesh Harjani (IBM)" Cc: linux-kernel@vger.kernel.org, Ryan Roberts , linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org References: <20251216201403.4647a4f9861d3122ee9e90d7@linux-foundation.org> <20251217163812.2633648-1-kevin.brodsky@arm.com> <878qf1kqg3.ritesh.list@gmail.com> <20251217093036.3231f9613ac8f9cf3943357f@linux-foundation.org> From: Kevin Brodsky Content-Language: en-GB In-Reply-To: <20251217093036.3231f9613ac8f9cf3943357f@linux-foundation.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 17/12/2025 18:30, Andrew Morton wrote: > On Wed, 17 Dec 2025 22:15:16 +0530 Ritesh Harjani (IBM) wrote: > >> ../arch/powerpc/mm/book3s64/hash_tlb.c:158:1: error: type defaults to ‘int’ in declaration of ‘EXPORT_SYMBOL_IF_KUNIT’ [-Werror=implicit-int] >> ../arch/powerpc/mm/book3s64/hash_tlb.c:158:1: error: parameter names (without types) in function declaration [-Werror] >> AR init/built-in.a >> cc1: all warnings being treated as errors >> make[6]: *** [../scripts/Makefile.build:287: arch/powerpc/mm/book3s64/hash_tlb.o] Error 1 >> make[5]: *** [../scripts/Makefile.build:556: arch/powerpc/mm/book3s64] Error 2 >> >> >> IMO, we will need the following header in hash_tlb.c >> >> +#include Ha strange it built fine for me without it... Maybe different config options. > Yeah, I already added Ritesh's patch which had this include, so I > think we're all good now. Great thanks both! - Kevin