From: "huangguangbin (A)" <huangguangbin2@huawei.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <davem@davemloft.net>, <jiri@nvidia.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<lipeng321@huawei.com>, <chenhao288@hisilicon.com>
Subject: Re: [RFC PATCH net-next 3/8] net: hns3: add support for devlink get info for PF
Date: Wed, 7 Jul 2021 17:21:28 +0800 [thread overview]
Message-ID: <7a2b4cec-20b2-82c7-805c-0c849035f2bc@huawei.com> (raw)
In-Reply-To: <20210706161432.7196c6b4@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On 2021/7/7 7:14, Jakub Kicinski wrote:
> On Tue, 6 Jul 2021 14:41:27 +0800 Guangbin Huang wrote:
>> + return devlink_info_version_running_put(req, "fw-version", version_str);
>
> Please use one of the existing names instead of "fw-version",
> e.g. DEVLINK_INFO_VERSION_GENERIC_FW.
> .
>
Ok, thanks.
next prev parent reply other threads:[~2021-07-07 9:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-06 6:41 [RFC PATCH net-next 0/8] net: hns3: add support devlink Guangbin Huang
2021-07-06 6:41 ` [RFC PATCH net-next 1/8] net: hns3: add support for registering devlink for PF Guangbin Huang
2021-07-06 6:41 ` [RFC PATCH net-next 2/8] net: hns3: add support for registering devlink for VF Guangbin Huang
2021-07-06 6:41 ` [RFC PATCH net-next 3/8] net: hns3: add support for devlink get info for PF Guangbin Huang
2021-07-06 23:14 ` Jakub Kicinski
2021-07-07 9:21 ` huangguangbin (A) [this message]
2021-07-06 6:41 ` [RFC PATCH net-next 4/8] net: hns3: add support for devlink get info for VF Guangbin Huang
2021-07-06 6:41 ` [RFC PATCH net-next 5/8] net: hns3: add devlink reload support for PF Guangbin Huang
2021-07-06 6:41 ` [RFC PATCH net-next 6/8] net: hns3: add devlink reload support for VF Guangbin Huang
2021-07-06 6:41 ` [RFC PATCH net-next 7/8] net: hns3: add support for PF setting rx/tx buffer size by devlink param Guangbin Huang
2021-07-06 23:16 ` Jakub Kicinski
2021-07-07 9:22 ` huangguangbin (A)
2021-07-06 6:41 ` [RFC PATCH net-next 8/8] net: hns3: add support for VF " Guangbin Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a2b4cec-20b2-82c7-805c-0c849035f2bc@huawei.com \
--to=huangguangbin2@huawei.com \
--cc=chenhao288@hisilicon.com \
--cc=davem@davemloft.net \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lipeng321@huawei.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®