mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chao Yu <yuchao0@huawei.com>
To: Chao Yu <chao@kernel.org>, <jaegeuk@kernel.org>
Cc: <linux-f2fs-devel@lists.sourceforge.net>,
	<linux-kernel@vger.kernel.org>,
	Weichao Guo <guoweichao@huawei.com>
Subject: Re: [PATCH v11] f2fs: guarantee journalled quota data by checkpoint
Date: Wed, 6 Mar 2019 14:49:28 +0800	[thread overview]
Message-ID: <7a2b9277-acbf-eda4-d043-74463d7b61c7@huawei.com> (raw)
In-Reply-To: <20180920120500.21026-1-chao@kernel.org>

Hi Jaegeuk,

On 2018/9/20 20:05, Chao Yu wrote:
> @@ -3456,3 +3477,16 @@
> 
>  extern void f2fs_build_fault_attr(struct f2fs_sb_info *sbi, unsigned int rate,
> 
> #endif
> #endif
> +
> +static inline bool is_journalled_quota(struct f2fs_sb_info *sbi)
> +{
> +#ifdef CONFIG_QUOTA
> + if (f2fs_sb_has_quota_ino(sbi->sb))
> + return true;
> + if (F2FS_OPTION(sbi).s_qf_names[USRQUOTA] ||
> + F2FS_OPTION(sbi).s_qf_names[GRPQUOTA] ||
> + F2FS_OPTION(sbi).s_qf_names[PRJQUOTA])
> + return true;
> +#endif
> + return false;
> +}

I checked dev branch, and found one patch we didn't send to mailing list,
could you please send it out?

f2fs: fix wrong #endif

I think my quota patch caused this 'wrong #endif' issue, could you add
single line comment to notice which #if the last #endif is corresponding
to? so that we can avoid same mistake as quota patch made.

Thanks,


  parent reply	other threads:[~2019-03-06  6:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-20 12:05 Chao Yu
2018-10-01  0:06 ` Jaegeuk Kim
2018-10-01  0:46   ` Chao Yu
2018-10-01  1:29     ` Jaegeuk Kim
2018-10-01  1:39       ` Chao Yu
2018-10-01  1:49         ` Jaegeuk Kim
2018-10-01  2:04           ` Chao Yu
2018-10-02 16:45             ` Jaegeuk Kim
2018-10-17  3:30               ` Chao Yu
2018-10-18 19:04                 ` Jaegeuk Kim
2019-03-06  6:49 ` Chao Yu [this message]
2019-03-12 18:28   ` Jaegeuk Kim
2019-03-13  1:17     ` Chao Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7a2b9277-acbf-eda4-d043-74463d7b61c7@huawei.com \
    --to=yuchao0@huawei.com \
    --cc=chao@kernel.org \
    --cc=guoweichao@huawei.com \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®