From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 588E626AF4 for ; Thu, 16 Apr 2026 14:28:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776349723; cv=none; b=Hs+PqhmiDXgXUnZlzfcJP4mYlyZEA6w81vs19RyioflxMY5/9Vo6NEp4Coj7QcXadzPt2NdVJ8aA/NrQhXGm79jNwyEzw7kZGiyuOsBzdsI9UU5cerRbHF9L55vRnlyzA0kueeB7aGf2cO4nFkVqjSMrnXE8hslIzugrxhhwk0k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776349723; c=relaxed/simple; bh=sP1ZmQzB3nCjBSXOJjSLcjkB+rLj0LMGeYSD8fILIlU=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=tgfPYyk4kR2RzCuWKQpHuwjcIEVW41SdaKZd59jutEivdZ0Zt8w66TR7kCFssfxK/MGIGemDUS4Jtn9krMJYBbhEUeSDMpHVJIkhKyQTVZ1RsM9s5dhCDVAFUDpT1nn2ma0UOysHyNas4gLDOZD/Lg02OeTR7xHkk5xeInjmkrA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=HNieMwfl; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ksxH8oSk; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="HNieMwfl"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ksxH8oSk" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63GAY4581245269 for ; Thu, 16 Apr 2026 14:28:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= qAP8DJ+KXPGTnZGb6mmzMea/l8Bn9RWL+nx9ZxGo4Dk=; b=HNieMwflnvcSp835 c4gipU44sWe1Ihwl+8fmLyfWIu3Ac4m9FPJlEY6MJpwvAXmr3gh+M03Wq+cZLDmm KBktm93fdKQw4OO1LfryAE3TAtcQuwcyrjSWBM2zvTAVNRrjMzK0BQRkLDenCRyi F4I/TlfF/7f9g4wnGDWhNuxeERxvBFKv7jHFj1wti7TAo4TKw5PMHjOKsxDpdVpG 2vGNQ8wUdkPc9Hk+hHAcE/u8lhUu/1UX8NFRbwee2au+1O5u0aZcgIJOMZEwWJdp 1vXeOonCmWK6BMJHwf7tjCJ1KXt5iqCmxr/XZHs/br+Duk/4TYPmyYGUwlp3IXwa iSu8ow== Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4djx4k8r9d-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 16 Apr 2026 14:28:41 +0000 (GMT) Received: by mail-vs1-f72.google.com with SMTP id ada2fe7eead31-611af0d600bso1854612137.2 for ; Thu, 16 Apr 2026 07:28:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776349720; x=1776954520; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=qAP8DJ+KXPGTnZGb6mmzMea/l8Bn9RWL+nx9ZxGo4Dk=; b=ksxH8oSkmBpIEIdzuANPNNkU0fMSFsKK6qIZczcsFCcyh2kuLr/H3OpeuLQUZtu4br bMrqNA/7bB4WrTm6mKYoAMx7iOFwQMv0ukXV0s4O4FpbAYLkFpKdM3wns+YTo9cUkdG2 PuA1doLkj5VMpP9qosA02tRuv6SlDDh+cjqD3OS2nAUP/MOO9YwypubBt7kbg47/LpM4 Sys/bFBJME+K8yCHtoIEaMCxdQyCMwWJFSNQGfaYEns5hw9id25dhC0oZRiOURoyZzsB mSVjzrsEkyMjYh6osI+zVF2sZl4MaRNaDLSHviTK4iYugpchso3rmeHRp0cdY0Q6JqlQ goRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776349720; x=1776954520; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qAP8DJ+KXPGTnZGb6mmzMea/l8Bn9RWL+nx9ZxGo4Dk=; b=ABF/Wlo9ow2rqdVcuMH94M6ac8tMFZv4AmsEjQQ61Ux6JD3msZM8g9nE75RnADztGU FI72BiyJb4nEtmg9B7s4WgdkrE7Hoyv+lWM1YCvQeGLMq6U4zHUELvMNKlwc/Ia7nQvC ZaqKnTkNYhaf56yrkZEfJrR+ZtWDrFwjNUeAx42daVuWyBl0K5Wlx/0Vg1PjjgSKD3Zu P65hsNKWw2gf305NEFLh5wHBw3BkJVgJeOxpOyE3Y2cYqvsjsZ0HCvJ4Q8+KEwjq9GLG SfS9U3g7w5hoEYcrZWkA3sir8DJD9MQb8HRxT4FfovbZFs3a5KSqMpQ5of6A3c+cBaeY fl6A== X-Forwarded-Encrypted: i=1; AFNElJ8w2Azi6Ah2xQfCdSkoTViYqPoScVcAMYtS3E0DeFYhIV3RirNydbFl/6Wz5RhyG7IhpaTqmURtkLkcTH0=@vger.kernel.org X-Gm-Message-State: AOJu0Yx2PBLMNVN2p3oZjj40SNjprQNgFDN027K9rjLKtLLvy0JtdmNe E3DcUH/NKLpsFVgAnGQO8dqCM2C2PZgXOEy6OOHRoPFXRM+hAKSw6tb0tSczy71KrVbhIRhRjfr ACi/uv/CCTMsBU38kT3YcfSSFkpTW78k+0JL4qtr/5P3F/EhMOWOUSTpCccuVSztAqac= X-Gm-Gg: AeBDieuHmi2ziZjlWnFbtHWwJBJVNfpglxoQxdSYBTUWUPu1uMZBW8fSdVuw5YVZG9D +QR5QtULup07/h44FBdC9yIcsX/YDc9bK2C4VvB7iR53jEH+ET+lodKE3byC1A7CATLarMSyJX6 J+0pCfUSbXQ1GCNAhCLbk/Jhua2VhtwagIZFaTSOWkHiTGpzaxeXBYU5Q/1KRWcdCjUp5XUsT1r t3uiPNyFFvJkzjNwaK/epEw8kwYhJqEosMAGTcppczUIybIi5bm6MTRiXlnI9q7r6sGttPrsen2 rFxWRd9AFXwQBG+YsDNgky328PC+8WvNjLNxnh5oH0N5AFqt5pRLFoiukUE4BabRsktTakQO9Cr 4ykoXI7qHneuITpiTXvRx9Zz7Vo0twgU1aCCzEXP+eV+SPgqEYW1Yj72B3INZEm+Z/Ata8RaH9n P8UnLGHxP/rSF0HGU1cZxMLaCM9Dn8vO4TPOV6HhFFEiCFrfO6JVm52mE9OoRIZBic2Ahou2tYG iYc3VJl550r9/Q1ASpc+2D5kEs= X-Received: by 2002:a05:6102:3906:b0:60f:e47c:f052 with SMTP id ada2fe7eead31-60fe47d227dmr8234443137.25.1776349720600; Thu, 16 Apr 2026 07:28:40 -0700 (PDT) X-Received: by 2002:a05:6102:3906:b0:60f:e47c:f052 with SMTP id ada2fe7eead31-60fe47d227dmr8234380137.25.1776349720050; Thu, 16 Apr 2026 07:28:40 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ba240486183sm125428166b.45.2026.04.16.07.28.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Apr 2026 07:28:39 -0700 (PDT) Message-ID: <7a32e798-8c1f-4580-a9b8-ab303bd82d93@oss.qualcomm.com> Date: Thu, 16 Apr 2026 16:28:38 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Hans de Goede Subject: Re: [PATCH v2 resend] driver core: Make deferred_probe_timeout default a Kconfig option To: Danilo Krummrich Cc: Greg Kroah-Hartman , "Rafael J . Wysocki" , Rob Herring , Bjorn Andersson , linux-kernel@vger.kernel.org, Saravana Kannan References: <20260314084916.10868-1-johannes.goede@oss.qualcomm.com> Content-Language: en-US, nl In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: O4clBqdpgmCgXjKkVIAHn0KFfV1Srn9R X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDE2MDEzOSBTYWx0ZWRfX3X79YLZrMEbK zXQT1XkjEOAQlhqfZwzgjw+fq2+fSrc8gQypwtaAGstN9GNgom30ikOgb+JFiRIDJ9jCQgbxUhb I0a6/X3Xr21hxk/pELKmwEVwtotx3eINFRbwKNXPGgVy1cabC0x4ec/ENoBshBnMrZtmOzs6Vvl DaqIUgf2HU/ZXj5AYbTWTCY/2I52gXYaVQGY9OxVb+RVUQc0pCSTHf1wgerzfTESFCihrR2Ny6G g/bVYYeO/zHBbKkESEZSm8AEWpOU/v7jhFeKUbC2WfF9X+ma4P1JgVlR9ZueXgdTCiaZKeUdhNj Iu1RDdgZ7jFrzYrJNzJ1khHVCz/HFVc9LFrrdF7Xvh7LzbRYW10IZmlC4M/7jIBzppowyLRc2FM tq6o+sNPe3g7va2tZtU0MNQbTeFwt6zlZj72Dxa6dwcjH/BNeStskJhrVqAPCXHV6sBEmrlqwR+ UuRNBn7QlDBMq9hfcsA== X-Authority-Analysis: v=2.4 cv=H47rBeYi c=1 sm=1 tr=0 ts=69e0f219 cx=c_pps a=DUEm7b3gzWu7BqY5nP7+9g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=7lw4RdiKSMLnFVrNeNwA:9 a=QEXdDO2ut3YA:10 a=-aSRE8QhW-JAV6biHavz:22 X-Proofpoint-ORIG-GUID: O4clBqdpgmCgXjKkVIAHn0KFfV1Srn9R X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-16_03,2026-04-16_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 phishscore=0 bulkscore=0 adultscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604160139 Hi Danilo, On 30-Mar-26 21:13, Danilo Krummrich wrote: > On Sat Mar 14, 2026 at 9:49 AM CET, Hans de Goede wrote: >> Code using driver_deferred_probe_check_state() differs from most >> EPROBE_DEFER handling in the kernel. Where other EPROBE_DEFER handling >> (e.g. clks, gpios and regulators) waits indefinitely for suppliers to >> show up, code using driver_deferred_probe_check_state() will fail >> after the deferred_probe_timeout. >> >> This is a problem for generic distro kernels which want to support many >> boards using a single kernel build. These kernels want as much drivers to >> be modular as possible. The initrd also should be as small as possible, >> so the initrd will *not* have drivers not needing to get the rootfs. >> >> Combine this with waiting for a full-disk encryption password in >> the initrd and it is pretty much guaranteed that the default 10s timeout >> will be hit, causing probe() failures when drivers on the rootfs happen >> to get modprobe-d before other rootfs modules providing their suppliers. >> >> Make the default timeout configurable from Kconfig to allow distro kernel >> configs where many of the supplier drivers are modules to set the default >> through Kconfig. >> >> While at it document that a value of -1 can be used to disable the timeout >> (wait indefinitely). >> >> Acked-by: Saravana Kannan >> Signed-off-by: Hans de Goede > > Applied to driver-core-testing, thanks! > > [ Drop deferred_probe_timeout documentation change in > kernel-parameters.txt. - Danilo ] Thank you! > Sorry for the delay No problem, as you see from my reply speed I've been busy with other things myself too. > I dropped the documentation change as I think it deserves > a separate patch and I think that just adding "Set to -1 to wait indefinitely." > at the end doesn't read very well. Ok, I'll submit a separate patch for this soon. > (Also, I think every negative value will result in waiting indefinitely.) > > I also upgraded Saravana's ACK (which already was conditional on this change > before) to an RB, as offered in [1]. Ack. > deferred_probe_timeout= > [KNL] Debugging option to set a timeout in seconds for > deferred probe to give up waiting on dependencies to > probe. Only specific dependencies (subsystems or > drivers) that have opted in will be ignored. A timeout > of 0 will timeout at the end of initcalls. If the time > out hasn't expired, it'll be restarted by each > successful driver registration. This option will also > dump out devices still on the deferred probe list after > retrying. Set to -1 to wait indefinitely. > > Maybe something like this? > > deferred_probe_timeout= > [KNL] Debugging option to set a timeout in seconds for > deferred probe to give up waiting on dependencies to > probe. Only specific dependencies (subsystems or > drivers) that have opted in will be ignored. A timeout > of 0 will timeout at the end of initcalls; a negative value > is treated as an infinite timeout value. If the timeout > hasn't expired, it'll be restarted by each successful > driver registration. This option will also dump out devices > still on the deferred probe list after retrying. Sounds good, I'll send a patch with the suggested text. Regards, Hans