Re: [PATCH RESEND v3] arm64: dts: qcom: qcs6490-idp: Add definition for three LEDs.

[hui liu <quic_huliu@quicinc.com>]

On 1/11/2024 4:58 PM, Krzysztof Kozlowski wrote:
> On 11/01/2024 09:47, Luca Weiss wrote:
>> On Thu Jan 11, 2024 at 3:52 AM CET, Hui Liu via B4 Relay wrote:
>>> From: Hui Liu <quic_huliu@quicinc.com>
>>>
>>> Add definition for three LEDs to make sure they can
>>> be enabled base on QCOM LPG LED driver.
>>>
>>> Signed-off-by: Hui Liu <quic_huliu@quicinc.com>
>>> ---
>>> Changes in v3:
>>> - Rephrased commit text and updated the nodes to qcm6490-idp board file.
>>> - Link to v2: https://lore.kernel.org/all/20231110-qcom_leds-v2-1-3cad1fbbc65a@quicinc.com/
>>>
>>> Changes in v2:
>>> - Rephrased commit text and updated the nodes to board file.
>>> - Link to v1: https://lore.kernel.org/r/20231108-qcom_leds-v1-1-c3e1c8572cb0@quicinc.com
>>> ---
>>>   arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 25 +++++++++++++++++++++++++
>>>   1 file changed, 25 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
>>> index 37c91fdf3ab9..f801144a1556 100644
>>> --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
>>> +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
>>> @@ -5,6 +5,7 @@
>>>   
>>>   /dts-v1/;
>>>   
>>> +#include <dt-bindings/leds/common.h>
>>>   #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>>>   #include "sc7280.dtsi"
>>>   #include "pm7325.dtsi"
>>> @@ -414,6 +415,30 @@ vreg_bob_3p296: bob {
>>>   	};
>>>   };
>>>   
>>> +&pm8350c_pwm {
>>> +	#address-cells = <1>;
>>> +	#size-cells = <0>;
>>> +	status = "okay";
>>> +
>>> +	led@1 {
>>> +		reg = <1>;
>>
>> Hi Hui Liu,
>>
>>> +		color = <LED_COLOR_ID_RED>;
>>> +		label = "red";
>>
>> Please remove the deprecated "label" property. Since you already have
>> "color" set you only need to add "function". On phones for the
>> notification LED we usually use "function = LED_FUNCTION_STATUS;"
>>
>> Also depends on what your hardware looks like, if it's 3 separate LEDs
>> then with label replaced it would be okay.
>> If the 3 LEDs are in one spot (so you can mix the colors with it), then
>> please make it a RGB multi-led like e.g. in sm8550-qrd.dts.
>>
> 
> I already asked for this and it was ignored:
> 
> https://lore.kernel.org/all/6aa67adb-a4d5-40da-a261-c90050ac04b2@linaro.org/
> 
> Let's engage three different community reviewers to repeat the same, one
> feedback. This is just disrespectful to our time.
Sorry, I ignored that comments, I will submit v4 to update it. Thanks 
for your comments.
> 
> Best regards,
> Krzysztof
>