From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6309289359 for ; Thu, 22 May 2025 10:15:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747908923; cv=none; b=QzJ8BRMnIFFQdARuUtnQVGOxIb4GrDOAPN2Q4/UQck1IZwlDRk/mwAicK8DOfxSEBAKKduQokLVbjavYxWWA9hz1rdf7eM1LX+14G3gBUfDG2+HniT4tjUcC1QSBxjhUEJC5WIkAbx6qzngy4AyvzYkyi6A/87+7CI6LpXpBhU0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747908923; c=relaxed/simple; bh=tK/AT0/ptSklMGY3ZXAhSm+TjwWxNhCiIVjH5W5f65g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GAH15417q6hbKkArT/SVq+psoLLt9Q3Vx7tWlBAHfMdfZjLrA98eIFzxPVBJfEOrs9CcRiRkgkiNGXQvLRKG3zxLR6i4jWrL0wDv+UfiSXOibY4SgbZJrnQAqGi79zIfJMtQyvo5heW6kxmTSa562aTNd1uy+WiA+1QM3hm3tOI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=HCNXRs3y; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HCNXRs3y" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747908920; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1QN/1StSBeGN9tr1Hv85s0x/h0ylEI3nHrDwar8JZ+M=; b=HCNXRs3yAf9xuexJPSMXzXiEnwTTTMPi3HF4XniMpGva2PLw1XxgJ9WY8bHEsoH05DPOBa c99uItLu/Yz9esk1WcIAPIt5GzbeVHYN3MOwdkxxzCy5QghhQKeihOWLEZaA8tSzB7Seg6 vDklKTM34FnMI8irmfE2jz8DKJVfzrM= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-606-pXOW4h8cMnSFsZffNixdTg-1; Thu, 22 May 2025 06:15:19 -0400 X-MC-Unique: pXOW4h8cMnSFsZffNixdTg-1 X-Mimecast-MFC-AGG-ID: pXOW4h8cMnSFsZffNixdTg_1747908918 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43d0a037f97so46533645e9.2 for ; Thu, 22 May 2025 03:15:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747908918; x=1748513718; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1QN/1StSBeGN9tr1Hv85s0x/h0ylEI3nHrDwar8JZ+M=; b=oymNZMeRt+Zg1WXs4GTiviaA3tPJWKTL5w/rhcNMjiVvKoK5jNd66Q4cB4sqT+TSOl /qwZvbdTOt6sL/K8FWLyboKdzDEMZFBYe/NoU3Xo1OZgjf7KN29tU99Ft7vAHvt8U0k1 vo0360pvZjqoCP+sSqeqWhmZ4zvS1eJyxqbeZBccD5H0eZUawZKXqNsgvf++zO+m0qPZ tHbhWgDC5n81TOylJsvAEX1A0FBCE9oevEgyeBlUgZICXUvX1FbHm5TqXLQgr7rwNfRB Re4tGaBrBODX1eVSdgyXyaJ6D7oL5nr2TqhGCPbrvzqqQLgHzPU9LGdOcCpZVj8av+1p xECA== X-Forwarded-Encrypted: i=1; AJvYcCWp0rz4agz6FuP33PHjLuW4w+DMIUKT6nfE3lvtIBeQPu07W8S+sG6extGpxO6+npxNv47Q9hOrcKb7eT0=@vger.kernel.org X-Gm-Message-State: AOJu0YwepxSGWBNCHdP+1+CJL6bcd4p37g+Qw/Xz9xbsxwqpc1I4VqhF Nmq4WxA8KgIV6lDCb4i3GUQzOr+r9A/rRGza/YqDiNX5OVnl3fr+Lp0B9eAanZTXbPynuk9VuiD Wcn+WhWa8btqVKGqN5RoA2UB3smPZcjijhAVszAMe3YESkaWRaSCX/516d+S2zSvdlA== X-Gm-Gg: ASbGncttpYpYFliKk0/1MInCmaRBbq7OARMzAgj6ubXmIxtc+3Kqf+baGXLMpMShMy3 A8Sda1Ff4Tj/55nI+4NPlG06czX3dnyTKYDWXOOre08ntBzUbFLUm4iotY24fem8m+amHdYGp/D j+bLusvuuLC0wsmyvnN1wmp90kLo+w0zUUQ2jr/n8pB0NYrEl7a+rAenOHoGzEw/7sqNp8/3nlF buVP9l0BwwUKGLMojCzMd5oZ5PpQE2hJBYjb2hgc6B3GTXz8/OqvS06FQeyd2gMPtpJ0QxGM6TI 9beNjcVnD70N30eVGn8= X-Received: by 2002:a05:600c:a36a:b0:442:d9fb:d9f1 with SMTP id 5b1f17b1804b1-442fefdaba1mr250773565e9.4.1747908918139; Thu, 22 May 2025 03:15:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFfzn/OwjBFHu0OW3zMj3JI9IlzzG1htGvDgUazuSuxk2ZnFD05IGB/yqpkkCM2dJtDcvfmdg== X-Received: by 2002:a05:600c:a36a:b0:442:d9fb:d9f1 with SMTP id 5b1f17b1804b1-442fefdaba1mr250773225e9.4.1747908917676; Thu, 22 May 2025 03:15:17 -0700 (PDT) Received: from ?IPV6:2a0d:3344:247a:1010::f39? ([2a0d:3344:247a:1010::f39]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-447f6ffaa6esm101611875e9.16.2025.05.22.03.15.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 May 2025 03:15:17 -0700 (PDT) Message-ID: <7a383c87-9c3d-4b61-b675-065d94f29a02@redhat.com> Date: Thu, 22 May 2025 12:15:15 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [net PATCH 2/2] octeontx2-af: Fix APR entry mapping based on APR_LMT_CFG To: Geethasowjanya Akula , Michal Swiatkowski Cc: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kuba@kernel.org" , "davem@davemloft.net" , "edumazet@google.com" , "andrew+netdev@lunn.ch" , Sunil Kovvuri Goutham , Subbaraya Sundeep Bhatta , Hariprasad Kelam References: <20250521060834.19780-1-gakula@marvell.com> <20250521060834.19780-3-gakula@marvell.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/21/25 2:07 PM, Geethasowjanya Akula wrote: >> -----Original Message----- >> From: Michal Swiatkowski >> Sent: Wednesday, May 21, 2025 2:06 PM >>> @@ -568,8 +569,12 @@ static ssize_t >> rvu_dbg_lmtst_map_table_display(struct file *filp, >>> return -ENOMEM; >>> >>> tbl_base = rvu_read64(rvu, BLKADDR_APR, APR_AF_LMT_MAP_BASE); >>> + val = rvu_read64(rvu, BLKADDR_APR, APR_AF_LMT_CFG); >>> + apr_vfs = 1 << (val & 0xF); >>> + apr_pfs = 1 << ((val >> 4) & 0x7); >>> >>> - lmt_map_base = ioremap_wc(tbl_base, 128 * 1024); >>> + lmt_map_base = ioremap_wc(tbl_base, apr_pfs * apr_vfs * >>> + LMT_MAPTBL_ENTRY_SIZE); >> >> As it is the same as in lmtst_map_table_ops() I think you can move whole to a >> new function. >> >> rvu_ioremap_wc(rvu, base, size); >> >> or sth like that. It isn't strong opinion. Rest looks fine, thanks. > Will address your suggestion in new patch along with other code enhancement. FTR, I'm fine with a net-next follow-up. Cheers, Paolo