From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7101C61D97 for ; Wed, 22 Nov 2023 13:16:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343982AbjKVNQL (ORCPT ); Wed, 22 Nov 2023 08:16:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343896AbjKVNQJ (ORCPT ); Wed, 22 Nov 2023 08:16:09 -0500 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 975559A; Wed, 22 Nov 2023 05:16:05 -0800 (PST) Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3AMDFwqr020234; Wed, 22 Nov 2023 13:15:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=RNBN553dc8xNcTidBn/TwkLF8236TAGauQzFSf93F3k=; b=mRoyoUVLhlR92I9l0ANxNNG86pSqLbCzOZTKlMsTErqIQWurPBraaGAbuhwAHojAfb8p 5GH5rF4E6PFSVBcbkCPCmMlD0ecFXsH3+4Jq5ORCWp9ILlzb7YdhbuV4W90R49y+KCVP maFT5gUpYVajbvoXJKIuORo4y7Wq/dE7kYdPNAgBKmFGaUTQ6bifz6r9DwGN4iBBZZ1E ntpk9K8t0WR6RWigT04U07Ick0RRLJcz3tdHOWVdBLpPUvW1lotC0vlMe1UlaZrv3GTM 5wEyQOKJi+kwD1M8Qp+iSjt0++Qsem9Z6KYF8WV6+ebV50oLqHiQe9330sewm5Wsylfl gw== Received: from nasanppmta03.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3uhbsp97mj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 22 Nov 2023 13:15:58 +0000 Received: from nasanex01a.na.qualcomm.com (nasanex01a.na.qualcomm.com [10.52.223.231]) by NASANPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3AMDFvqD003410 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 22 Nov 2023 13:15:57 GMT Received: from [10.206.101.41] (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Wed, 22 Nov 2023 05:15:52 -0800 Message-ID: <7a38602f-cc23-35b0-49ab-643ee1285b77@quicinc.com> Date: Wed, 22 Nov 2023 18:45:49 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2 1/3] media: venus: core: Set up secure memory ranges for SC7280 Content-Language: en-US To: Luca Weiss , Stanimir Varbanov , Bryan O'Donoghue , Andy Gross , Bjorn Andersson , Konrad Dybcio , Mauro Carvalho Chehab , , Rob Herring , Krzysztof Kozlowski , Conor Dooley CC: <~postmarketos/upstreaming@lists.sr.ht>, , , , , References: <20231002-sc7280-venus-pas-v2-0-bd2408891317@fairphone.com> <20231002-sc7280-venus-pas-v2-1-bd2408891317@fairphone.com> From: Vikash Garodia In-Reply-To: <20231002-sc7280-venus-pas-v2-1-bd2408891317@fairphone.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01a.na.qualcomm.com (10.52.223.231) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: MIc4t_oNq0weaWRgel3qG1x2FCatfBJ9 X-Proofpoint-GUID: MIc4t_oNq0weaWRgel3qG1x2FCatfBJ9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-22_08,2023-11-22_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 mlxscore=0 phishscore=0 bulkscore=0 impostorscore=0 priorityscore=1501 suspectscore=0 lowpriorityscore=0 adultscore=0 spamscore=0 mlxlogscore=999 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311220093 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/2/2023 7:50 PM, Luca Weiss wrote: > Not all SC7280 devices ship with ChromeOS firmware. Other devices need > PAS for image authentication. That requires the predefined virtual > address ranges to be passed via scm calls. Define them to enable Venus > on non-CrOS SC7280 devices. > > Reviewed-by: Konrad Dybcio > Reviewed-by: Bryan O'Donoghue > Signed-off-by: Luca Weiss > --- > drivers/media/platform/qcom/venus/core.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c > index 054b8e74ba4f..5c6baa0f4d45 100644 > --- a/drivers/media/platform/qcom/venus/core.c > +++ b/drivers/media/platform/qcom/venus/core.c > @@ -881,6 +881,10 @@ static const struct venus_resources sc7280_res = { > .vmem_size = 0, > .vmem_addr = 0, > .dma_mask = 0xe0000000 - 1, > + .cp_start = 0, > + .cp_size = 0x25800000, > + .cp_nonpixel_start = 0x1000000, > + .cp_nonpixel_size = 0x24800000, > .fwname = "qcom/vpu-2.0/venus.mbn", > }; > Reviewed-by: Vikash Garodia