From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from YT6PR01CU002.outbound.protection.outlook.com (mail-canadacentralazon11022132.outbound.protection.outlook.com [40.107.193.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB73C2DF134 for ; Mon, 17 Nov 2025 16:44:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.193.132 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763397896; cv=fail; b=s99o41TzEPVgrhOiHIrLE0QnZdMw/EGhd7R/KMaZCh4gqsIRDs33Xd7qxieOlEWVu6S31MIqxM1VWNH4DGpRCvSmCsg0JaTy3yl3KSZGQF0+jZS67BDnduUC9aIO+X/6E3sMGruI9WtrOtP1RIiakQOo8a3eHAV9JVIujd/RFMw= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763397896; c=relaxed/simple; bh=1DJ/jll0NQRMO+sDHBGnl5neUBg9QzquxV2O7vOhRKg=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=AKJ8g8rfBx6OfBy2IfjPRdu76UYl8KYQH8oIODJx3hWyqqlJ/D7n5vGEklOCjmt+EJ7D2I85QJIt3LPgVacYxWF8uX8uRZdOpOMdgU5ZcD2bpXIgf6JA9pYZhelimZHYvksk0b57aZnyga/3I2GrTbAp4ZvELR5A4jpHJ9zYI98= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=efficios.com; spf=pass smtp.mailfrom=efficios.com; dkim=pass (2048-bit key) header.d=efficios.com header.i=@efficios.com header.b=smLBY72l; arc=fail smtp.client-ip=40.107.193.132 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=efficios.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=efficios.com header.i=@efficios.com header.b="smLBY72l" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wxDypkMpvLcxYEybVe/DFefAQPgGoxNpK/UL20AK4z9ujkGaNUnPS+sL8Ub1OiFV7VQ03p5kxdYPY8YLTeK24nL4XtbFfUzWIkzuXkKFCL18FDhxF0WPJyK1ABNzwx2PWs4P+kXVFDEVAEyk7WJ0Jf3aShS2+3/PcYlh32O6FNyDWHp+yNv24le8eznHN8TlcWCZF4Ah/QRzzgegXaq8am20UXfpirUKYkemMyRxRIKG8hHJEmtIBFVogisokvvYbS3B3La9OB28jY/uZ9N581Hmf5cB/tnZRnJ5q8Qkc8ZibxKULTGIKdksLhqYVBn8+4aJwL6UlPfVt/qLiyVg9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9VLJozlE+LBJMkGj9+s0Rp7KnvFI+5hhXRfA2FNtVz0=; b=jNEUXBrMlYS/zWlw+dWlzlTYnUW7lYKLs6tnwZNvZug3oqA9Q25rY1EgB9SSul/AjL87AhafqWTiFxTmqu17aq6DM9GDjAEoKyP8XkofCSpcbvbWyftAsAqy3ftVt342sBVl28ZV8h/Ca9+LBsOOit8PUIwldAYBaQf19HZdvUwDxZzPh8DQw6IBcG3enS8O9+AhipGAa3zImo1VLpicfflw4t2UXu3eHaHl0EylEPM4WC6W0SrVrakyZ0n6nZqPLKGK1PJNdCx/5qoXzTGUENDYIVfMqetIQb9ucPpZ2W7jmA4lIs1LE4HHoXBgArc1qlBWWO0OySUlCgf2B/YSCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9VLJozlE+LBJMkGj9+s0Rp7KnvFI+5hhXRfA2FNtVz0=; b=smLBY72l7HIPcVfllqvwnB6mVyBq8K3cfpM0v0PW7hnG4y/Bc5ipNok/wPD3g/HwsismvCyUmnX9hjYk4zDg3gyXfF2aKTvr3JhZj/zYTvNddHMwxwZ+YJF1LkWncmTF/NxL1e0qL5VqKb4n4KA382Hj8CebjaQj2szSnfckiPBEmThttw48Z5x1fYS1opLpPnmcLj19ggfzjwvSlHPJdhAgkW2TFYzSdMAxWEi68Vhi8WDZv2A2PVrmEASHB9fLX36YCs6MTOx10MqvSjwI2NTpRelkNskhJNkr/T4FHD8XzEfgR+n7XdTUjLwLggm/IWdHbYv2zMTtSsNLuhhqLw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YT2PR01MB9175.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:be::5) by YT3PR01MB6242.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:66::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9320.22; Mon, 17 Nov 2025 16:44:50 +0000 Received: from YT2PR01MB9175.CANPRD01.PROD.OUTLOOK.COM ([fe80::50f1:2e3f:a5dd:5b4]) by YT2PR01MB9175.CANPRD01.PROD.OUTLOOK.COM ([fe80::50f1:2e3f:a5dd:5b4%2]) with mapi id 15.20.9320.021; Mon, 17 Nov 2025 16:44:50 +0000 Message-ID: <7a3ae12e-1ca7-4c4e-9906-03a6784d321e@efficios.com> Date: Mon, 17 Nov 2025 11:44:49 -0500 User-Agent: Mozilla Thunderbird Subject: Re: [patch V4 03/20] sched/mmcid: Cacheline align MM CID storage To: Thomas Gleixner , LKML Cc: Peter Zijlstra , Gabriele Monaco , Michael Jeanson , Jens Axboe , "Paul E. McKenney" , "Gautham R. Shenoy" , Florian Weimer , Tim Chen , Yury Norov , Shrikanth Hegde References: <20251104075053.700034556@linutronix.de> <20251104075426.796873498@linutronix.de> From: Mathieu Desnoyers Content-Language: en-US In-Reply-To: <20251104075426.796873498@linutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQZPR01CA0107.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:83::19) To YT2PR01MB9175.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:be::5) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YT2PR01MB9175:EE_|YT3PR01MB6242:EE_ X-MS-Office365-Filtering-Correlation-Id: 0ec4ac55-b14c-42c0-062e-08de25f8a016 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?WmdxWS83ZjdHZFFtd2RJWmVnU0JFQzY3SUdhUFZLT3YxUEFjWGlkYUFzMXNS?= =?utf-8?B?T3hmRUU3dEpmYmZRTVY1UTlVSHR4VUdXQlFNZzlGWERnUGVWREc5RW91OVp2?= =?utf-8?B?ZWRBTG1zSGdWazk2dlVzMmFBczBIc1dYSmZLRTRvZ1JKanZBTFNITTFaWEtr?= =?utf-8?B?anI5MWtzUHhtUUxCWklBUTk4eTBUY3d5UmhkS1JuRlBsQ3FQb0tQblEwZWxU?= =?utf-8?B?bzU1NHp1eXZSYkh0ZVhnSEJaSWhicUczdTJyT2FkeVVOYkdiWmZSRllYOFc1?= =?utf-8?B?SmVYRjZXZ3VoUUxpenhOVktRd1U2VFNFakJ3b3VnbnN4OGdYUG0vVXpqTWtM?= =?utf-8?B?c0l5SVp3N01JVG4wOS9uRXJJK1NMdFoxZUEwRndEeWpITk8yK1ZJdjM0TFNh?= =?utf-8?B?RHBMTTJIdUtLbmxwUWxQS1BiMkErc2hiT0NWNHdHV1JvNGtBb1NCdXFYc0xB?= =?utf-8?B?ZzhqS0EvVVI1Vi8veDEwTXpOZUVWZWV4aHZGSnFZWTgvVzRyUzNLdWlNK1ZS?= =?utf-8?B?OVhNUVpJSUNjNWw5alN3anVKS05TU1Z6U252SHh0d1htMUdkYzdnVlJUNno2?= =?utf-8?B?TUNVeUpDTUN1SE94YU5kWDdQM2RLMFpXcGlJdUxUNVNaY2loSzZGeUZYTlRJ?= =?utf-8?B?NmNrU2JmRnVROVN4eDMzd0hnRnd0QzJneVJCTi9WRlNyODJIUXJOK3JuTUtz?= =?utf-8?B?elhvNXBwanFkSUdjTFIrVjlkeEU5bUVaQjROZ0FwVlZleXdMdE9oeFd0QlBQ?= =?utf-8?B?azdIT2VJZ0ZLYk5yYXlsUWxOMG1ra0ZXaExNeDZuSDNmeHR4S0lhdFBYMlhm?= =?utf-8?B?amdEaHRaeTBVOUg1Q2hVdlFFMmJlRTQyS0ZDclFnNlIxVWFQV3R1dWhsb2t2?= =?utf-8?B?MVA0aEJHYVB1Mzh0RGZMNnJ3eUo5cEJhMU92TUR2STh4V3orVXRYYXI5TnVm?= =?utf-8?B?emV1K2RPY05mNlQ0TVpnemRHd2R1enRmRDEzbmxMZC9CWE5aeXJjWS9XT0pJ?= =?utf-8?B?Y3N5TTJqQXMvSTBvNnVzanRsK3ZPeC9OdHNadm1tUW5oNmxLck5Id3pIbkJw?= =?utf-8?B?V2NpUHJrVzdneDFyQXA5WXU1SXFtdFlkR3gxbCtNKzJpMWh1V3N2VFdCdEY1?= =?utf-8?B?aXhvNlV0Nk1Oekk2TGFET3JtOUFlbFg1QStzWmU4bnNycS83TzhGWmtnelhF?= =?utf-8?B?ZU9rZC9ySmZRQXpPblBDS0p1emFTWVZIUER1eFlpWE9pejdLbElqcmlLMkFP?= =?utf-8?B?QTVCWUlzb1YxL0ZWUjBNSEZOSEVDalNNanYrK0RZakNwc2hkMjgrVnB3T1VC?= =?utf-8?B?M2w1R0hYTDVVQUF2VERyYnNrL0JuOUtpdjQ4ZlRlbGdiUDBVYUxZb0lOZ1J4?= =?utf-8?B?d1p3VCtIZ2ZvTW94RUxJRWNqdU9vSW9IZm5YVDRZYWxzUEJJUkdISzNwbC8z?= =?utf-8?B?Yjc3OExXcWpKNi92dTJkMkRBWFNXSFhTZUE3TU1VV0ZhRHVHTmFHQTVCMXVo?= =?utf-8?B?UjdJbEpzVE5HMVcwMzAvYWV3dGM4L1Y3d2NNaGJxcEU2L2lxTTdCMFJmUmQ1?= =?utf-8?B?eWdwVmdNeW5sdlhOd0p5S3ZXQkxGQmltYUFPZm1RUnJWVlBBOXY3MWlGUHpC?= =?utf-8?B?Y3JBRmZ2VTAwbVpLaFEyL1dXL3E2Ni9Kay9YdmdBaml5OFJETTJJTXNMeHZC?= =?utf-8?B?cm5jV3p1MnJaOEpRTkpkdFNhY1B2ODJLcFRQcURLeDllRUZqaXlkTFkwM2cz?= =?utf-8?B?R0N1d2pDRkZNRkZUTzNCL1g5U1M4c3VvbWdqbVZhellYWkhGc21nN2JxdEFL?= =?utf-8?B?NFFCZ1k2V0k1RjNHMUNuNFFVUTBhMXlxQmppMDd4TUlFM09LdGdaWWxwOS9M?= =?utf-8?B?cCszZ0VaTGJZd1VvT2hLVlU4aEx1TmYyWHRJZkVsTkpieWc9PQ==?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:YT2PR01MB9175.CANPRD01.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(1800799024)(366016);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZHI0Z001Sm9URmYrajF6RjlMbFlHbVVoUlpBaENTc2RQK3RUU0lTc3VVMGhJ?= =?utf-8?B?WjFoRGNUc1U0NGlRdnBQVWZFVkpFOU9zL1BhbmdtMlFvb3hLbVEvQU93ZUtO?= =?utf-8?B?cHV0ZWQyWSt1MWtCR0YzYWs4dGVwUUVxQk9MdzNVcjErRVBSMitoNkRWRnhp?= =?utf-8?B?YUNEZXhnbFdTVHJjQjRydEx0em1sYlVNYi9LZWlIMU1GWWd1ZUp2KzdxWXF1?= =?utf-8?B?NEpvSjdFMU5YOXpWTFFlNW5Db3REZ04xUDR0VnF6QWREa0FpNDUzdkZZZ2gx?= =?utf-8?B?cVc3b09EdncrZEhRWmZ5ejM2ZUZ4a1pJZk9vbWxzZVVjM25wUy9NL0EvYnJi?= =?utf-8?B?WlpIbGdZVVNXVFZxSGkvSHdOV2ltWWF3UnY1UVZvaVhXcWhFa3lldThnSFow?= =?utf-8?B?S2NwWFdkMEFwZUUxd08zQW1ZanB5eDBITU9qVGRPZ2V4M3dFcEs4WUE5eHU4?= =?utf-8?B?SlhXOGlJRFZaVys4WE5HYWZ1YkJJK1pjUlpURE5vRjkrbHo3M1J0ZjZ6dmJ1?= =?utf-8?B?cFFBaEZYUThrMThJei84eDBMdzlnYnJmK2JVMU9DOEhmTjVFcW9EUnp3Ull2?= =?utf-8?B?Z3Evc2RQVVBJbFBtZ29sRXh0R0Z2V1JYNVRBSnNtOWdRNkZXSjA1NjR1enZ3?= =?utf-8?B?aXhZcXNsRE8wS1NPOXpSTWxLZXhGSVdGY0VoclZsN3R0YVI3RHBVZm9TZTVV?= =?utf-8?B?dS9ySGNiMkVWSkFnUDhteGdNUTZUZEhvaGh0K0RNVGd6ekZwYUZxd1QvQVVI?= =?utf-8?B?dEhhTy9iMjJWRWl5bUFOTDF3dDFIL3BjOXJuS0NRYUt4YjBXNzRrc0trNlpl?= =?utf-8?B?VjlpQTlTNmdSTTN5a2NqM2c2R0RDTlJKdFlVT1dWTTA2SktwcWhyQllQT1Zs?= =?utf-8?B?ZzZQSERKeEJjb0UyVHVqdlN4U2dJdHljUzJPTE9hZURqUnhJdGdTUS93SEUv?= =?utf-8?B?SDE3cUkvWEJZdDlEQTNVYkxPbUNmVFUwMEJkMytYb3FIYzFLbkQ3eXlpbGl6?= =?utf-8?B?R3Uvb08yaHUraXdqVFN5czRERnVwd2hMUVNTc3ZKYjFsc3hxWHhYNnRxLzZP?= =?utf-8?B?WHVISFk5V2dIZlpMTldTR0pMZERxM3BNdnpSa21YZnZnYVVSOWllVVQ2aWVI?= =?utf-8?B?aW53dVBmM2ZCbE9MU0hXRHBiR2JMVXFHbytzK3hIeFlBSGtqdHRXY2tkd2VK?= =?utf-8?B?dW4yMDJyYnpwYmRUQzU0RkJ2cUdJU1pGY3AwWHFmSThEU1V6R2NXTDRFaWNO?= =?utf-8?B?S1NnTzRqS2wxVWdyMEdHY0huZlp0U2RIaVIzbnpBajZjTis5amhwTW9vbU9n?= =?utf-8?B?SkxoMytEU3RXYTc0UFFHT3FUNWRva1ZvSzVpVUlEanRscndIR2ZZdXd0QVdO?= =?utf-8?B?RFZPQXMrV0ZQNjYxbnNuTFNVSW9zdExjUGc5ZkNOVzJZYnJ4MVZGNllWZ2Z3?= =?utf-8?B?WWhPNkNueGhGNU0zSXBJUDFCMDkyb293KzJ0N1pFc3N3TTlFSVdEWjVQTmNv?= =?utf-8?B?d2VPZGRvNEpnWTh1R21McGgyQmduc1V2Vi80bVA3MTV5bTJSaVk1U3FyeUxH?= =?utf-8?B?aURxRE43cEtOYTBkck5vMVIzaWI0QkxqYmhoaWx5U0trTFBkVkJVRlpWLzZs?= =?utf-8?B?U3FJTEtyNTdTd25UbTlJK0hPOUtGdWhVcTl5UStubE5RQS9lL212RWVmd0RL?= =?utf-8?B?K1lpc3NFdU5iQ2ZiV2xGVjdEVkVoR0hORVQvQ2NGVGFJOWR6STB6TU1lRnRG?= =?utf-8?B?Ym1xV2F2eFZ2SEVJdE5mNFphTEg2QmxRdm80bENZdWFvdk1UdGxteGhFZC84?= =?utf-8?B?ZUR1VUg4Q0ExTVFEK3pYWTM3RmdVaWFabElvMHNLUVNjbWR2ZmVRNVJ4bGUz?= =?utf-8?B?Ly93Q2J2cWJMQ2U4b253VUtiRW1UUFpmTkkySWQycFhrN2g0N0dLSUFRMFRH?= =?utf-8?B?VStVeDJpMk1KamVaZVRuTXIrRU52SC9LQkwvM09tWjFvWHhERnIyOHdTYXdG?= =?utf-8?B?bWw1cmowcklySE45N29uNTZYMDRKZ2NvcnFZQVVuK1NiNEg0VWpQVmp1dnRO?= =?utf-8?B?TlhpVXg2WXlqd0hrZk5sbzhuWUdqdjBsVGpPTVc0MlNpaC9tY3o0eDhScEJo?= =?utf-8?B?aUU4bExpVERpRWxkcjlzZTJ0MzMwZzRna1M3UENEZC9wTERjVG16Q3BXWXFV?= =?utf-8?Q?Z/OK2vFtZHMYHOtL/njNwlo=3D?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0ec4ac55-b14c-42c0-062e-08de25f8a016 X-MS-Exchange-CrossTenant-AuthSource: YT2PR01MB9175.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2025 16:44:50.2613 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YGXCk+NMPVv5k7mCj+VI1enBZNJT4FNQMLDchS8Jq1bA4oqKphzVtHoayEwHVlaTW2TmI4ypYfOfQ18I9mOgd/QJrb66jnTsAEco1mfcNu4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT3PR01MB6242 On 2025-11-16 15:48, Thomas Gleixner wrote: [...] > --- a/include/linux/rseq_types.h > +++ b/include/linux/rseq_types.h > @@ -112,7 +112,7 @@ struct sched_mm_cid { > */ > struct mm_cid_pcpu { > unsigned int cid; > -}; > +}____cacheline_aligned_in_smp; Missing space between "}" and "____cacheline_aligned_in_smp". > > /** > * struct mm_mm_cid - Storage for per MM CID data > @@ -126,7 +126,7 @@ struct mm_mm_cid { > struct mm_cid_pcpu __percpu *pcpu; > unsigned int nr_cpus_allowed; > raw_spinlock_t lock; > -}; > +}____cacheline_aligned_in_smp; likewise. Other than those nits: Reviewed-by: Mathieu Desnoyers Thanks, Mathieu -- Mathieu Desnoyers EfficiOS Inc. https://www.efficios.com