mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Ehab Ababneh <ehab.ababneh@intel.com>
Cc: Hans de Goede <hansg@kernel.org>,
	tony.luck@intel.com,  ashok.raj.linux@gmail.com,
	platform-driver-x86@vger.kernel.org,
	 LKML <linux-kernel@vger.kernel.org>,
	tglx@kernel.org, mingo@redhat.com,  bp@alien8.de,
	dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
	 rostedt@goodmis.org, mhiramat@kernel.org,
	mathieu.desnoyers@efficios.com,
	 linux-trace-kernel@vger.kernel.org, peterz@infradead.org,
	 sathyanarayanan.kuppuswamy@linux.intel.com,
	pengfei.xu@intel.com,  ravi.v.shankar@intel.com
Subject: Re: [PATCH v2 12/17] platform/x86/intel/ifs: Add new sysfs interfaces {status, details, cpus_ran}_list
Date: Thu, 19 Nov 2026 14:06:51 +0200 (EET)	[thread overview]
Message-ID: <7a3f0d3e-291a-6498-f605-8465cc5bf963@linux.intel.com> (raw)
In-Reply-To: <20261118193259.519568-13-ehab.ababneh@intel.com>

On Wed, 18 Nov 2026, Ehab Ababneh wrote:

> From: Jithu Joseph <jithu.joseph@intel.com>
> 
> Problem
> =======
> The current legacy interface for Intel In-Field Scan is designed to
> simultaneously test all CPUs in a group [1], but it only reports the
> status of the primary CPU in this group and doesn't indicate that
> secondary CPUs have been tested. This results in the following issues:
> 
>   - All CPUs in a group can hold different statuses, but the user can
>     only see the status of the primary CPU, as any errors observed by
>     secondary CPUs are ignored.
> 
>   - The topology of a group of CPUs may vary across systems. For example,
>     in a Hyper-Threading (HT) system, the group consists of all CPUs in
>     a core, while in a Dual-Core Module (DCM) based system (e.g., Intel
>     Diamond Rapids CPU), two cores in a module form a group. The user may
>     be unaware of the group topology and test each CPU of the system
>     individually, leading to duplicate test runs.
> 
> Solution
> ========
> The user continues to write a single value to run_test, and while the
> legacy sysfs reports results for the tested CPU to ensure backward
> compatibility, new sysfs interfaces {status, details, cpus_run}_list
> provide results for multiple related CPUs tested as part of a group.
> The user can check for the presence of new sysfs interfaces to
> understand that multiple results are available, read them, and identify
> which CPUs have been tested to avoid duplicate tests.
> 
>   intel_ifs_0
>   +---- run_test	<--- Same legacy file
>   +---- current_batch
>   +---- details
>   +---- details_list	<--- Details for all CPUs in the group (new)
>   +---- dev
>   +---- image_version
>   +---- status
>   +---- status_list	<--- Status for all CPUs in the group (new)
>   +---- cpus_ran_list	<--- CPUs in the group tested along with CPU written to run_test (new)
>   \---- uevent
> 
> Example of reading the cpus_ran_list to see the CPUs tested:
> 
>   echo 0 > run_test
>   cat cpus_ran_list
>   0,96
> 
>   cat status_list
>   pass pass
> 
>   cat details_list
>   0x8086 0x8087
> 
> [1] Indicated by bits [20:16] of MSR_INTEGRITY_CAPABILITIES when bit 21 is set.
>     E.g., in Hyper-Threading (HT) systems, a group includes all threads in a core;
>     in Dual-Core Module (DCM) system, a group includes all CPU cores in a module.
> 
> [ Qiuxu: wrote the commit message. ]

Not among Signed-off-by members?

> 
> Signed-off-by: Jithu Joseph <jithu.joseph@intel.com>
> Signed-off-by: Ehab Ababneh <ehab.ababneh@intel.com>
> Tested-by: Yi Lai <yi1.lai@intel.com>
> ---
>  drivers/platform/x86/intel/ifs/sysfs.c | 60 ++++++++++++++++++++++++++
>  1 file changed, 60 insertions(+)
> 
> diff --git a/drivers/platform/x86/intel/ifs/sysfs.c b/drivers/platform/x86/intel/ifs/sysfs.c
> index 287f96bb033e..e96faf7bf0fa 100644
> --- a/drivers/platform/x86/intel/ifs/sysfs.c
> +++ b/drivers/platform/x86/intel/ifs/sysfs.c
> @@ -135,6 +135,63 @@ static ssize_t image_version_show(struct device *dev,
>  
>  static DEVICE_ATTR_RO(image_version);
>  
> +static ssize_t status_list_show(struct device *dev, struct device_attribute *attr, char *buf)
> +{
> +	struct ifs_data *ifsd = ifs_get_data(dev);
> +	struct ifs_test_output *pcpu_state;
> +	int lcpu, len = 0;
> +
> +	for_each_cpu(lcpu, &ifsd->grp_cpumask) {
> +		pcpu_state = per_cpu_ptr(ifsd->result_ptr, lcpu);
> +		len += sysfs_emit_at(buf, len, "%s%s", (len > 0) ? " " : "",
> +				     status_msg[pcpu_state->test_result]);
> +	}
> +
> +	if (!len)
> +		return sysfs_emit(buf, "%s\n", "none");
> +
> +	len += sysfs_emit_at(buf, len, "\n");
> +
> +	return len;
> +}
> +
> +static DEVICE_ATTR_RO(status_list);
> +
> +static ssize_t details_list_show(struct device *dev, struct device_attribute *attr, char *buf)
> +{
> +	struct ifs_data *ifsd = ifs_get_data(dev);
> +	struct ifs_test_output *pcpu_state;
> +	int lcpu, len = 0;
> +
> +	for_each_cpu(lcpu, &ifsd->grp_cpumask) {
> +		pcpu_state = per_cpu_ptr(ifsd->result_ptr, lcpu);
> +		len += sysfs_emit_at(buf, len, "%s%#llx", (len > 0) ? " " : "",
> +				     pcpu_state->test_details);
> +	}
> +
> +	if (!len)
> +		return sysfs_emit(buf, "%s\n", "none");
> +
> +	len += sysfs_emit_at(buf, len, "\n");
> +
> +	return len;
> +}
> +
> +static DEVICE_ATTR_RO(details_list);
> +
> +static ssize_t cpus_ran_list_show(struct device *dev, struct device_attribute *attr, char *buf)
> +{
> +	struct ifs_data *ifsd = ifs_get_data(dev);
> +	int len;
> +
> +	len = sysfs_emit(buf, "%*pbl", cpumask_pr_args(&ifsd->grp_cpumask));

Why doesn't this format string just add \n and return immediately?

> +	if (!len)
> +		return sysfs_emit(buf, "%s\n", "none");
> +
> +	return len + sysfs_emit_at(buf, len, "\n");

> +}
> +
> +static DEVICE_ATTR_RO(cpus_ran_list);
>  /* global scan sysfs attributes */
>  struct attribute *plat_ifs_attrs[] = {
>  	&dev_attr_details.attr,
> @@ -142,6 +199,9 @@ struct attribute *plat_ifs_attrs[] = {
>  	&dev_attr_run_test.attr,
>  	&dev_attr_current_batch.attr,
>  	&dev_attr_image_version.attr,
> +	&dev_attr_status_list.attr,
> +	&dev_attr_details_list.attr,
> +	&dev_attr_cpus_ran_list.attr,
>  	NULL
>  };
>  
> 

-- 
 i.


  reply	other threads:[~2026-11-19 12:07 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 19:32 [PATCH v2 00/17] platform/x86/intel/ifs: Support group-based In-Field Scan and Diamond Rapids Ehab Ababneh
2026-11-18 19:32 ` [PATCH v2 01/17] platform/x86/intel/ifs: Revert SBAF feature Ehab Ababneh
2026-11-18 19:32 ` [PATCH v2 02/17] platform/x86/intel/ifs: Fix IFS sysfs interfaces in the comments Ehab Ababneh
2026-11-18 19:32 ` [PATCH v2 03/17] platform/x86/intel/ifs: Clarify In-Field Scan MSR bit macro definitions Ehab Ababneh
2026-11-18 19:32 ` [PATCH v2 04/17] platform/x86/intel/ifs: Use u64 to define the bits of IFS MSR registers Ehab Ababneh
2026-11-18 19:32 ` [PATCH v2 05/17] platform/x86/intel/ifs: Early return on the IFS image hash/chunk error Ehab Ababneh
2026-11-18 19:32 ` [PATCH v2 06/17] platform/x86/intel/ifs: Refactor Array BIST function interface Ehab Ababneh
2026-11-18 19:32 ` [PATCH v2 07/17] stop_machine: Add stop_cluster_cpuslocked() for per-cluster operations Ehab Ababneh
2026-11-19 11:28   ` Ilpo Järvinen
2026-11-18 19:32 ` [PATCH v2 08/17] platform/x86/intel/ifs: Enumerate the bit to determine if CPUs need to join for IFS tests Ehab Ababneh
2026-11-18 19:32 ` [PATCH v2 09/17] platform/x86/intel/ifs: Select CPUs from topology_cluster_cpumask() for simultaneous " Ehab Ababneh
2026-11-19 11:38   ` Ilpo Järvinen
2026-11-18 19:32 ` [PATCH v2 10/17] platform/x86/intel/ifs: Warn if a group test fails with CPUs missing Ehab Ababneh
2026-11-19 11:42   ` Ilpo Järvinen
2026-11-18 19:32 ` [PATCH v2 11/17] platform/x86/intel/ifs: Track and report scan results on a per-CPU basis Ehab Ababneh
2026-11-19 12:00   ` Ilpo Järvinen
2026-11-18 19:32 ` [PATCH v2 12/17] platform/x86/intel/ifs: Add new sysfs interfaces {status, details, cpus_ran}_list Ehab Ababneh
2026-11-19 12:06   ` Ilpo Järvinen [this message]
2026-11-18 19:32 ` [PATCH v2 13/17] platform/x86/intel/ifs: Add additional details sysfs interface Ehab Ababneh
2026-11-18 19:32 ` [PATCH v2 14/17] platform/x86/intel/ifs: Add Intel Diamond Rapids server support Ehab Ababneh
2026-11-18 19:32 ` [PATCH v2 15/17] platform/x86/intel/ifs: Remove limit on number of batch files Ehab Ababneh
2026-11-19 12:09   ` Ilpo Järvinen
2026-11-18 19:32 ` [PATCH v2 16/17] platform/x86/intel/ifs: Update IFS documentation Ehab Ababneh
2026-11-19 12:12   ` Ilpo Järvinen
2026-11-18 19:32 ` [PATCH v2 17/17] Documentation/ABI: Update IFS ABI doc Ehab Ababneh
2026-11-19 12:13   ` Ilpo Järvinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7a3f0d3e-291a-6498-f605-8465cc5bf963@linux.intel.com \
    --to=ilpo.jarvinen@linux.intel.com \
    --cc=ashok.raj.linux@gmail.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=ehab.ababneh@intel.com \
    --cc=hansg@kernel.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=mingo@redhat.com \
    --cc=pengfei.xu@intel.com \
    --cc=peterz@infradead.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=ravi.v.shankar@intel.com \
    --cc=rostedt@goodmis.org \
    --cc=sathyanarayanan.kuppuswamy@linux.intel.com \
    --cc=tglx@kernel.org \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®