From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout.web.de (mout.web.de [212.227.17.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C332C2D6 for ; Fri, 19 Jul 2024 19:43:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721418200; cv=none; b=UQwycPdEpFKv8t7M8bkxshZEipo1OP8EEDoai3lAOSOnEvn78igjF4Icf/+qJ7vZzZoaWiG2Nz3E3l5LE02qGxeN9io8eCuAJq5ghlG0SP4OhhYHSP6XwOpg4ih99Q78D5g0Ygi3yv+EmGg18P11v517RzGZ1C/E8+Lcvwld060= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721418200; c=relaxed/simple; bh=EvOnKCXddB3fcweVynOJQR15/TYEK6U+HCp7OqZSUIQ=; h=Message-ID:Date:MIME-Version:To:Cc:References:Subject:From: In-Reply-To:Content-Type; b=NBARJIpy2wRCfESGHo633b2DTyM2OOUo33I/nwLx6ECO14SvkGPc06FQw+7l8bGBn4PmdA52p/kt1HTne6AlrhIPt5ibKmorgECRLnnVxUFQbwpn5oavpsPl8O0p0VUuJnnNm/kkg5jgksviqJtD8gHVavf7u0B8EQdmAttQfVI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de; spf=pass smtp.mailfrom=web.de; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b=o4jfNsaM; arc=none smtp.client-ip=212.227.17.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="o4jfNsaM" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1721418174; x=1722022974; i=markus.elfring@web.de; bh=XdQo978hRhSu8hM06roh7Tew0L0VVxDPucLV02cKyPY=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:To:Cc:References: Subject:From:In-Reply-To:Content-Type:Content-Transfer-Encoding: cc:content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=o4jfNsaMGhzFX5LW9JO7Gtukc8h7ZmQveyKm9f88V3SEeHuft9puFpf1LYKQBr7n vdI0iZB82Tg8WZsu2QBN7yZtvXoofpFgRrLJD30iYBB4cBdQn4AEWdLMvNiCZpJCu w8YGKRmBzLSgLrdRGxraC+u61QOaK2d3fqBkP7fESE1HJH1rmanpLQrBdSNVzypVZ 4zP7eHpwR87EY/mJ02pNIjjxZm/xslxlDnp9+KvCBFgY3TC3OUWhfIlZDFd+O73T/ wpRDoKwQLm67P5tzXCCXP7M+ahmFJoE7k17wW/KoU5ZxV6wu1tRTdDTwx3DAKtq2S /6WoPT+rku4mJGW6qg== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.86.95]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MmQYd-1s4fM72cbZ-00mOXn; Fri, 19 Jul 2024 21:42:54 +0200 Message-ID: <7a419902-f45e-45bc-bd9c-3b3e434f9e7a@web.de> Date: Fri, 19 Jul 2024 21:42:43 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: George Yang , Lizhi Hou , Min Ma , Narendra Gutta , dri-devel@lists.freedesktop.org, Oded Gabbay Cc: LKML , Max Zhen , Sonal Santan References: <20240719175128.2257677-2-lizhi.hou@amd.com> Subject: Re: [PATCH 01/10] accel/amdxdna: Add a new driver for AMD AI Engine Content-Language: en-GB From: Markus Elfring In-Reply-To: <20240719175128.2257677-2-lizhi.hou@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:Fn7rppQ3jnGXNy7LucW3aU0X3tgjl2Av2G5DVyWrblsBGnlVuCJ HKBxgFv03UWtWyTgoPQ+SMLqJoPzU3zgA98uyeHuVwN+xktcscaZ10dOCA3VDMbkwkBu3Ew Rqt2Ofh00VX2YxS1DwZRcoHUpBwje4NyQZumE2tcdLY2+m7abvJ7nZredDDtCIaLCGb+pFs 7g/yyE7eMOx3uWPfiIIqw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:B9F4nfLKQ4I=;kMj1+AXKPM9WZlQe1gqrmFmci8k yPFPT6426dcawxgDcqum+XLLrOIv4gTrTHZXMvo8kQgfUs5vdYqUB0kONydWToFe2pU7IiCXI hHx3ft7khrbKRI9Hv4yHABVH0yfKPnQu2sEjZ9PRii1H1aNtAG1i/rTJIIw3ZZJXRe+jX3VPd IO4gVrhpTG4bKu6SoeBrhwi2EBAyhx0EdqAzOkmCsdRXpA8fy16NDIxGnvYTQkMsMCxWPJVC0 gN2jaDd4agRaSKgYoNdhkiDOOJbHUN4EeSwH9SFea3RQNTHbZkiASwPxXeYUli0wNCJ/AYJQR aU7yznMlRcw9vykOFBiYBD6J/hu9bARsEh//J5W/TU0K06j5xe0vsoP7Gi6Ktz6FycAyIkvy7 GxTQQ8xWJGAJAZ7vUWZMiLjoYnRApsDZGzDkH+er90TUzCb4pwZSksTAJjrZTZgoyDJo9p/ZL YE88Muq5XPL8mn7CiHw8bEUqcJnR6whurGdedXW3LI4904cRczO1By3QO1RsEOiHYmUr9qxAT 6KmkSUnYK9Vu94FFmum4slBfve/lU/uhTRRCaQnGd8rnkZ3hIgcTwWAoZE0t2WZa71ZWI/i5x x5Nh3Gpl2w6gG+LESPj6gOrQX0AVSKGkSNeobEXXCHNfXcaj44DQOxZPNGk2DjQ5myqPxlVzS i1Hz3o6/7Cw3qpj5HJa2jEptQUDYLT6NEJaWNZX8e0XHLNC5TfDCMtVAPDa1dT0SiR873DzV2 S8O4R76BhVG01rNSyoRyZKaZ7c3fVDsj6V5ct/07rfwyoZ6w25F3xDl0iXFyVz9jOA54qXzr0 lD7wM2mb3r1LhX2xjuDzMuOw== =E2=80=A6 > +++ b/drivers/accel/amdxdna/amdxdna_pci_drv.c > @@ -0,0 +1,118 @@ =E2=80=A6 > +static int amdxdna_probe(struct pci_dev *pdev, const struct pci_device_= id *id) > +{ =E2=80=A6 > + mutex_lock(&xdna->dev_lock); > + ret =3D xdna->dev_info->ops->init(xdna); > + mutex_unlock(&xdna->dev_lock); =E2=80=A6 Under which circumstances would you become interested to apply a statement like =E2=80=9Cguard(mutex)(&xdna->dev_lock);=E2=80=9D? https://elixir.bootlin.com/linux/v6.10-rc5/source/include/linux/mutex.h#L1= 96 Regards, Markus