From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F36C437465; Mon, 13 Jul 2026 14:18:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783952326; cv=none; b=jscdlYEVeEj8xRPRkX0pHqIO21sE/6x9VWSZy9dn15HRXrRvMvX+fLb0+hyAef2c6aBubNXrR1+TPYAeZ0okn768d3EPDDTVyCGGXZzKA+9LIL05YLvnUE47Lip6ZSX1kLbJU36PKS0UQo5dVDUpce8ifYkOb0cJmUNlmS/n9MU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783952326; c=relaxed/simple; bh=/5f9JM0AmKctXixbnSpwS2oqfqYAdw5gzLLHI1G5q4o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fUwhpoJGSRdqpN74yidAqtqusCfxM+rVCU/3n5FldCMecGb2/vNRRaWZFIH6Ie46WPMXcTu3GYh5Ldtt5p9SL8p8AhAXM5BAK0/u336R4G+XLOaP3PWe5VbHYvu2a69gV1UrshVk1LZr7GxGS+RNBw+VaPPYxp96qPZubV5yS7k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=HKJKa+3s; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="HKJKa+3s" Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66DCCuNx2436841; Mon, 13 Jul 2026 14:18:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=pDZ/IcHYMn20WyBXP qVl9fp/FWltDktN8L55+mUzKok=; b=HKJKa+3spMIxI9+GZgOFvYDJmjXV7iB7i sQBhoQmqJgAOhD0+LvlNhAJdPDKbvEcYsHF2KUIlgcz2RmOBd21erqFLdrRypC6c ZM1GjdS6buT03+6RMRBEtHrCFLybwcT/XCOkspTJTgE2vNdGwWejssSevy3QrRtU 3GO5+UPKNzb370Ik+Ex6quh1hwRkRRoXGg3MddtoCK+wHCXrWoGQRO/XT9YhM6tl gS+d+M29bSM4MQWQLQr0neu2Ac3hfcJGIPDHVUayOe76T5VLDtWWlonXIvuvRzjJ AD8bRqUlrRfaKAHwKYppSYIbbuLtxgn+PCBi5zkpmeMmurl4X4dhA== Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4fbepx92f6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 13 Jul 2026 14:18:33 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 66DE4dnX027039; Mon, 13 Jul 2026 14:18:32 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4fc0hvx4te-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 13 Jul 2026 14:18:32 +0000 (GMT) Received: from smtpav03.fra02v.mail.ibm.com (smtpav03.fra02v.mail.ibm.com [10.20.54.102]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 66DEISee29164032 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 13 Jul 2026 14:18:28 GMT Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3C1292004E; Mon, 13 Jul 2026 14:18:28 +0000 (GMT) Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 165772004B; Mon, 13 Jul 2026 14:18:28 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.87.85.9]) by smtpav03.fra02v.mail.ibm.com (Postfix) with SMTP; Mon, 13 Jul 2026 14:18:28 +0000 (GMT) Received: by tuxmaker.boeblingen.de.ibm.com (Postfix, from userid 55669) id 00C3D162533; Mon, 13 Jul 2026 16:18:28 +0200 (CEST) From: Alexander Gordeev To: Gerald Schaefer , Heiko Carstens , Christian Borntraeger , Vasily Gorbik , Claudio Imbrenda , Andrey Ryabinin Cc: linux-s390@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, Kevin Brodsky , David Hildenbrand Subject: [PATCH v5 4/4] s390/mm: Lazy MMU mode sanitizer Date: Mon, 13 Jul 2026 16:18:27 +0200 Message-ID: <7a4eea996903a1d0e94c81a3ea09ce361ac7b7e0.1783945507.git.agordeev@linux.ibm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Proofpoint-GUID: 633p1VA7coOOqTUUask6iYHUstJbU1_D X-Proofpoint-Spam-Info: AW1haW4tMjYwNzEzMDE0OCBTYWx0ZWRfX43d7QLE8fPi3 zhv3Zz9/HGflsMaoO067z5mvTuQw0khh5BIgUoW9Jt0yu2ZTdutBRythBdBVH1Z3rqyH38GeVqP n/W1VW9xGiJzwbArOKFJpCTknLiKjhI= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzEzMDE0OCBTYWx0ZWRfXxIRttI6sbL7b ignxajvNQRWzT3vbz+whUvPbasEmCSDCmb6gL3bjqnCg4SqmT3Ih5etzMWfHcWQOzT8wZ55L+Ql sSeYHJ3tTy/VPVyL65CBNhfNDxM+AlE32zoOrWVJcaIlTapI/omXAH7sJ3FTC1UBx/NFawQIjNd 20biXa6FtxjWBlKlPuPKdPbRlmy4Gpw8+3HK1Zzn43ZfXMcbQGfSKF7vdCe1A0i5VFWF/A9KeAu npFhkmncG8uwy7KBLNfzdCvOp1aYPwudHJjCXY4F7S64YFaYYxMYD4Rbmsmz0M3kXS+/8FOZh+5 eGem2GayzSsUkoqjxtfyOZdbjzT2qZzOcwmNpnjb2BDTCg4l5glgawg8L//+fK/x5mmsnkDJ8X5 eJXeXvxDT8ytu6tuhF4xn0diiCwzySz6ENn9AZ5GoZj1kJkKLjXMENpk0Np6xXung1NDWWufk7x kyydm6DZ5v4YloS/qcQ== X-Authority-Analysis: v=2.4 cv=XbS5Co55 c=1 sm=1 tr=0 ts=6a54f3b9 cx=c_pps a=5BHTudwdYE3Te8bg5FgnPg==:117 a=5BHTudwdYE3Te8bg5FgnPg==:17 a=RAioF0-LDSMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=iQ6ETzBq9ecOQQE5vZCe:22 a=VnNF1IyMAAAA:8 a=DuHJb5c9rUSq-GGRdagA:9 X-Proofpoint-ORIG-GUID: YKOXfjdNcAVcGH6vFzn23ijE2euu_JXk X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-13_03,2026-07-10_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 spamscore=0 phishscore=0 lowpriorityscore=0 priorityscore=1501 adultscore=0 malwarescore=0 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607130148 Detect PTE entries access in lazy MMU mode by means other than set_pte() and ptep_get() primitives, which would be a read hazard. The access to kasan shadow memory from ptep_get_lockless() mistakenly hits invalid access in case a concurrent lazy MMU access to the same PTE is happening. To avoid that disable instrumentation for ptep_get_lockless() altogether. Suggested-by: Ilya Leoshkevich Signed-off-by: Alexander Gordeev --- arch/s390/include/asm/pgtable.h | 6 ++++++ arch/s390/mm/lazy_mmu.c | 27 +++++++++++++++++++++++---- 2 files changed, 29 insertions(+), 4 deletions(-) diff --git a/arch/s390/include/asm/pgtable.h b/arch/s390/include/asm/pgta= ble.h index 9c8ff55cb535..19b5b4277efc 100644 --- a/arch/s390/include/asm/pgtable.h +++ b/arch/s390/include/asm/pgtable.h @@ -1049,6 +1049,12 @@ static inline void set_pte(pte_t *ptep, pte_t pte) __set_pte(ptep, pte); } =20 +#define ptep_get_lockless ptep_get_lockless +static inline __no_sanitize_address pte_t ptep_get_lockless(pte_t *ptep) +{ + return READ_ONCE(*ptep); +} + static inline pte_t __ptep_get(pte_t *ptep) { return READ_ONCE(*ptep); diff --git a/arch/s390/mm/lazy_mmu.c b/arch/s390/mm/lazy_mmu.c index d75b93d9b0de..ee2385897bc7 100644 --- a/arch/s390/mm/lazy_mmu.c +++ b/arch/s390/mm/lazy_mmu.c @@ -63,10 +63,13 @@ static int invalidate_pte_range(struct mm_struct *mm,= unsigned long addr, } =20 static void set_pte_range(struct mm_struct *mm, unsigned long addr, - pte_t *ptep, pte_t *end, pte_t *cache) + pte_t *start, pte_t *end, pte_t *cache) { - int i, nr_ptes; + int nr_ptes, nr_total =3D end - start; + pte_t *ptep =3D start; + int i; =20 + kasan_unpoison_pte(start, nr_total); while (ptep < end) { nr_ptes =3D invalidate_pte_range(mm, addr, ptep, end); =20 @@ -77,6 +80,7 @@ static void set_pte_range(struct mm_struct *mm, unsigne= d long addr, =20 addr +=3D nr_ptes * PAGE_SIZE; } + kasan_poison_pte(start, nr_total); } =20 static void enter_ipte_norange(void) @@ -94,6 +98,7 @@ static void enter_ipte_range(struct mm_struct *mm, unsigned long addr, unsigned long end, pte_t *pte) { struct ipte_range *range; + unsigned int nr_ptes; =20 if (!test_facility(13)) return; @@ -105,6 +110,9 @@ static void enter_ipte_range(struct mm_struct *mm, range->base_addr =3D addr; range->base_end =3D end; range->base_pte =3D pte; + + nr_ptes =3D (range->base_end - range->base_addr) / PAGE_SIZE; + kasan_poison_pte(range->base_pte, nr_ptes); } =20 static void leave_ipte_range(void) @@ -112,6 +120,7 @@ static void leave_ipte_range(void) pte_t *ptep, *start, *start_cache, *cache; unsigned long start_addr, addr; struct ipte_range *range; + unsigned int nr_ptes; int start_idx; =20 if (!test_facility(13)) @@ -148,6 +157,9 @@ static void leave_ipte_range(void) range->end_pte =3D NULL; =20 done: + nr_ptes =3D (range->base_end - range->base_addr) / PAGE_SIZE; + kasan_unpoison_pte(range->base_pte, nr_ptes); + range->mm =3D NULL; range->base_addr =3D 0; range->base_end =3D 0; @@ -227,10 +239,17 @@ static void __ipte_range_set_pte(struct ipte_range = *range, pte_t *ptep, pte_t pt static pte_t __ipte_range_ptep_get(struct ipte_range *range, pte_t *ptep= ) { unsigned int idx =3D ptep - range->base_pte; + pte_t pte; =20 lockdep_assert_preemption_disabled(); - if (pte_val(range->cache[idx]) =3D=3D PTE_POISON) - return __ptep_get(ptep); + if (pte_val(range->cache[idx]) =3D=3D PTE_POISON) { + kasan_unpoison_pte(ptep, 1); + pte =3D __ptep_get(ptep); + kasan_poison_pte(ptep, 1); + + return pte; + } + return range->cache[idx]; } =20 --=20 2.53.0