From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23F58230BE4 for ; Tue, 11 Mar 2025 09:54:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741686894; cv=none; b=mIUD7xhqvDRLV0FPAev47qE6YmMCFNB8BY6FdfgORqAmlWl2ZcEMtDvGaMgPM30EYGlNFlud3VII6rX7ANPM6iMEhmjMAFC6avuMfXjZkReM5zN6B24zYx/OtnxtGebitXx9FQBcOzi059rtSNps5qM95fclnWIyS3+z0lCLD50= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741686894; c=relaxed/simple; bh=zIMXX8m/RgonXr24DzqiYSlGa7YPlTxmBQW7NDrORqQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=aSIk7Ej4Ysv1/HhKUsGc/2NnADIvkR1bdRBrn+uf0deuNycJZgQ/SqK4F3DidmatV7ovr94yJmJAA0NXkBuAf/PvtZtCzMMDKR6WhRxadxHazxZdP5hB8X3qgY0R9fGknQ414S5a8QHkqKQw0F3qGeACY1YZ429TWt7kTfA5fmw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=VA6iOq6K; arc=none smtp.client-ip=209.85.208.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VA6iOq6K" Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-5e5491eb379so8855236a12.3 for ; Tue, 11 Mar 2025 02:54:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741686891; x=1742291691; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jm03UvuT8W5Rpxcu5rSdy8m6+zk+AKlN8ozqhEmUZCQ=; b=VA6iOq6KkVUEuTEI6l544PWha2pWoSFgIjGk4FxPJk9JViKnSF6UTh9fYr+xPESYI4 +TFbDpGQSsR7IKkOwHR0ZxTNMGNiFQslNRI0ec6/BQFO+j3KNu0gGJqD6L6d5vA2I2YK e3Ze+IpwqgXaf7Hej7TCkjjH6QGrz8n+41eTMgXmYTTtx/W26ihe2CZQEWFV6ZVJGKDg 15M2bTSV72R0JR/IrEcCEaCVkSg8JOdpsW5ejtIOfCzEgYDYvFAk6P++27rCV+Xy/bKc 1HguzxEGHSuWIIbaitULEWHqBau7B8jYrLi8mlRP+4vJma0PIsR3aFHNEEH/+ni5WsSs 81Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741686891; x=1742291691; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jm03UvuT8W5Rpxcu5rSdy8m6+zk+AKlN8ozqhEmUZCQ=; b=WtGx6YhjyPfs1yL4HCJmO2Agdjl0oDZnKtG2ZGB7WH6NMqV6W7bN5im+tGpSE4ya1c XMd+f/Cd2d5oZz3kATwxcX3AEzErRO7aQ00eCPvifFwNFjRcs5+o5YKPwisrERdVBp03 PO4TLPpFkXRK/FFMHvPJ8WJMspuJzlQtMgLo18BiK7af9KYJjLIhr7PzvmMVfLIihQ9U vcHIdOGUqKYwRYSGUjDIuejGHlqNsFELVE0iD4GXIj2Qmmy+bSXB6FAH/pnAhca/5iLv 0iVS2oDnywGDJVxIuIH3kZ1rpCp2yQ25bWQ+wdcwUPI7GjuomaiPYgBPKA+ZiJP9bdmu neHw== X-Forwarded-Encrypted: i=1; AJvYcCWHS1Ox66aoM/YpGHQsCFIJjwaIJXYbvWO4/qramK9w9N2YYxxMlxrFcIhDMiLft01CNw07h/cYgu4MamE=@vger.kernel.org X-Gm-Message-State: AOJu0YzRF3Tkvab5DG/3mkbXJXWzJiUL/+wSmA5meJOf2XOtbd98YV6T 64U0cngVjL/g/BvD1ddFDiecYpuxQdKUciPYAkgjNdgwI78/lMJIQlnal+8HVdE= X-Gm-Gg: ASbGncsOzm9RcxxSyqiamde0e6XwBPu2X8QHfCUIaCzO4tNL9aelEdMslXiJHPlRZbf afYcchcpLqONCoscyRlU39A/EufD4hnxZdNDtlUQcjjIwsbphrYamIALYOVI4R3Nv4XZb1zxVGm ACXY8dFaUQherOd/MImqEUJ35ybrKvQBQCuJFmz5GFjdKTUfD/N5mXoD4CUaONWG1M1v7yMNZX+ R2MIrr4DZJaLKl/LUALd21+CF3CjmcKKNVSB+SedVlq8Du0JA21r2bV3jobpOkrrEqWyi7a40cW uIMEhOhf5GMCycHWttRExPluMjPyC19bsnpXGj8Yo62KpUz9W8J7EAFWqDCNZHj2ClY2hF9ljMY 8WFc520JhHQ== X-Google-Smtp-Source: AGHT+IGKxxOWPNeiHoUYs+NA4pDEtcYz0NGKwKD5GEdsLIcqat9tyNzB39oWArbJ16F0FMw7l3A1xw== X-Received: by 2002:a05:6402:43cd:b0:5e0:4276:c39e with SMTP id 4fb4d7f45d1cf-5e5e251190cmr21540775a12.30.1741686891372; Tue, 11 Mar 2025 02:54:51 -0700 (PDT) Received: from [192.168.0.35] (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e5c7472128sm8062047a12.23.2025.03.11.02.54.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Mar 2025 02:54:51 -0700 (PDT) Message-ID: <7a5518ad-b470-4c5b-99f0-9b4952d332ba@linaro.org> Date: Tue, 11 Mar 2025 09:54:49 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/8] clk: qcom: videocc-sm8450: Move PLL & clk configuration to really probe To: Jagadeesh Kona , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio Cc: Ajit Pandey , Imran Shaik , Taniya Das , Satya Priya Kakitapalli , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250306-videocc-pll-multi-pd-voting-v2-0-0cd00612bc0e@quicinc.com> <20250306-videocc-pll-multi-pd-voting-v2-4-0cd00612bc0e@quicinc.com> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20250306-videocc-pll-multi-pd-voting-v2-4-0cd00612bc0e@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 06/03/2025 08:55, Jagadeesh Kona wrote: > + > +static struct qcom_clk_cfg video_cc_sm8450_clocks_cfg[] = { > + { .offset = 0x80e4, .mask = BIT(0) }, /* VIDEO_CC_AHB_CLK */ > + { .offset = 0x8114, .mask = BIT(0) }, /* VIDEO_CC_XO_CLK */ > + { .offset = 0x8130, .mask = BIT(0) }, /* VIDEO_CC_SLEEP_CLK */ > +}; > > - /* Keep some clocks always-on */ > - qcom_branch_set_clk_en(regmap, 0x80e4); /* VIDEO_CC_AHB_CLK */ > - qcom_branch_set_clk_en(regmap, 0x8130); /* VIDEO_CC_SLEEP_CLK */ > - qcom_branch_set_clk_en(regmap, 0x8114); /* VIDEO_CC_XO_CLK */ Dmitry already said this but, this change feels like a loss of fidelity. Please find a way to use the existing helper functions. --- bod