From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from MW6PR02CU001.outbound.protection.outlook.com (mail-westus2azon11012002.outbound.protection.outlook.com [52.101.48.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DCFE03A6F00 for ; Tue, 2 Jun 2026 06:33:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.48.2 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780382009; cv=fail; b=a7gKpVufzw8HO68Bq4sydgmzj3e51RFuWXCQUAT45PXyllkCr9hhTX99LO6xnxdBikUDsKN/8omsBnJwbQrfYkKiPm+u4gYlHbjVumkXOmgxcLWcRM0btoBmJIBdBMJw1khdTDIz2hWqtU5AtdsMW0E+om1rc6IBSPSQXTixc0E= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780382009; c=relaxed/simple; bh=c20MCrx8ceflePo7oky6LEpIKtBerbzSSe8ESwV3NMc=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=A43o+Cg+d/kspPZ7dlMovukmk1Evmp4PwjBlhIcX+MTu1nyWqNiGB5kxCzACQgtgpmNp03NP7EHp7YoVHFHemKZrL5Qnv4woQxE6dBCjXGTe+1TjDRSqctHTBPl7xM0zkZHqokdtnqUTMrmpXzV6FVkEQRlYow8gGJJhrnVmSps= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=C+Fqb7hc; arc=fail smtp.client-ip=52.101.48.2 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="C+Fqb7hc" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=d3NYU7kj4p6fJJeohwQCLJmd8P4ksboTQr7eyw469Moijuz31YIrPZwyLXfGZB13pXTFOVt2J13w3hL5AjglY362Mj0DgFoBRnrZBd5hWy8q1tMDoje6QsOQ/INNxuMhdp9DJQs/7F4VYiUtnvWCSdYfYq+pftmVYfzX3NWbUyqlZtHtiFXwjrAT4kUBNLKCGXrlruTrslfA5dLlNVtpWjLOEJHQoGb5y0hUdUQi9KGLmaV9OZlqBE3KQkVFf3k7QIEUsJ6obh8f6rf/oRYICuzn1gmt+LCkoaMfIX+xpuZaJ1g0nTtkCStExerOdHQje38j2kj28UaDoJxcteolLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DMg7+ibW/okifQPM2XPpwrnGsoXieVUXAzaLOjoP/WY=; b=ST9LDeLBTONLlE2szBRbVrLw5qeNw9VJrdKbE+moUq3Nu+LhU8GG+f58oEIHHeTqdSzVBnIiw6sl7/K0iv/UaDsN5pJ+L9OR+sOb4ojXFBBnmJQXQL5hYq10pxMImp5G3G78I0J/cO4SFNm179hKHvBj1uJWToWcVAI36knDOrNMAPmcKt03uiB34yjtKs4RuHbK+qAYZD5J643dXmYDQ713bibDVyfBM8on81da3wa6QHKllwkvM6mr3xrH1C7ywCPgheuFeCqjdMtLt4wwgqmfW3sweErmaov79u153U4SXut7W52b4/b+aEoCYOoRq/mW04iZQAwFRwU+e3WXXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=infradead.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DMg7+ibW/okifQPM2XPpwrnGsoXieVUXAzaLOjoP/WY=; b=C+Fqb7hcH3VLFtx5hE52O8LJbXYwGcKsghFVviuuk21e8hDQ3xfdz9xzkyaGc+u/gq6/qIUbaIbO9l6F9+mp2fXugvVLUs/5lRajiRmXtQzxpSWPcTiQZEGlffCfTq8LxJF+ZSTvyWUST61eQsC/wG1M7Iwum0mzFjuzLpP6e8c= Received: from CYXPR03CA0011.namprd03.prod.outlook.com (2603:10b6:930:d0::19) by IA0PR12MB8745.namprd12.prod.outlook.com (2603:10b6:208:48d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.71.15; Tue, 2 Jun 2026 06:33:24 +0000 Received: from CH3PEPF00000014.namprd21.prod.outlook.com (2603:10b6:930:d0:cafe::36) by CYXPR03CA0011.outlook.office365.com (2603:10b6:930:d0::19) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.92.7 via Frontend Transport; Tue, 2 Jun 2026 06:33:23 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by CH3PEPF00000014.mail.protection.outlook.com (10.167.244.119) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.0 via Frontend Transport; Tue, 2 Jun 2026 06:33:21 +0000 Received: from Satlexmb09.amd.com (10.181.42.218) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Tue, 2 Jun 2026 01:33:21 -0500 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb09.amd.com (10.181.42.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Mon, 1 Jun 2026 23:33:21 -0700 Received: from [10.136.34.155] (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Tue, 2 Jun 2026 01:33:18 -0500 Message-ID: <7a5e0d46-4e64-4bbb-bcb9-92aa768d7b79@amd.com> Date: Tue, 2 Jun 2026 12:03:17 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/5] sched/fair: Call update_curr() before unthrottling the hierarchy To: Peter Zijlstra CC: Aaron Lu , Ingo Molnar , "Juri Lelli" , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Josh Don , References: <20260528094830.13291-1-kprateek.nayak@amd.com> <20260528094830.13291-4-kprateek.nayak@amd.com> <20260601035201.GA690044@bytedance.com> <20260601112752.GR3493090@noisy.programming.kicks-ass.net> Content-Language: en-US From: K Prateek Nayak In-Reply-To: <20260601112752.GR3493090@noisy.programming.kicks-ass.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF00000014:EE_|IA0PR12MB8745:EE_ X-MS-Office365-Filtering-Correlation-Id: 53dae8c0-30b8-45f6-b925-08dec070d7a2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|7416014|82310400026|36860700016|11063799006|4143699003|18002099003|22082099003|13003099007|56012099006; X-Microsoft-Antispam-Message-Info: Kb1q+jH0pFTrA2yZRlSCIodjZenCNCfGaG07TRARqO0JfFPrGo9oFkf+EqlwPmxAxL927rROUIlbRaNp7zuDpDczBSzchKjxlPac4sz8Qhnx8NNRXpHDwnBVDEZCefDh+W5wRhnruCp4TRf/67aqaJFMGv/1REfc5jNMwsuTfcA67Fn+XaG7dIXPmyc7dnf9bibjvyhQlgR99iOyn8b6jIEUwEP2ZKhcC77FbanaS5LXzgPbNA2HzGkiftlWjWfNw7Kq1G5XcbjTM/kHipVJQqrBOoNDd/NEoYhcP1LmDI5dnIpMHWiASo7qJE2IKSpcgYm9WKIh4bAOURy/VBSLw7ICV1jtjzqwLZ5XcDDcADBHV4CHmNSB3wNPAsOZY8iudqKGy7WMPIYDA4oKH22dh3YF+y8n4IgAWV7+0nz+sxtT0RwMIbnH8MRk0fm0wUBJQCNS3rfBfniIYmzY6eea99ja1cJ6uCbuB9F99NsinZ5wLln8J6ppYBfJiobhA+4J9/oTURqL9bwGuZK21b16tWsOYFF3bCmb9j/LzNQkXAqfHra2yFQiAPpdI+JUnOUjU9VPoPOFJCmcyHCNqv0cjKRgduqB3O0sYuJzUTDRZSjue+9kB1kV7eZBo7zrXVfItUsN8IWNDvq+Vg0r1n/z+A+08pjp0ot5H63tpBb5uMaFd+kGXODac1hPRZ8Fd3xXyeO9iD/s32jA8FDeSH3NX9og7kTp1Dgx1Hj9Jfh6tkQ= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(376014)(7416014)(82310400026)(36860700016)(11063799006)(4143699003)(18002099003)(22082099003)(13003099007)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: LABvYrD9cG1Dz4xeUNbZqKck7qqk39V6CF60OYkbXXYxHsXISnFeb3R7UJ7H1HOKDpX933IzFHGEvtg4xZq3G+QDydPtvH94vd7uPjoGBCBqkazzFZG/bBHXeYfLzcnARrKYZ1TUCyOtB7paU5g5Xbn0YCabXCVgE6ExadfMkEKjj14f+YjJnO9YmCXZQyD36U1RpbVBLzBNe8opwNCuBr08VoElckL+Gf30/1Qxta9zkyBp0thM7VFjqztjN0yuBn9vleMvLOxvxIOhEPzgAwpTi+zjDDUIjoubDF+3ycwVprnkorqYKN56+kj8BEs9WX9wez3KIgPSJaBlKELyZI/Mf3LRQ2g8fpDeXnCKgjd4EImVOGDAuseKsYftxz04307qVtwfl0a9WrSnHnZWUPks5xtxu6GtJH5MvQ3PRcP65eGjXQAyhRTS+1XHeH0q X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jun 2026 06:33:21.9512 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 53dae8c0-30b8-45f6-b925-08dec070d7a2 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF00000014.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8745 On 6/1/2026 4:57 PM, Peter Zijlstra wrote: > Like this? > > --- a/kernel/sched/core.c > +++ b/kernel/sched/core.c > @@ -9830,6 +9830,7 @@ static int tg_set_cfs_bandwidth(struct t > struct rq *rq = cfs_rq->rq; > > guard(rq_lock_irq)(rq); > + update_rq_clock(); Except that needs an rq as an argument ;-) I've send out a v2 here for convenience: https://lore.kernel.org/lkml/20260602050005.11160-1-kprateek.nayak@amd.com/ It addresses the comments from Ben, and I've move the update_rq_clock() just before the unthrottle to avoid doing it unnecessarily in case the cfs_rq is not throttled yet. -- Thanks and Regards, Prateek