From: Andrew Lunn <andrew@lunn.ch>
To: Thangaraj Samynathan <thangaraj.s@microchip.com>
Cc: bryan.whitehead@microchip.com, UNGLinuxDriver@microchip.com,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 net 2/2] net: lan743x: Fix PHY reset handling during initialization and WOL
Date: Fri, 23 May 2025 18:25:39 +0200 [thread overview]
Message-ID: <7a6b4862-df38-4b9e-9add-beaeebbbefc0@lunn.ch> (raw)
In-Reply-To: <20250523054325.88863-3-thangaraj.s@microchip.com>
On Fri, May 23, 2025 at 11:13:25AM +0530, Thangaraj Samynathan wrote:
> Remove lan743x_phy_init from lan743x_hardware_init as it resets the PHY
> registers, causing WOL to fail on subsequent attempts. Add a call to
> lan743x_hw_reset_phy in the probe function to ensure the PHY is reset
> during device initialization.
>
> Fixes: 23f0703c125be ("lan743x: Add main source files for new lan743x driver")
> Signed-off-by: Thangaraj Samynathan <thangaraj.s@microchip.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
prev parent reply other threads:[~2025-05-23 16:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-23 5:43 [PATCH v1 net 0/2] Refactor PHY reset handling and Thangaraj Samynathan
2025-05-23 5:43 ` [PATCH v1 net 1/2] net: lan743x: rename lan743x_reset_phy to lan743x_hw_reset_phy Thangaraj Samynathan
2025-05-23 16:24 ` Andrew Lunn
2025-05-26 5:29 ` Thangaraj.S
2025-05-23 5:43 ` [PATCH v1 net 2/2] net: lan743x: Fix PHY reset handling during initialization and WOL Thangaraj Samynathan
2025-05-23 16:25 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a6b4862-df38-4b9e-9add-beaeebbbefc0@lunn.ch \
--to=andrew@lunn.ch \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew+netdev@lunn.ch \
--cc=bryan.whitehead@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=thangaraj.s@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®