From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78838C432BE for ; Mon, 30 Aug 2021 04:18:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 650C360F8F for ; Mon, 30 Aug 2021 04:18:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231984AbhH3ETc (ORCPT ); Mon, 30 Aug 2021 00:19:32 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:18270 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231896AbhH3ETZ (ORCPT ); Mon, 30 Aug 2021 00:19:25 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1630297110; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=1o0FmZbIKug3vf0o+NtUykmzlIUNMLcvxSthEnoYj3U=; b=Lng2sY1dApkr6QXH59Ly7pEd0pz2EhZUnYOxNn62+0Tswg7mWeeCzjImtIEKEnhQ08sava88 oJFNzMqF775ww8PH97P9QRx4R8JNSmJq5mABHY20/yv3TA34vzf9nKjoVuBUg9FIB/0UJqzz AIV+IDIHQZayvdCMs0+XwRkIMew= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-east-1.postgun.com with SMTP id 612c5c13cd680e8969fc1e83 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 30 Aug 2021 04:18:27 GMT Sender: sanm=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 51511C43635; Mon, 30 Aug 2021 04:18:26 +0000 (UTC) Received: from [192.168.0.104] (unknown [124.123.190.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: sanm) by smtp.codeaurora.org (Postfix) with ESMTPSA id 1289BC4338F; Mon, 30 Aug 2021 04:18:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 1289BC4338F Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=codeaurora.org Subject: Re: Regarding usb dwc3 core shutdown callback To: Felipe Balbi Cc: Greg Kroah-Hartman , Mathias Nyman , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Pratham Pratap , Jack Pham , Stephen Boyd , Matthias Kaehlcke , Doug Anderson References: <87bl63yqq8.fsf@kernel.org> <87eeaga39m.fsf@kernel.org> From: Sandeep Maheswaram Message-ID: <7a6bf94b-91cd-15d5-dd9c-798e7a927727@codeaurora.org> Date: Mon, 30 Aug 2021 09:48:16 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <87eeaga39m.fsf@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 8/26/2021 4:13 PM, Felipe Balbi wrote: > Hi, > > Sandeep Maheswaram writes: >>> (why isn't this email plain/text? Content Type was set to multipart >>> alternative, please configure your email client correctly :-) >>> >>> While at that, also make sure to break lines at 80-columns) >>> >>> Sandeep Maheswaram writes: >>>> Hi, >>>> >>>> Earlier I have posted the patch for usb dwc3 core shutdown callback >>>> >>>> https://lore.kernel.org/linux-arm-msm/1618380209-20114-1-git-send-email-sanm@codeaurora.org/ >>>> >>>> and it was reverted due to issues. >>> Right, as should be expected when we find regressions >>> >>>> https://lore.kernel.org/linux-usb/20210603151742.298243-1-alexandru.elisei@arm.com/ >>>> >>>> As we already have shutdown callback in xhci plat driver where we halt >>>> the controller, so there will be no transactions with usb devices. >>>> >>>> https://lore.kernel.org/linux-usb/20200306092328.41253-1-ran.wang_1@nxp.com/ >>>> >>>> So I think dwc3 core shutdown may not be required at least when we are >>>> using host mode. Let me know your opinion about this. >>> If that's the case, then sure. Please validate the condition, though, >>> and kindly report back on your findings >> I have enabled couple of logs in shutdown path and see no URBs >> enqueued after xhci shut down. >> >> Hope this is enough for validation . Please suggest if anything more I >> could do. > how about writing a little script to kexec into another kernel for a few > hundred iterations and make sure things still work after all that? Currently kexec is not supported on qcom devices.  Anything we can do apart from kexec?