Re: [PATCH] drm/draw: fix color truncation in drm_draw_fill24

[Jocelyn Falempe <jfalempe@redhat.com>]

On 10/3/25 16:41, Francesco Valla wrote:
> Hi Jocelyn,
> 
> On Friday, 3 October 2025 at 14:48:03 Jocelyn Falempe <jfalempe@redhat.com> wrote:
>> On 10/3/25 12:33, Francesco Valla wrote:
>>> The color parameter passed to drm_draw_fill24() was truncated to 16
>>> bits, leading to an incorrect color drawn to the target iosys_map.
>>> Fix this behavior, widening the parameter to 32 bits.
>>>
>> Oh, you're right, my mistake.
>> Did you find this by using a 24bit hardware, or by looking at the code?
>>
>> Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com>
>>
>> Best regards,
>>
> 
> I am working on a graphical splash DRM client (which I hope I'll be
> able to post soon) and testing it on a Beagleplay - which is
> RG24-capable - I started to see a strange behavior with non-black
> colors. After some investigation I found the cuplrit, and strangely
> enough it wasn't me this time.

Thanks, I was wondering if this 24bit code would see a real usage, so it 
looks like this is still a thing in 2025.

Best regards,

-- 

Jocelyn

> 
> Best regards,
> 
> Francesco
> 
> 
> 
> 
> 
>