From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A1AC3E7BDE for ; Fri, 22 May 2026 11:47:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779450434; cv=none; b=gWQeIAiBS7jPFIvHNVaYX8r+7AkDOa+LKpe8lOLTgL2Y7SHZJaFg8Skv/6pURxuL4gRYrFnOp5n3XFEu3uJBPHgnDoOjI0zuMowYGyZqHulwglc9GmP+DL1cBKchzm0MBM/WoEybPw8FZhH/6LHa7mGqBuENCLMX9VD1ToODUls= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779450434; c=relaxed/simple; bh=D1P+fFKB25lhSK1Xq9tBSMb24ACgdSEHpQI2Sd6qIgs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DaEm8E7ZfFgY5J+0QszxVI5TZv/kVJqUp1sJ7DP+EzCt+pBf/TAJp8b2VOs9V2yOF1eB+jzGGUYUXAJdLRt+L/3tjSR51iBhf28Vo1E/qBgJQVAFhcU/pE6biKOigjgnReqoySXzLDuHZWF/ktso1Yzy7c6MpL++5nadGpvsNm0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IzzeeHSC; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=i+aB7/+i; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IzzeeHSC"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="i+aB7/+i" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64M76Hrc1297965 for ; Fri, 22 May 2026 11:47:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 9Vtic2scv0lNArrUhQhjpK+aneD52xMJ//xMO3IOSEU=; b=IzzeeHSC4ZyDPsaj v9yxiHOQXtKDaeU8EEnfLF1qlMN6hs2RK/7Fq8z0WhxYLDqKbGXd2UOmlmdwQat0 Cl08ME+g17i5H7r4oemJsDm4MCtBQ0/IIFL9556mbLb9HuZD6B8LGUIX6CuNGel8 Fpp/PBp0YeRKPBNeeMxKMaP1VpAfMUwRkoI18OcHFCTP8fM0Rq9O0cGOtvRMCzCh 9B5NtATkkxxzhQgr3QD2dFSgcB75ttmSRyMKM9mo10G7GpcBQ21l9ratiBcEzYY8 EDirxcr7zzYC5NSlOUsU3yca0zWcYzD+tn+7sljQ0v/qqh5LjwzbLDKr0jJzEhxs f00pjw== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eaah0as47-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 22 May 2026 11:47:09 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-8aca4966fe6so20121556d6.2 for ; Fri, 22 May 2026 04:47:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779450429; x=1780055229; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9Vtic2scv0lNArrUhQhjpK+aneD52xMJ//xMO3IOSEU=; b=i+aB7/+ikz0xTqmQZ5VE6ZAPsuC7GMayWnKwgGVFiS3/Gv7TxHbP0mEup4Ndr+fyRK tWEZr4APlgIe6xarzM4s9RTVC98kQ/BIwfgBJs2txLhRScPliQ2x3FKlvbjq+Peb7BFK mFtr58kGHrTk5u0BpmiX0f5NTlzUlKFu5fe2uHNWz0jwtAuWYGEdhNb9BobL1+DdajS5 4aX1bAO0OUh8eGLlyAv7OrU0ftRXgAt6kHE1+Eo20Svn9i2g7t6pkNSAfqp66a3Dpblj Bkf8BqTYPVf+jdc4EnpTVbQRhJAnwyn3brH+h+WXQpVAyx3wba34oYyaFou5GRxF4muV U75g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779450429; x=1780055229; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9Vtic2scv0lNArrUhQhjpK+aneD52xMJ//xMO3IOSEU=; b=smZ7iACMmeoXfjHkCbYeRK45L+5IWJ8hgrQHnzns7Gea/oiEpXPbUsNYWLZdDDx4F4 iHV1C+Z9bKNUpv35i5LE5e6EsasknmU9UMWHNw/qwk6dsIXj7yFUhUq6e/6EMTxWShcR 4FKaI7Ui4Oil4hD4NaEQsDlFD3E2w/7Pz72F7Ek4qY4iTksleTdTDW+iFWh41KctuI5Q myUQjHi0ogA2+jR+VUhTf2BKjWn7dNHcrlhZDXGZxdtfyVLFhPjX/T6YDRB7/xGrnTIs dnFxnbRflsmhZlrK1Ntj8zPepPPIkPzbcM4hfCf5ehrJGLVSRUlLf/GkRprFzBZulmQg j8KA== X-Forwarded-Encrypted: i=1; AFNElJ9+plJHeHYPX1zxiMSPxlSbLD69K5fdpWxPL0kIJT5g6Bw6gn6w/CbYMvvLV0VDpuS3DchUGfCu86dU5QY=@vger.kernel.org X-Gm-Message-State: AOJu0YybpuNdRXPvHKJ6YU4pZ/OwD28XncMmTEZFS3G+k/LlWUPmLbhM jSArUHV4rT6u0eaCceZWNvxtFM02LMg9mhi/HWwO4E6JgTfXb7JZ8tDKva5RfyXt4NGNx9r4i0+ RT1yoy9UI+iXt1xW0eLQZS0GuQLuhIVHNupBNNZTx/1KZ0QZZtwdr+wSU/QlXKP0Qnck= X-Gm-Gg: Acq92OGpembAdb0pFFrl3HTuxiOmXdyjqWUXPrgNekgJUspgWESksffrrPbe7U2IuX7 VLfus60RwZoCudGkXnGKhxe4+Wf54rSt9IBV/HGqiKWsrqEWCZUOa68jF8GYsGvot/V21/H/+ip ABRvCxxFQ53i06qXOfJgD2z4apxKrCDox2C3ZfvTtDyrhkYcBzr40AK6JpsiTJNTjGN7/tTdQ+f 1qEcmMtB5upJCcEAwJsyrVAZpLTlr48PE8uC1qZa/dga7rB3ZXEhijVnp+ximR2PN767rmwdVFT Y/R7i4n6Hur/Xj+Io2SJqPbFUGlQl5fEHRaKeWmUW6YnHWly74roAOGlUgviW7Zo9aM/ke2I/FQ T5paV3MnDYGOxvW7IutXZigJEicAAEWk18jObhtnsRoYY7Q== X-Received: by 2002:a05:622a:8313:b0:509:d76:fe73 with SMTP id d75a77b69052e-516d436867emr24779101cf.3.1779450428496; Fri, 22 May 2026 04:47:08 -0700 (PDT) X-Received: by 2002:a05:622a:8313:b0:509:d76:fe73 with SMTP id d75a77b69052e-516d436867emr24778751cf.3.1779450428043; Fri, 22 May 2026 04:47:08 -0700 (PDT) Received: from [192.168.119.254] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bddc30528a7sm47004366b.21.2026.05.22.04.47.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 May 2026 04:47:07 -0700 (PDT) Message-ID: <7a74f989-1235-41b4-90b7-aad1c68e9b37@oss.qualcomm.com> Date: Fri, 22 May 2026 13:47:04 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 09/10] drm/msm/dp: turn link_ready into plugged To: Dmitry Baryshkov , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Kuogee Hsieh , Yongxing Mou Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260314-hpd-refactor-v5-0-0c8450737d64@oss.qualcomm.com> <20260314-hpd-refactor-v5-9-0c8450737d64@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260314-hpd-refactor-v5-9-0c8450737d64@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIyMDExNyBTYWx0ZWRfXxd58Qs50OCwu zWkWV0AU/FANVPrgNj6snKMcZ3EPXdVUEW4Bbf7wBm0zJoEZA6XXJ/Th62VtqAVWvIZHQGmQdef YpKdlxwyUh0H0SVWGs2Fn7LZLRLiyCkuTQ+OTLtHtZe8iAmm+WFXfOrpCfsGwp7VPnttFR0GZ/r fB4VkKzCUXCENj8QcWNcxXLoQJOMjhmkzfEPH9M750cGooKiAaE5vEqeL7PdSnws+En1iFOsrp5 oOw6yYYQ1LnzkvzRj3RT34Sac9SirMBLX3Xh2KjDn+8eJud+HhamPklYbOyKIl379Ntbh6NPkOX umVP+3uN2hC+ASuRu1RGAq0F8CsYGbmS7179DOTdD4Qt9tsYmAoYXyRJjGYjPv0kyj5iQwnhQV4 8Z20eZovpjgOOGkT+dPjj+5vTtdolmnMN6lzt8/ppxSi8efuWIA8e9Sm3ed7S3t0lMv1CyLAmRt wBZod/XDE5buTYJoGZA== X-Proofpoint-GUID: FYytVqqw-OOLO4fRRG2rqSJoxQKVv35a X-Authority-Analysis: v=2.4 cv=LNdWhpW9 c=1 sm=1 tr=0 ts=6a10423d cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=pcg_VVX8d75-tFNqbqgA:9 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 X-Proofpoint-ORIG-GUID: FYytVqqw-OOLO4fRRG2rqSJoxQKVv35a X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-22_03,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 malwarescore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 impostorscore=0 phishscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605220117 On 3/14/26 2:09 AM, Dmitry Baryshkov wrote: > Tracking when the DP link is ready isn't that useful from the driver > point of view. It doesn't provide a direct information if the device > should be suspended, etc. Replace it with the 'plugged' boolean, which > is set when the driver knows that there is DPRX plugged. > > Signed-off-by: Dmitry Baryshkov > --- [...] > -static void msm_dp_display_host_phy_init(struct msm_dp_display_private *dp) > +static bool msm_dp_display_host_phy_init(struct msm_dp_display_private *dp) > { > drm_dbg_dp(dp->drm_dev, "type=%d core_init=%d phy_init=%d\n", > dp->msm_dp_display.connector_type, dp->core_initialized, > @@ -312,7 +313,10 @@ static void msm_dp_display_host_phy_init(struct msm_dp_display_private *dp) > if (!dp->phy_initialized) { > msm_dp_ctrl_phy_init(dp->ctrl); > dp->phy_initialized = true; > + return true; > } > + > + return false; > } Please either rename this function or add kerneldoc - it's not obvious what "msm_dp_display_host_phy_init() == true" is supposed to mean > > static void msm_dp_display_host_phy_exit(struct msm_dp_display_private *dp) > @@ -366,14 +370,6 @@ static int msm_dp_display_handle_irq_hpd(struct msm_dp_display_private *dp) > u32 sink_request = dp->link->sink_request; > > drm_dbg_dp(dp->drm_dev, "%d\n", sink_request); > - if (!dp->msm_dp_display.link_ready) { > - if (sink_request & DP_LINK_STATUS_UPDATED) { > - drm_dbg_dp(dp->drm_dev, "Disconnected sink_request: %d\n", > - sink_request); > - DRM_ERROR("Disconnected, no DP_LINK_STATUS_UPDATED\n"); > - return -EINVAL; > - } > - } > > msm_dp_ctrl_handle_sink_request(dp->ctrl); > > @@ -392,11 +388,11 @@ static int msm_dp_hpd_plug_handle(struct msm_dp_display_private *dp) > dp->msm_dp_display.connector_type, > dp->link->sink_count); > > - if (dp->msm_dp_display.link_ready) > - return 0; > + mutex_lock(&dp->plugged_lock); guard(mutex)(&dp->plugged_lock) [...] > static void msm_dp_display_handle_plugged_change(struct msm_dp *msm_dp_display, > @@ -446,8 +440,12 @@ static int msm_dp_hpd_unplug_handle(struct msm_dp_display_private *dp) > dp->msm_dp_display.connector_type, > dp->link->sink_count); > > - if (!dp->msm_dp_display.link_ready) > + mutex_lock(&dp->plugged_lock); likewise [...] > end: > - pm_runtime_put_sync(&dp->pdev->dev); > + /* > + * If we detected the DPRX, leave the controller on so that it doesn't > + * loose the state. loose -> lose > + */ > + if (!priv->plugged) { > + if (phy_deinit) { > + msm_dp_aux_enable_xfers(priv->aux, false); > + msm_dp_display_host_phy_exit(priv); Should msm_dp_aux_enable_xfers() logically be called anywhere outside phy_init/exit()? > + } > + > + pm_runtime_put_sync(&dp->pdev->dev); > + } > + > + mutex_unlock(&priv->plugged_lock); > + > return status; > } > > @@ -1123,6 +1145,8 @@ static int msm_dp_display_probe(struct platform_device *pdev) > (dp->msm_dp_display.connector_type == DRM_MODE_CONNECTOR_eDP); > dp->hpd_isr_status = 0; > > + mutex_init(&dp->plugged_lock); devm/drmm? Konrad