From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9C7BC388F7 for ; Wed, 11 Nov 2020 02:32:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6214D21D91 for ; Wed, 11 Nov 2020 02:32:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727836AbgKKCcH (ORCPT ); Tue, 10 Nov 2020 21:32:07 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:7478 "EHLO szxga06-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725882AbgKKCcG (ORCPT ); Tue, 10 Nov 2020 21:32:06 -0500 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4CW7zL5gNwzhj1j; Wed, 11 Nov 2020 10:31:58 +0800 (CST) Received: from [127.0.0.1] (10.74.149.191) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.487.0; Wed, 11 Nov 2020 10:31:56 +0800 Subject: Re: [PATCH V2 net-next 05/11] net: hns3: add support for dynamic interrupt moderation To: Jakub Kicinski CC: , , , , , References: <1604892159-19990-1-git-send-email-tanhuazhong@huawei.com> <1604892159-19990-6-git-send-email-tanhuazhong@huawei.com> <20201110172055.27ab308f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> From: tanhuazhong Message-ID: <7a7805e0-7d13-2b34-f15c-1fc7bda151ed@huawei.com> Date: Wed, 11 Nov 2020 10:31:55 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20201110172055.27ab308f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.74.149.191] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/11/11 9:20, Jakub Kicinski wrote: > On Mon, 9 Nov 2020 11:22:33 +0800 Huazhong Tan wrote: >> Add dynamic interrupt moderation support for the HNS3 driver. >> >> Signed-off-by: Huazhong Tan > > I'm slightly confused here. What does the adaptive moderation do in > your driver/device if you still need DIM on top of it? > The driver's adaptive moderation and DIM are mutually-exclusive options, and DIM is used by default. Since it is hard to verify all cases that DIM can get a better result, so keep the adaptive moderation as an option now, which can be swicthed by the ethtool priv-flag. If DIM is ok for a long time, then we will send a separate patch to remove the adaptive moderation from the driver. Thanks. >