From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AC59ECAAD3 for ; Wed, 31 Aug 2022 06:09:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230045AbiHaGJO (ORCPT ); Wed, 31 Aug 2022 02:09:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229827AbiHaGJM (ORCPT ); Wed, 31 Aug 2022 02:09:12 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66A23BC12D for ; Tue, 30 Aug 2022 23:09:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661926150; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oR8XteXHX+4ai/3j0vU7EYXedgFBG0vhXvlh6RDFvTg=; b=KXVAgjkKFUlvsEE9iMqbG99wdyFgMj0PsnKvtFqjwSH63vt+DhbQOT93teTGP6y+fF4wz2 P4AKl1/gdKMcnm4EH2Men6ypU0E1ouDzGJVGyV53kLXi5y5y9Hi6tUDiaBrBpoSBv7sPQE ztspOl5DfFV5Qwsko+Dr+77nFX+6Tis= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-618-bfFlUR7aPrmA_9wacOzrOQ-1; Wed, 31 Aug 2022 02:09:09 -0400 X-MC-Unique: bfFlUR7aPrmA_9wacOzrOQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EB45285A585; Wed, 31 Aug 2022 06:09:08 +0000 (UTC) Received: from starship (unknown [10.40.194.96]) by smtp.corp.redhat.com (Postfix) with ESMTP id 54D92141511A; Wed, 31 Aug 2022 06:09:07 +0000 (UTC) Message-ID: <7a7827ec2652a8409fccfe070659497df229211b.camel@redhat.com> Subject: Re: [PATCH 06/19] KVM: SVM: Get x2APIC logical dest bitmap from ICRH[15:0], not ICHR[31:16] From: Maxim Levitsky To: Sean Christopherson , Paolo Bonzini Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Suravee Suthikulpanit , Li RongQing Date: Wed, 31 Aug 2022 09:09:06 +0300 In-Reply-To: <20220831003506.4117148-7-seanjc@google.com> References: <20220831003506.4117148-1-seanjc@google.com> <20220831003506.4117148-7-seanjc@google.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-2.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2022-08-31 at 00:34 +0000, Sean Christopherson wrote: > When attempting a fast kick for x2AVIC, get the destination bitmap from > ICR[15:0], not ICHR[31:16]. The upper 16 bits contain the cluster, the > lower 16 bits hold the bitmap. > > Fixes: 603ccef42ce9 ("KVM: x86: SVM: fix avic_kick_target_vcpus_fast") > Cc: Maxim Levitsky > Signed-off-by: Sean Christopherson > --- > arch/x86/kvm/svm/avic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kvm/svm/avic.c b/arch/x86/kvm/svm/avic.c > index 3ace0f2f52f0..3c333cd2e752 100644 > --- a/arch/x86/kvm/svm/avic.c > +++ b/arch/x86/kvm/svm/avic.c > @@ -368,7 +368,7 @@ static int avic_kick_target_vcpus_fast(struct kvm *kvm, struct kvm_lapic *source > > if (apic_x2apic_mode(source)) { > /* 16 bit dest mask, 16 bit cluster id */ > - bitmap = dest & 0xFFFF0000; > + bitmap = dest & 0xFFFF; > cluster = (dest >> 16) << 4; > } else if (kvm_lapic_get_reg(source, APIC_DFR) == APIC_DFR_FLAT) { > /* 8 bit dest mask*/ I swear I have seen a patch from Suravee Suthikulpanit fixing this my mistake, I don't know why it was not accepted upstream. Best regards, Maxim Levitsky