From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F277BC433DB for ; Tue, 12 Jan 2021 21:50:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A6EAA20720 for ; Tue, 12 Jan 2021 21:50:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729206AbhALVfK (ORCPT ); Tue, 12 Jan 2021 16:35:10 -0500 Received: from mail-m971.mail.163.com ([123.126.97.1]:35744 "EHLO mail-m971.mail.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2437105AbhALVFa (ORCPT ); Tue, 12 Jan 2021 16:05:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=Subject:From:Message-ID:Date:MIME-Version; bh=UeJBc nkMuPyglPAiCYbAKAqv1CSOHndFYhJXJkdGJfM=; b=R3ahkkdJNZFCJWTlfOFPe ioia40C6WJSaqO3nQICxGyvr8s6DsXITXjeVFtjVraqtl7FCTHFgFsAGFu5gTMgQ 5n5//L+UQybdF5s1we6OTd4GOgKTKnnFUAuQLSOl9UElCCih4sq6bmfLjsEdiuR0 DIGBu7MDx89lZCsGPMusao= Received: from [128.224.155.93] (unknown [60.247.85.82]) by smtp1 (Coremail) with SMTP id GdxpCgB3FTmNsf1fs52rCA--.8120S2; Tue, 12 Jan 2021 22:26:40 +0800 (CST) Subject: Re: [PATCH 1/2] init/main.c: fix strings split across lines To: Steven Rostedt Cc: mhiramat@kernel.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org References: <20201230060424.29097-1-liupeibao@163.com> <20201230060424.29097-2-liupeibao@163.com> <20210111190235.3e81770f@gandalf.local.home> From: Liu Peibao Message-ID: <7a7886b2-c3bd-5adc-5d94-67343e554759@163.com> Date: Tue, 12 Jan 2021 22:26:21 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210111190235.3e81770f@gandalf.local.home> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-CM-TRANSID: GdxpCgB3FTmNsf1fs52rCA--.8120S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7ZFyrZry8Xw4DAF15Kr1xZrb_yoW8GrW8pF 4DKFWruF1vqa17A3yxXF12qFyavasFyay09F1Dtr18JFn8Ar18t3yIgr4Y9F1DtrWfW3WI qF42qFZ3tF1qvaDanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jWE__UUUUU= X-Originating-IP: [60.247.85.82] X-CM-SenderInfo: xolx1vpled0qqrwthudrp/xtbBzRkYbF0CPBdVXQABsd Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/12/21 8:02 AM, Steven Rostedt wrote: > On Wed, 30 Dec 2020 14:04:23 +0800 > Liu Peibao wrote: > >> Fix warning found by checkpatch.pl. >> >> Signed-off-by: Liu Peibao >> --- >> init/main.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/init/main.c b/init/main.c >> index 6feee7f11eaf..1e492de770c8 100644 >> --- a/init/main.c >> +++ b/init/main.c >> @@ -1470,8 +1470,7 @@ static int __ref kernel_init(void *unused) >> !try_to_run_init_process("/bin/sh")) >> return 0; >> >> - panic("No working init found. Try passing init= option to kernel. " >> - "See Linux Documentation/admin-guide/init.rst for guidance."); >> + panic("No working init found. Try passing init= option to kernel. See Linux Documentation/admin-guide/init.rst for guidance."); > > Sorry, we don't add changes to the kernel that checkpatch warns about. > checkpatch should only be run on new code. Please do not submit any patches > on existing code because checkpatch warns about it. > > -- Steve > Thanks for your replay! I get it. But I still feel a little confused that we use different standard to measure the existing code and the new code. I also checked some commits, there are similar patches too. BR, Peibao > >> } >> >> /* Open /dev/console, for stdin/stdout/stderr, this should never fail */